From: Serge Semin <fancer.lancer@gmail.com> To: Rob Herring <robh@kernel.org>, Marek Vasut <marex@denx.de>, Alexander Stein <alexander.stein@ew.tq-group.com>, Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Cai Huoqing" <cai.huoqing@linux.dev>, "Robin Murphy" <robin.murphy@arm.com>, "Jingoo Han" <jingoohan1@gmail.com>, "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>, "Richard Zhu" <hongxing.zhu@nxp.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "NXP Linux Team" <linux-imx@nxp.com>, "Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>, "Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>, "Krzysztof Wilczyński" <kw@linux.com>, "Frank Li" <Frank.Li@nxp.com>, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>, caihuoqing <caihuoqing@baidu.com>, "Vinod Koul" <vkoul@kernel.org>, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Date: Thu, 17 Nov 2022 10:43:18 +0300 [thread overview] Message-ID: <20221117074318.cd52h5ks7ay4j4wb@mobilestation> (raw) In-Reply-To: <20221116203812.GA834519-robh@kernel.org> On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > We have 2 patches doing the same thing: > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ It seems to me that that patch does two things at a time: 1. Fixes invalid fourth clock-names entry. 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name required instead of "pcie_phy". My patch does only the first part. What about moving my patch to that series and converting the Marek' patch to being applicable on top of it and fixing the imx8mm part only? That seems reasonable. -Sergey > > Please hash out which one you all want. Both seem to have clock > warnings still... > > Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <fancer.lancer@gmail.com> To: Rob Herring <robh@kernel.org>, Marek Vasut <marex@denx.de>, Alexander Stein <alexander.stein@ew.tq-group.com>, Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>, "Bjorn Helgaas" <bhelgaas@google.com>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Cai Huoqing" <cai.huoqing@linux.dev>, "Robin Murphy" <robin.murphy@arm.com>, "Jingoo Han" <jingoohan1@gmail.com>, "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>, "Richard Zhu" <hongxing.zhu@nxp.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "NXP Linux Team" <linux-imx@nxp.com>, "Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>, "Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>, "Krzysztof Wilczyński" <kw@linux.com>, "Frank Li" <Frank.Li@nxp.com>, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>, caihuoqing <caihuoqing@baidu.com>, "Vinod Koul" <vkoul@kernel.org>, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Date: Thu, 17 Nov 2022 10:43:18 +0300 [thread overview] Message-ID: <20221117074318.cd52h5ks7ay4j4wb@mobilestation> (raw) In-Reply-To: <20221116203812.GA834519-robh@kernel.org> On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > We have 2 patches doing the same thing: > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ It seems to me that that patch does two things at a time: 1. Fixes invalid fourth clock-names entry. 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name required instead of "pcie_phy". My patch does only the first part. What about moving my patch to that series and converting the Marek' patch to being applicable on top of it and fixing the imx8mm part only? That seems reasonable. -Sergey > > Please hash out which one you all want. Both seem to have clock > warnings still... > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-17 7:43 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-13 19:12 [PATCH v7 00/20] PCI: dwc: Add generic resources and Baikal-T1 support Serge Semin 2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin 2022-11-13 19:12 ` Serge Semin 2022-11-14 0:06 ` Rob Herring 2022-11-14 0:06 ` Rob Herring 2022-11-14 11:51 ` Serge Semin 2022-11-14 11:51 ` Serge Semin 2022-11-16 20:38 ` Rob Herring 2022-11-16 20:38 ` Rob Herring 2022-11-17 7:43 ` Serge Semin [this message] 2022-11-17 7:43 ` Serge Semin 2022-11-17 7:59 ` Serge Semin 2022-11-17 7:59 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints Serge Semin 2022-11-13 19:12 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 03/20] dt-bindings: PCI: dwc: Detach common RP/EP DT bindings Serge Semin 2022-11-13 19:12 ` [PATCH v7 04/20] dt-bindings: PCI: dwc: Remove bus node from the examples Serge Semin 2022-11-13 19:12 ` [PATCH v7 05/20] dt-bindings: PCI: dwc: Add phys/phy-names common properties Serge Semin 2022-11-13 19:12 ` [PATCH v7 06/20] dt-bindings: PCI: dwc: Add max-link-speed common property Serge Semin 2022-11-13 19:12 ` [PATCH v7 07/20] dt-bindings: PCI: dwc: Apply generic schema for generic device only Serge Semin 2022-11-13 19:12 ` [PATCH v7 08/20] dt-bindings: PCI: dwc: Add max-functions EP property Serge Semin 2022-11-13 19:12 ` [PATCH v7 09/20] dt-bindings: PCI: dwc: Add interrupts/interrupt-names common properties Serge Semin 2022-11-13 19:12 ` [PATCH v7 10/20] dt-bindings: PCI: dwc: Add reg/reg-names " Serge Semin 2022-11-13 19:12 ` [PATCH v7 11/20] dt-bindings: PCI: dwc: Add clocks/resets " Serge Semin 2022-11-13 19:12 ` [PATCH v7 12/20] dt-bindings: PCI: dwc: Add dma-coherent property Serge Semin 2022-11-13 19:12 ` [PATCH v7 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin 2022-11-13 19:12 ` Serge Semin 2022-11-13 19:12 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 14/20] dt-bindings: PCI: dwc: Add Baikal-T1 PCIe Root Port bindings Serge Semin 2022-11-13 19:12 ` [PATCH v7 15/20] PCI: dwc: Introduce dma-ranges property support for RC-host Serge Semin 2022-11-14 6:39 ` Manivannan Sadhasivam 2022-11-14 8:32 ` Serge Semin 2022-11-14 17:57 ` Manivannan Sadhasivam 2022-11-15 14:17 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 16/20] PCI: dwc: Introduce generic controller capabilities interface Serge Semin 2022-11-14 6:42 ` Manivannan Sadhasivam 2022-11-13 19:12 ` [PATCH v7 17/20] PCI: dwc: Introduce generic resources getter Serge Semin 2022-11-14 6:46 ` Manivannan Sadhasivam 2022-11-14 8:39 ` Serge Semin 2022-11-14 17:59 ` Manivannan Sadhasivam 2022-11-23 19:44 ` Bjorn Helgaas 2022-11-27 1:10 ` Serge Semin 2022-11-29 18:35 ` Bjorn Helgaas 2022-11-30 0:07 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 18/20] PCI: dwc: Combine iATU detection procedures Serge Semin 2022-11-14 6:49 ` Manivannan Sadhasivam 2022-11-13 19:13 ` [PATCH v7 19/20] PCI: dwc: Introduce generic platform clocks and resets Serge Semin 2022-11-14 7:01 ` Manivannan Sadhasivam 2022-11-14 9:37 ` Serge Semin 2022-11-14 18:01 ` Manivannan Sadhasivam 2022-11-13 19:13 ` [PATCH v7 20/20] PCI: dwc: Add Baikal-T1 PCIe controller support Serge Semin 2022-11-14 7:31 ` Manivannan Sadhasivam 2022-11-14 11:20 ` Serge Semin 2022-11-14 18:11 ` Manivannan Sadhasivam 2022-11-15 16:26 ` Serge Semin 2022-11-23 15:09 ` [PATCH v7 00/20] PCI: dwc: Add generic resources and Baikal-T1 support Lorenzo Pieralisi 2022-11-25 12:58 ` Serge Semin 2022-11-25 20:22 ` Serge Semin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221117074318.cd52h5ks7ay4j4wb@mobilestation \ --to=fancer.lancer@gmail.com \ --cc=Alexey.Malahov@baikalelectronics.ru \ --cc=Frank.Li@nxp.com \ --cc=Pavel.Parkhomenko@baikalelectronics.ru \ --cc=Sergey.Semin@baikalelectronics.ru \ --cc=alexander.stein@ew.tq-group.com \ --cc=bhelgaas@google.com \ --cc=cai.huoqing@linux.dev \ --cc=caihuoqing@baidu.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=gustavo.pimentel@synopsys.com \ --cc=hongxing.zhu@nxp.com \ --cc=jingoohan1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kw@linux.com \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=manivannan.sadhasivam@linaro.org \ --cc=marex@denx.de \ --cc=robh@kernel.org \ --cc=robin.murphy@arm.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.