From: Stephen Boyd <sboyd@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>,
michael@amarulasolutions.com,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
kernel test robot <lkp@intel.com>,
Allison Randal <allison@lohutok.net>,
Miaoqian Lin <linmq006@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Tero Kristo <kristo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Lindgren <tony@atomide.com>,
linux-clk@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 2/2] clk: ti: dra7-atl: don't allocate `parent_names' variable
Date: Tue, 22 Nov 2022 17:02:39 -0800 [thread overview]
Message-ID: <20221123010241.14B70C433B5@smtp.kernel.org> (raw)
In-Reply-To: <20221113181147.1626585-2-dario.binacchi@amarulasolutions.com>
Quoting Dario Binacchi (2022-11-13 10:11:47)
> The `parent_names' variable was freed also in case of kzalloc() error.
> Instead of modifying the code to perform a proper memory release, I
> decided to fix the bug by not allocating memory.
> Since only one parent name is referenced, it is not necessary to
> allocate this variable at runtime and therefore you can avoid calling
> the kzalloc() function. This simplifies the code (even calls to kfree
> can be removed) and improves the performance of the routine.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reported-by: kernel test robot <lkp@intel.com>
>
> ---
Applied to clk-next
next prev parent reply other threads:[~2022-11-23 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:11 [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API Dario Binacchi
2022-11-13 18:11 ` [PATCH v4 2/2] clk: ti: dra7-atl: don't allocate `parent_names' variable Dario Binacchi
2022-11-23 1:02 ` Stephen Boyd [this message]
2022-11-18 8:38 ` [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API Tony Lindgren
2022-11-23 1:02 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123010241.14B70C433B5@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=allison@lohutok.net \
--cc=dario.binacchi@amarulasolutions.com \
--cc=kristo@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.