From: Tony Lindgren <tony@atomide.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
Amarula patchwork <linux-amarula@amarulasolutions.com>,
michael@amarulasolutions.com,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jakob Koschel <jakobkoschel@gmail.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Len Baker <len.baker@gmx.com>, Liang He <windhl@126.com>,
Miaoqian Lin <linmq006@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Tero Kristo <kristo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-clk@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API
Date: Fri, 18 Nov 2022 10:38:37 +0200 [thread overview]
Message-ID: <Y3dEjfwJKWFlSFPb@atomide.com> (raw)
In-Reply-To: <20221113181147.1626585-1-dario.binacchi@amarulasolutions.com>
* Dario Binacchi <dario.binacchi@amarulasolutions.com> [221113 18:01]:
> The ti_clk_register() and ti_clk_register_omap_hw() functions are always
> called with the parameter of type "struct device" set to NULL, since the
> functions from which they are called always have a parameter of type
> "struct device_node". Replacing "struct device" type parameter with
> "struct device_node" will allow you to register a TI clock to the common
> clock framework by taking advantage of the facilities provided by the
> "struct device_node" type. Further, adding the "of_" prefix to the name
> of these functions explicitly binds them to the "struct device_node"
> type.
Looks good to me, nice clean-up:
Reviewed-by: Tony Lindgren <tony@atomide.com>
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2022-11-18 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:11 [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API Dario Binacchi
2022-11-13 18:11 ` [PATCH v4 2/2] clk: ti: dra7-atl: don't allocate `parent_names' variable Dario Binacchi
2022-11-23 1:02 ` Stephen Boyd
2022-11-18 8:38 ` Tony Lindgren [this message]
2022-11-23 1:02 ` [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3dEjfwJKWFlSFPb@atomide.com \
--to=tony@atomide.com \
--cc=Julia.Lawall@inria.fr \
--cc=allison@lohutok.net \
--cc=dario.binacchi@amarulasolutions.com \
--cc=gregkh@linuxfoundation.org \
--cc=jakobkoschel@gmail.com \
--cc=kristo@kernel.org \
--cc=len.baker@gmx.com \
--cc=linmq006@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.