From: Maxime Ripard <maxime@cerno.tech>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Helge Deller <deller@gmx.de>,
Michael Schmitz <schmitzmic@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to simple display pipe
Date: Mon, 28 Nov 2022 09:21:08 +0100 [thread overview]
Message-ID: <20221128082108.ntjhevb4ku6lnvib@houat> (raw)
In-Reply-To: <3b0862187f1c8910089cb0d06a8669caa985042e.1669406382.git.geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi,
On Fri, Nov 25, 2022 at 09:31:09PM +0100, Geert Uytterhoeven wrote:
> From: Thomas Zimmermann <tzimmermann@suse.de>
>
> The mode fix-up function for simple display helpers is equivalent to the
> regular pipeline's CRTC mode fix-up function. It's called to adjust the
> CRTC's display mode for the encoder. Add this function for DRM fbconv
> helpers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
It's not clear to me why you'd need a mode_fixup in the first place.
Like said in the documentation you added, atomic_check is usually the
better option for the atomic modesetting drivers.
So, why is it needed?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>,
linux-m68k@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to simple display pipe
Date: Mon, 28 Nov 2022 09:21:08 +0100 [thread overview]
Message-ID: <20221128082108.ntjhevb4ku6lnvib@houat> (raw)
In-Reply-To: <3b0862187f1c8910089cb0d06a8669caa985042e.1669406382.git.geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi,
On Fri, Nov 25, 2022 at 09:31:09PM +0100, Geert Uytterhoeven wrote:
> From: Thomas Zimmermann <tzimmermann@suse.de>
>
> The mode fix-up function for simple display helpers is equivalent to the
> regular pipeline's CRTC mode fix-up function. It's called to adjust the
> CRTC's display mode for the encoder. Add this function for DRM fbconv
> helpers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
It's not clear to me why you'd need a mode_fixup in the first place.
Like said in the documentation you added, atomic_check is usually the
better option for the atomic modesetting drivers.
So, why is it needed?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-11-28 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 20:31 [PATCH/RFC 0/3] Atari DRM driver Geert Uytterhoeven
2022-11-25 20:31 ` Geert Uytterhoeven
2022-11-25 20:31 ` [PATCH/RFC 1/3] video: fbdev: c2p: Add transp2() and transp2x() Geert Uytterhoeven
2022-11-25 20:31 ` Geert Uytterhoeven
2022-11-25 20:31 ` [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to simple display pipe Geert Uytterhoeven
2022-11-25 20:31 ` Geert Uytterhoeven
2022-11-28 8:21 ` Maxime Ripard [this message]
2022-11-28 8:21 ` Maxime Ripard
2022-11-25 20:31 ` [PATCH/RFC 3/3] drm: atari: Add a DRM driver for Atari graphics hardware Geert Uytterhoeven
2022-11-25 20:31 ` Geert Uytterhoeven
2022-11-26 14:51 ` Thomas Zimmermann
2022-11-28 13:08 ` Geert Uytterhoeven
2022-11-28 13:08 ` Geert Uytterhoeven
2022-11-28 8:28 ` Maxime Ripard
2022-11-28 8:28 ` Maxime Ripard
2023-01-23 15:03 ` [PATCH/RFC 0/3] Atari DRM driver John Paul Adrian Glaubitz
2023-01-23 15:03 ` John Paul Adrian Glaubitz
2023-01-23 15:10 ` Geert Uytterhoeven
2023-01-23 15:10 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128082108.ntjhevb4ku6lnvib@houat \
--to=maxime@cerno.tech \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=schmitzmic@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.