From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/26] drm: imx: Define and use generic PM ops
Date: Tue, 29 Nov 2022 19:17:10 +0000 [thread overview]
Message-ID: <20221129191733.137897-4-paul@crapouillou.net> (raw)
In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net>
Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a
"struct dev_pm_ops" that can be used by this driver, instead of using
custom PM callbacks with the same behaviour.
v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an
exported dev_pm_ops.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/imx-drm-core.c | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index e060fa6cbcb9..1992934034e0 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -10,6 +10,7 @@
#include <linux/dma-buf.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <video/imx-ipu-v3.h>
@@ -298,36 +299,20 @@ static int imx_drm_platform_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int imx_drm_suspend(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_suspend(drm_dev);
-}
-
-static int imx_drm_resume(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_resume(drm_dev);
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(imx_drm_pm_ops, imx_drm_suspend, imx_drm_resume);
-
static const struct of_device_id imx_drm_dt_ids[] = {
{ .compatible = "fsl,imx-display-subsystem", },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, imx_drm_dt_ids);
+DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(imx_pm_ops);
+
static struct platform_driver imx_drm_pdrv = {
.probe = imx_drm_platform_probe,
.remove = imx_drm_platform_remove,
.driver = {
.name = "imx-drm",
- .pm = &imx_drm_pm_ops,
+ .pm = pm_sleep_ptr(&imx_pm_ops),
.of_match_table = imx_drm_dt_ids,
},
};
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Paul Cercueil <paul@crapouillou.net>,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/26] drm: imx: Define and use generic PM ops
Date: Tue, 29 Nov 2022 19:17:10 +0000 [thread overview]
Message-ID: <20221129191733.137897-4-paul@crapouillou.net> (raw)
In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net>
Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a
"struct dev_pm_ops" that can be used by this driver, instead of using
custom PM callbacks with the same behaviour.
v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an
exported dev_pm_ops.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/imx-drm-core.c | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index e060fa6cbcb9..1992934034e0 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -10,6 +10,7 @@
#include <linux/dma-buf.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <video/imx-ipu-v3.h>
@@ -298,36 +299,20 @@ static int imx_drm_platform_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int imx_drm_suspend(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_suspend(drm_dev);
-}
-
-static int imx_drm_resume(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_resume(drm_dev);
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(imx_drm_pm_ops, imx_drm_suspend, imx_drm_resume);
-
static const struct of_device_id imx_drm_dt_ids[] = {
{ .compatible = "fsl,imx-display-subsystem", },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, imx_drm_dt_ids);
+DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(imx_pm_ops);
+
static struct platform_driver imx_drm_pdrv = {
.probe = imx_drm_platform_probe,
.remove = imx_drm_platform_remove,
.driver = {
.name = "imx-drm",
- .pm = &imx_drm_pm_ops,
+ .pm = pm_sleep_ptr(&imx_pm_ops),
.of_match_table = imx_drm_dt_ids,
},
};
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/26] drm: imx: Define and use generic PM ops
Date: Tue, 29 Nov 2022 19:17:10 +0000 [thread overview]
Message-ID: <20221129191733.137897-4-paul@crapouillou.net> (raw)
In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net>
Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a
"struct dev_pm_ops" that can be used by this driver, instead of using
custom PM callbacks with the same behaviour.
v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an
exported dev_pm_ops.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/imx-drm-core.c | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index e060fa6cbcb9..1992934034e0 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -10,6 +10,7 @@
#include <linux/dma-buf.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <video/imx-ipu-v3.h>
@@ -298,36 +299,20 @@ static int imx_drm_platform_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int imx_drm_suspend(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_suspend(drm_dev);
-}
-
-static int imx_drm_resume(struct device *dev)
-{
- struct drm_device *drm_dev = dev_get_drvdata(dev);
-
- return drm_mode_config_helper_resume(drm_dev);
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(imx_drm_pm_ops, imx_drm_suspend, imx_drm_resume);
-
static const struct of_device_id imx_drm_dt_ids[] = {
{ .compatible = "fsl,imx-display-subsystem", },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, imx_drm_dt_ids);
+DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(imx_pm_ops);
+
static struct platform_driver imx_drm_pdrv = {
.probe = imx_drm_platform_probe,
.remove = imx_drm_platform_remove,
.driver = {
.name = "imx-drm",
- .pm = &imx_drm_pm_ops,
+ .pm = pm_sleep_ptr(&imx_pm_ops),
.of_match_table = imx_drm_dt_ids,
},
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-29 19:18 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 19:17 [PATCH v2 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 01/26] drm: modeset-helper: Add DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS macro Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 02/26] drm: bochs: Define and use generic PM ops Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil [this message]
2022-11-29 19:17 ` [PATCH v2 03/26] drm: imx: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 04/26] drm: rockchip: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 05/26] drm: tegra: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 06/26] drm: sun4i: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-30 4:08 ` Samuel Holland
2022-11-30 4:08 ` Samuel Holland
2022-11-30 4:08 ` Samuel Holland
2022-11-29 19:17 ` [PATCH v2 07/26] drm: mxsfb: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 21:48 ` Marek Vasut
2022-11-29 21:48 ` Marek Vasut
2022-11-29 21:48 ` Marek Vasut
2022-11-29 19:17 ` [PATCH v2 08/26] drm: atmel-hlcdc: Remove #ifdef guards for PM related functions Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 09/26] drm: exynos: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 10/26] drm: imx/dcss: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 11/26] drm: bridge/dw-hdmi: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 12/26] drm: etnaviv: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-12-15 19:22 ` Lucas Stach
2022-12-15 19:22 ` Lucas Stach
2022-11-29 19:17 ` [PATCH v2 13/26] drm: fsl-dcu: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` [PATCH v2 14/26] drm: mediatek: " Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:17 ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 15/26] drm: omap: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 16/26] drm: panfrost: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:54 ` Alyssa Rosenzweig
2022-11-29 19:54 ` Alyssa Rosenzweig
2022-11-29 19:19 ` [PATCH v2 17/26] drm: rcar-du: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:43 ` Laurent Pinchart
2022-11-29 19:43 ` Laurent Pinchart
2022-11-29 21:05 ` Paul Cercueil
2022-11-29 21:05 ` Paul Cercueil
2022-11-29 21:24 ` Laurent Pinchart
2022-11-29 21:24 ` Laurent Pinchart
2022-11-29 19:19 ` [PATCH v2 18/26] drm: rockchip: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 19/26] drm: shmobile: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:44 ` Laurent Pinchart
2022-11-29 19:44 ` Laurent Pinchart
2022-11-29 19:19 ` [PATCH v2 20/26] drm: tegra: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 21/26] drm: tilcdc: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 22/26] drm: vboxvideo: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 23/26] drm: vc4: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 24/26] drm: gm12u320: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 25/26] drm: tidss: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [PATCH v2 26/26] drm/i915/gt: " Paul Cercueil
2022-11-29 19:19 ` Paul Cercueil
2022-11-29 19:19 ` [Intel-gfx] " Paul Cercueil
2022-12-07 15:56 ` Rodrigo Vivi
2022-12-07 15:56 ` Rodrigo Vivi
2022-12-07 15:56 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129191733.137897-4-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.