From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
yunfei.dong@mediatek.com
Subject: Re: [PATCH v5 3/3] arm64: dts: mt8192: Add video-codec nodes
Date: Mon, 5 Dec 2022 18:04:33 -0300 [thread overview]
Message-ID: <20221205210433.w3nbwmegcnvsyesc@notapiano> (raw)
In-Reply-To: <20221128143832.25584-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 28, 2022 at 10:38:32PM +0800, Allen-KH Cheng wrote:
> Add video-codec lat and core nodes for mt8192 SoC.
Even though the rule is to use generic names in the DT, here in the commit
message and title I would have called them "video decoder nodes", to be more
specific and differentiate from the encoder nodes. But the way you wrote is not
wrong, so feel free to ignore this comment and leave it as it is.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
yunfei.dong@mediatek.com
Subject: Re: [PATCH v5 3/3] arm64: dts: mt8192: Add video-codec nodes
Date: Mon, 5 Dec 2022 18:04:33 -0300 [thread overview]
Message-ID: <20221205210433.w3nbwmegcnvsyesc@notapiano> (raw)
In-Reply-To: <20221128143832.25584-4-allen-kh.cheng@mediatek.com>
On Mon, Nov 28, 2022 at 10:38:32PM +0800, Allen-KH Cheng wrote:
> Add video-codec lat and core nodes for mt8192 SoC.
Even though the rule is to use generic names in the DT, here in the commit
message and title I would have called them "video decoder nodes", to be more
specific and differentiate from the encoder nodes. But the way you wrote is not
wrong, so feel free to ignore this comment and leave it as it is.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-05 21:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 14:38 [PATCH v5 0/3] Add vcodec lat and core nodes for mt8192 Allen-KH Cheng
2022-11-28 14:38 ` Allen-KH Cheng
2022-11-28 14:38 ` [PATCH v5 1/3] media: dt-bindings: media: mediatek: Rename child node names for decoder Allen-KH Cheng
2022-11-28 14:38 ` Allen-KH Cheng
2022-12-01 14:57 ` Krzysztof Kozlowski
2022-12-01 14:57 ` Krzysztof Kozlowski
2022-12-05 21:32 ` Nícolas F. R. A. Prado
2022-12-05 21:32 ` Nícolas F. R. A. Prado
2022-11-28 14:38 ` [PATCH v5 2/3] media: dt-bindings: media: mediatek: Remove "dma-ranges" property " Allen-KH Cheng
2022-11-28 14:38 ` Allen-KH Cheng
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-12-01 23:14 ` Rob Herring
2022-12-01 23:14 ` Rob Herring
2022-12-05 20:32 ` Nícolas F. R. A. Prado
2022-12-05 20:32 ` Nícolas F. R. A. Prado
2022-11-28 14:38 ` [PATCH v5 3/3] arm64: dts: mt8192: Add video-codec nodes Allen-KH Cheng
2022-11-28 14:38 ` Allen-KH Cheng
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-11-30 11:27 ` AngeloGioacchino Del Regno
2022-12-05 21:04 ` Nícolas F. R. A. Prado [this message]
2022-12-05 21:04 ` Nícolas F. R. A. Prado
2022-12-01 9:12 ` [PATCH v5 0/3] Add vcodec lat and core nodes for mt8192 Chen-Yu Tsai
2022-12-01 9:12 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205210433.w3nbwmegcnvsyesc@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.