From: Ard Biesheuvel <ardb@kernel.org> To: linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH v2 0/2] ARM: allow kernel mode NEON in softirq context Date: Wed, 7 Dec 2022 11:39:34 +0100 [thread overview] Message-ID: <20221207103936.2198407-1-ardb@kernel.org> (raw) Currently on ARM, we only permit kernel mode NEON in task context, and NEON based processing triggered from softirq context is queued for asynchronous completion via the crypto API's cryptd layer. For IPsec packet encryption involving highly performant crypto implementations, this results in a substantial performance hit, and so it would be desirable to permit those crypto operations to complete synchronously even when invoked from softirq context. For example, on a 1 GHz Cortex-A53 machine (SynQuacer), AES-256-GCM executes in 7.2 cycles per byte, putting an upper bound of ~140 MB/s on the achievable throughput of a single CPU. Without these changes, an IPsec tunnel from a 32-bit VM to the 64-bit host can achieve a throughput of 9.5 MB/s TX and 11.9 MB/s RX. When the crypto algorithm is permitted to execute in softirq context, the throughput increases to 16.5 MB/s TX and 41 MB/s RX. (This is measured using debian's iperf3 3.11 with the default options) So let's reorganize the VFP state handling so that it its critical handling of the FPU registers runs with softirqs disabled. Then, update the kernel_neon_begin()/end() logic to keep softirq processing disabled as long as the NEON is being used in kernel mode. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Russell King <linux@armlinux.org.uk> Ard Biesheuvel (2): ARM: vfp: Manipulate VFP state with softirqs disabled ARM: permit non-nested kernel mode NEON in softirq context arch/arm/include/asm/assembler.h | 19 ++++++++++++------- arch/arm/include/asm/simd.h | 8 ++++++++ arch/arm/kernel/asm-offsets.c | 1 + arch/arm/vfp/entry.S | 4 ++-- arch/arm/vfp/vfphw.S | 4 ++-- arch/arm/vfp/vfpmodule.c | 19 ++++++++++++------- 6 files changed, 37 insertions(+), 18 deletions(-) create mode 100644 arch/arm/include/asm/simd.h -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org> To: linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH v2 0/2] ARM: allow kernel mode NEON in softirq context Date: Wed, 7 Dec 2022 11:39:34 +0100 [thread overview] Message-ID: <20221207103936.2198407-1-ardb@kernel.org> (raw) Currently on ARM, we only permit kernel mode NEON in task context, and NEON based processing triggered from softirq context is queued for asynchronous completion via the crypto API's cryptd layer. For IPsec packet encryption involving highly performant crypto implementations, this results in a substantial performance hit, and so it would be desirable to permit those crypto operations to complete synchronously even when invoked from softirq context. For example, on a 1 GHz Cortex-A53 machine (SynQuacer), AES-256-GCM executes in 7.2 cycles per byte, putting an upper bound of ~140 MB/s on the achievable throughput of a single CPU. Without these changes, an IPsec tunnel from a 32-bit VM to the 64-bit host can achieve a throughput of 9.5 MB/s TX and 11.9 MB/s RX. When the crypto algorithm is permitted to execute in softirq context, the throughput increases to 16.5 MB/s TX and 41 MB/s RX. (This is measured using debian's iperf3 3.11 with the default options) So let's reorganize the VFP state handling so that it its critical handling of the FPU registers runs with softirqs disabled. Then, update the kernel_neon_begin()/end() logic to keep softirq processing disabled as long as the NEON is being used in kernel mode. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Russell King <linux@armlinux.org.uk> Ard Biesheuvel (2): ARM: vfp: Manipulate VFP state with softirqs disabled ARM: permit non-nested kernel mode NEON in softirq context arch/arm/include/asm/assembler.h | 19 ++++++++++++------- arch/arm/include/asm/simd.h | 8 ++++++++ arch/arm/kernel/asm-offsets.c | 1 + arch/arm/vfp/entry.S | 4 ++-- arch/arm/vfp/vfphw.S | 4 ++-- arch/arm/vfp/vfpmodule.c | 19 ++++++++++++------- 6 files changed, 37 insertions(+), 18 deletions(-) create mode 100644 arch/arm/include/asm/simd.h -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-12-07 10:39 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-07 10:39 Ard Biesheuvel [this message] 2022-12-07 10:39 ` [PATCH v2 0/2] ARM: allow kernel mode NEON in softirq context Ard Biesheuvel 2022-12-07 10:39 ` [PATCH v2 1/2] ARM: vfp: Manipulate VFP state with softirqs disabled Ard Biesheuvel 2022-12-07 10:39 ` Ard Biesheuvel 2022-12-15 10:22 ` Linus Walleij 2022-12-15 10:22 ` Linus Walleij 2022-12-07 10:39 ` [PATCH v2 2/2] ARM: permit non-nested kernel mode NEON in softirq context Ard Biesheuvel 2022-12-07 10:39 ` Ard Biesheuvel 2022-12-15 10:26 ` Linus Walleij 2022-12-15 10:26 ` Linus Walleij 2022-12-15 10:43 ` Ard Biesheuvel 2022-12-15 10:43 ` Ard Biesheuvel 2022-12-15 10:51 ` Russell King (Oracle) 2022-12-15 10:51 ` Russell King (Oracle) 2022-12-15 11:48 ` Ard Biesheuvel 2022-12-15 11:48 ` Ard Biesheuvel 2022-12-12 14:37 ` [PATCH v2 0/2] ARM: allow " Martin Willi 2022-12-12 14:37 ` Martin Willi 2022-12-13 16:56 ` Ard Biesheuvel 2022-12-13 16:56 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221207103936.2198407-1-ardb@kernel.org \ --to=ardb@kernel.org \ --cc=arnd@arndb.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux@armlinux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.