Re: [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios

From: SeongJae Park <sj@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	vishal.moola@gmail.com, willy@infradead.org, david@redhat.com
Subject: Re: [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios
Date: Wed, 28 Dec 2022 17:55:04 +0000	[thread overview]
Message-ID: <20221228175504.149395-1-sj@kernel.org> (raw)
In-Reply-To: <20221228113413.10329-1-wangkefeng.wang@huawei.com>

Hi Kefeng,

On Wed, 28 Dec 2022 19:34:06 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> v3:
> - more thoroughly converting in page_idle_get_folio() suggested by Matthew
>   also do it in damon_get_folio().
> - address some commets from SeongJae
> 
> v2:
> - drop unsafe pfn_to_online_folio(), convert page_idle_get_page() and 
>   damon_get_page() to return a folio after grab a reference
> - convert damon hugetlb related functions
> - rebased on next-20221226.
> 
> Kefeng Wang (7):
>   mm: page_idle: Convert page idle to use folios
>   mm/damon: introduce damon_get_folio()
>   mm/damon: convert damon_ptep/pmdp_mkold() to use folios
>   mm/damon: paddr: convert damon_pa_*() to use folios
>   mm/damon: vaddr: convert damon_young_pmd_entry() to use folio
>   mm/damon: remove unneed damon_get_page()
>   mm/damon: vaddr: convert hugetlb related function to use folios

Thank you so much for your efforts on this work.  I found I forgot mentioning
some trivial typos in the first, the sixth and the seventh patches, so
commented.  I should have commented those earlier, sorry.

Other than those,

Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ

> 
>  mm/damon/ops-common.c | 38 +++++++++++++++-------------
>  mm/damon/ops-common.h |  2 +-
>  mm/damon/paddr.c      | 58 +++++++++++++++++++------------------------
>  mm/damon/vaddr.c      | 38 ++++++++++++++--------------
>  mm/page_idle.c        | 47 ++++++++++++++++++-----------------
>  5 files changed, 91 insertions(+), 92 deletions(-)
> 
> -- 
> 2.35.3
> 