From: "Alice Guo (OSS)" <alice.guo@oss.nxp.com> To: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH v1 3/4] qoriq_thermal: No need to program site adjustment register Date: Thu, 5 Jan 2023 18:17:47 +0800 [thread overview] Message-ID: <20230105101748.6714-4-alice.guo@oss.nxp.com> (raw) In-Reply-To: <20230105101748.6714-1-alice.guo@oss.nxp.com> From: Pankit Garg <pankit.garg@nxp.com> No need to program site adjustment register, as programming these registers do not give accurate value and also these registers are not mentioned in Reference Manual. Signed-off-by: Pankit Garg <pankit.garg@nxp.com> Signed-off-by: Alice Guo <alice.guo@nxp.com> --- drivers/thermal/qoriq_thermal.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index 18030bd68687..24ef446414cc 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 // // Copyright 2016 Freescale Semiconductor, Inc. +// Copyright 2022 NXP #include <linux/clk.h> #include <linux/err.h> @@ -245,8 +246,6 @@ static int imx93_tmu_calibration(struct device *dev, static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) { - int i; - /* Disable interrupt, using polling instead */ regmap_write(data->regmap, REGS_TIER, TIER_DISABLE); @@ -257,13 +256,9 @@ static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) } else if (data->ver == TMU_VER93) { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V21); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } else { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } /* Disable monitoring */ -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Alice Guo (OSS)" <alice.guo@oss.nxp.com> To: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH v1 3/4] qoriq_thermal: No need to program site adjustment register Date: Thu, 5 Jan 2023 18:17:47 +0800 [thread overview] Message-ID: <20230105101748.6714-4-alice.guo@oss.nxp.com> (raw) In-Reply-To: <20230105101748.6714-1-alice.guo@oss.nxp.com> From: Pankit Garg <pankit.garg@nxp.com> No need to program site adjustment register, as programming these registers do not give accurate value and also these registers are not mentioned in Reference Manual. Signed-off-by: Pankit Garg <pankit.garg@nxp.com> Signed-off-by: Alice Guo <alice.guo@nxp.com> --- drivers/thermal/qoriq_thermal.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index 18030bd68687..24ef446414cc 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 // // Copyright 2016 Freescale Semiconductor, Inc. +// Copyright 2022 NXP #include <linux/clk.h> #include <linux/err.h> @@ -245,8 +246,6 @@ static int imx93_tmu_calibration(struct device *dev, static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) { - int i; - /* Disable interrupt, using polling instead */ regmap_write(data->regmap, REGS_TIER, TIER_DISABLE); @@ -257,13 +256,9 @@ static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) } else if (data->ver == TMU_VER93) { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V21); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } else { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } /* Disable monitoring */ -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-05 10:19 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-05 10:17 [PATCH v1 0/4] add i.MX93 TMU support Alice Guo (OSS) 2023-01-05 10:17 ` Alice Guo (OSS) 2023-01-05 10:17 ` [PATCH v1 1/4] dt-bindings: thermal: qoriq-thermal: Add compatible for i.MX93 Alice Guo (OSS) 2023-01-05 10:17 ` Alice Guo (OSS) 2023-01-06 12:53 ` Krzysztof Kozlowski 2023-01-06 12:53 ` Krzysztof Kozlowski 2023-01-05 10:17 ` [PATCH v1 2/4] thermal: qoriq: add i.MX93 TMU support Alice Guo (OSS) 2023-01-05 10:17 ` Alice Guo (OSS) 2023-01-31 6:04 ` Alice Guo (OSS) 2023-01-31 6:04 ` Alice Guo (OSS) 2023-02-10 13:48 ` Daniel Lezcano 2023-02-10 13:48 ` Daniel Lezcano 2023-03-10 8:20 ` Alexander Stein 2023-03-10 8:20 ` Alexander Stein 2023-01-05 10:17 ` Alice Guo (OSS) [this message] 2023-01-05 10:17 ` [PATCH v1 3/4] qoriq_thermal: No need to program site adjustment register Alice Guo (OSS) 2023-01-05 10:17 ` [PATCH v1 4/4] arm64: dts: imx93: Add CPU thermal zone Alice Guo (OSS) 2023-01-05 10:17 ` Alice Guo (OSS) 2023-01-06 12:53 ` Krzysztof Kozlowski 2023-01-06 12:53 ` Krzysztof Kozlowski 2023-03-10 8:20 ` Alexander Stein 2023-03-10 8:20 ` Alexander Stein 2023-03-10 9:09 ` [PATCH v1 0/4] add i.MX93 TMU support Alexander Stein 2023-03-10 9:09 ` Alexander Stein
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230105101748.6714-4-alice.guo@oss.nxp.com \ --to=alice.guo@oss.nxp.com \ --cc=amitk@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.