From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, cluster-devel@redhat.com,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: Re: return an ERR_PTR from __filemap_get_folio v2
Date: Sat, 21 Jan 2023 17:06:41 -0800 [thread overview]
Message-ID: <20230121170641.121f4224a0e8304765bb4738@linux-foundation.org> (raw)
In-Reply-To: <20230121065755.1140136-1-hch@lst.de>
On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> __filemap_get_folio and its wrappers can return NULL for three different
> conditions, which in some cases requires the caller to reverse engineer
> the decision making. This is fixed by returning an ERR_PTR instead of
> NULL and thus transporting the reason for the failure. But to make
> that work we first need to ensure that no xa_value special case is
> returned and thus return the FGP_ENTRY flag. It turns out that flag
> is barely used and can usually be deal with in a better way.
>
> Note that the shmem patches in here are non-trivial and need some
> careful review and testing.
I'll hide for a while, awaiting that review. Plus...
> Changes since v1:
> - drop the patches to check for errors in btrfs and gfs2
> - document the new calling conventions for the wrappers around
> __filemap_get_folio
> - rebased against the iomap changes in latest linux-next
This patchset doesn't apply to fs/btrfs/ because linux-next contains
this 6+ month-old commit:
commit 964688b32d9ada55a7fce2e650d85ef24188f73f
Author: Matthew Wilcox (Oracle) <willy@infradead.org>
AuthorDate: Tue May 17 18:03:27 2022 -0400
Commit: Matthew Wilcox (Oracle) <willy@infradead.org>
CommitDate: Wed Jun 29 08:51:07 2022 -0400
btrfs: Use a folio in wait_dev_supers()
Matthew, what's the story here?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2
Date: Sat, 21 Jan 2023 17:06:41 -0800 [thread overview]
Message-ID: <20230121170641.121f4224a0e8304765bb4738@linux-foundation.org> (raw)
In-Reply-To: <20230121065755.1140136-1-hch@lst.de>
On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig <hch@lst.de> wrote:
> Hi all,
>
> __filemap_get_folio and its wrappers can return NULL for three different
> conditions, which in some cases requires the caller to reverse engineer
> the decision making. This is fixed by returning an ERR_PTR instead of
> NULL and thus transporting the reason for the failure. But to make
> that work we first need to ensure that no xa_value special case is
> returned and thus return the FGP_ENTRY flag. It turns out that flag
> is barely used and can usually be deal with in a better way.
>
> Note that the shmem patches in here are non-trivial and need some
> careful review and testing.
I'll hide for a while, awaiting that review. Plus...
> Changes since v1:
> - drop the patches to check for errors in btrfs and gfs2
> - document the new calling conventions for the wrappers around
> __filemap_get_folio
> - rebased against the iomap changes in latest linux-next
This patchset doesn't apply to fs/btrfs/ because linux-next contains
this 6+ month-old commit:
commit 964688b32d9ada55a7fce2e650d85ef24188f73f
Author: Matthew Wilcox (Oracle) <willy@infradead.org>
AuthorDate: Tue May 17 18:03:27 2022 -0400
Commit: Matthew Wilcox (Oracle) <willy@infradead.org>
CommitDate: Wed Jun 29 08:51:07 2022 -0400
btrfs: Use a folio in wait_dev_supers()
Matthew, what's the story here?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: return an ERR_PTR from __filemap_get_folio v2
Date: Sat, 21 Jan 2023 17:06:41 -0800 [thread overview]
Message-ID: <20230121170641.121f4224a0e8304765bb4738@linux-foundation.org> (raw)
In-Reply-To: <20230121065755.1140136-1-hch-jcswGhMUV9g@public.gmane.org>
On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> Hi all,
>
> __filemap_get_folio and its wrappers can return NULL for three different
> conditions, which in some cases requires the caller to reverse engineer
> the decision making. This is fixed by returning an ERR_PTR instead of
> NULL and thus transporting the reason for the failure. But to make
> that work we first need to ensure that no xa_value special case is
> returned and thus return the FGP_ENTRY flag. It turns out that flag
> is barely used and can usually be deal with in a better way.
>
> Note that the shmem patches in here are non-trivial and need some
> careful review and testing.
I'll hide for a while, awaiting that review. Plus...
> Changes since v1:
> - drop the patches to check for errors in btrfs and gfs2
> - document the new calling conventions for the wrappers around
> __filemap_get_folio
> - rebased against the iomap changes in latest linux-next
This patchset doesn't apply to fs/btrfs/ because linux-next contains
this 6+ month-old commit:
commit 964688b32d9ada55a7fce2e650d85ef24188f73f
Author: Matthew Wilcox (Oracle) <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
AuthorDate: Tue May 17 18:03:27 2022 -0400
Commit: Matthew Wilcox (Oracle) <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
CommitDate: Wed Jun 29 08:51:07 2022 -0400
btrfs: Use a folio in wait_dev_supers()
Matthew, what's the story here?
next prev parent reply other threads:[~2023-01-22 1:06 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 6:57 return an ERR_PTR from __filemap_get_folio v2 Christoph Hellwig
2023-01-21 6:57 ` Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 1/7] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 2/7] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 3/7] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig
2023-01-21 6:57 ` Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 4/7] shmem: remove shmem_get_partial_folio Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 5/7] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig
2023-01-21 6:57 ` Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 6/7] mm: remove FGP_ENTRY Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 6:57 ` [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-21 6:57 ` [Cluster-devel] " Christoph Hellwig
2023-01-21 11:52 ` kernel test robot
2023-01-21 11:52 ` kernel test robot
2023-01-21 11:52 ` [Cluster-devel] " kernel test robot
2023-01-21 14:28 ` Christoph Hellwig
2023-01-21 14:28 ` [Cluster-devel] " Christoph Hellwig
2023-01-23 15:44 ` David Sterba
2023-01-23 15:44 ` [Cluster-devel] " David Sterba
2023-01-26 17:24 ` Ryusuke Konishi
2023-01-26 17:24 ` Ryusuke Konishi
2023-01-26 17:24 ` [Cluster-devel] " Ryusuke Konishi
2023-03-10 4:31 ` Naoya Horiguchi
2023-03-10 4:31 ` [Cluster-devel] " Naoya Horiguchi
2023-03-10 7:00 ` Christoph Hellwig
2023-03-10 7:00 ` Christoph Hellwig
2023-03-10 7:00 ` [Cluster-devel] " Christoph Hellwig
2023-03-10 8:02 ` Naoya Horiguchi
2023-03-10 8:02 ` [Cluster-devel] " Naoya Horiguchi
2023-01-22 1:06 ` Andrew Morton [this message]
2023-01-22 1:06 ` return an ERR_PTR from __filemap_get_folio v2 Andrew Morton
2023-01-22 1:06 ` [Cluster-devel] " Andrew Morton
2023-01-22 7:20 ` Christoph Hellwig
2023-01-22 7:20 ` Christoph Hellwig
2023-01-22 7:20 ` [Cluster-devel] " Christoph Hellwig
2023-01-23 18:59 ` Andrew Morton
2023-01-23 18:59 ` Andrew Morton
2023-01-23 18:59 ` [Cluster-devel] " Andrew Morton
2023-01-23 19:18 ` Christoph Hellwig
2023-01-23 19:18 ` Christoph Hellwig
2023-01-23 19:18 ` [Cluster-devel] " Christoph Hellwig
2023-03-28 23:04 ` Andrew Morton
2023-03-28 23:04 ` [Cluster-devel] " Andrew Morton
2023-03-29 23:56 ` Christoph Hellwig
2023-03-29 23:56 ` Christoph Hellwig
2023-03-29 23:56 ` [Cluster-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121170641.121f4224a0e8304765bb4738@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.