From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: masahiroy@kernel.org, nicolas@fjasle.eu,
linux-kbuild@vger.kernel.org, trix@redhat.com,
llvm@lists.linux.dev, ndesaulniers@google.com, npiggin@gmail.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags
Date: Tue, 24 Jan 2023 10:30:48 -0600 [thread overview]
Message-ID: <20230124163048.GL25951@gate.crashing.org> (raw)
In-Reply-To: <Y9AD/Mejnv6jp7Np@dev-arch.thelio-3990X>
On Tue, Jan 24, 2023 at 09:14:52AM -0700, Nathan Chancellor wrote:
> On Mon, Jan 23, 2023 at 09:07:16AM -0600, Segher Boessenkool wrote:
> > And here it is even more obviously fine. If you need obfuscation like
> > in your patch, it is better not to do this imo.
>
> I do not think this patch really obfuscates anything? The filtering is
> pretty clear to me.
And not having such filtering is more obvious and more clear.
It doesn't matter much for just this patch of course, but it will make
the code significantly harder to read (and deal with in other ways) if
this continues.
> If this is a real objection to the patch, I suppose we could just
> localize '-Qunused-arguments' to this Makefile and be done with it but I
> do not think this change is a bad solution to the problem either.
It is a comment about the direction this patch is moving us in. I don't
think it is a good idea at all to try to avoid all warnings, and even
more so it is a bad idea to make objectively worse source code just to
appease a trigger-happy and questionable warning.
As I said, you can often avoid warnings by writing better code, like
part of the patch did. That is a good reaction to warnings. Making
worse code to avoid warnings is not a good idea normally.
Just don't use -Werror by default, and don't make other people suffer
its yoke!
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: nicolas@fjasle.eu, linux-kbuild@vger.kernel.org, trix@redhat.com,
masahiroy@kernel.org, llvm@lists.linux.dev,
ndesaulniers@google.com, npiggin@gmail.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags
Date: Tue, 24 Jan 2023 10:30:48 -0600 [thread overview]
Message-ID: <20230124163048.GL25951@gate.crashing.org> (raw)
In-Reply-To: <Y9AD/Mejnv6jp7Np@dev-arch.thelio-3990X>
On Tue, Jan 24, 2023 at 09:14:52AM -0700, Nathan Chancellor wrote:
> On Mon, Jan 23, 2023 at 09:07:16AM -0600, Segher Boessenkool wrote:
> > And here it is even more obviously fine. If you need obfuscation like
> > in your patch, it is better not to do this imo.
>
> I do not think this patch really obfuscates anything? The filtering is
> pretty clear to me.
And not having such filtering is more obvious and more clear.
It doesn't matter much for just this patch of course, but it will make
the code significantly harder to read (and deal with in other ways) if
this continues.
> If this is a real objection to the patch, I suppose we could just
> localize '-Qunused-arguments' to this Makefile and be done with it but I
> do not think this change is a bad solution to the problem either.
It is a comment about the direction this patch is moving us in. I don't
think it is a good idea at all to try to avoid all warnings, and even
more so it is a bad idea to make objectively worse source code just to
appease a trigger-happy and questionable warning.
As I said, you can often avoid warnings by writing better code, like
part of the patch did. That is a good reaction to warnings. Making
worse code to avoid warnings is not a good idea normally.
Just don't use -Werror by default, and don't make other people suffer
its yoke!
Segher
next prev parent reply other threads:[~2023-01-24 16:37 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 3:04 [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS Nathan Chancellor
2023-01-12 3:04 ` Nathan Chancellor
2023-01-12 3:04 ` Nathan Chancellor
2023-01-12 3:04 ` [PATCH v2 01/14] x86/boot/compressed: prefer cc-option for CFLAGS additions Nathan Chancellor
2023-01-12 3:04 ` [PATCH v2 02/14] MIPS: Always use -Wa,-msoft-float and eliminate GAS_HAS_SET_HARDFLOAT Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 03/14] MIPS: Prefer cc-option for additions to cflags Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 04/14] kbuild: Update assembler calls to use proper flags and language target Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS Nathan Chancellor
2023-01-12 3:05 ` Nathan Chancellor
2023-01-25 4:11 ` Michael Ellerman
2023-01-25 4:11 ` Michael Ellerman
2023-01-26 1:29 ` Masahiro Yamada
2023-01-26 1:29 ` Masahiro Yamada
2023-01-26 2:07 ` Nathan Chancellor
2023-01-26 2:07 ` Nathan Chancellor
2023-01-26 4:22 ` Masahiro Yamada
2023-01-26 4:22 ` Masahiro Yamada
2023-01-26 10:05 ` Michael Ellerman
2023-01-26 10:05 ` Michael Ellerman
2023-01-12 3:05 ` [PATCH v2 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS Nathan Chancellor
2023-01-12 3:05 ` Nathan Chancellor
2023-01-25 4:12 ` Michael Ellerman
2023-01-25 4:12 ` Michael Ellerman
2023-01-12 3:05 ` [PATCH v2 07/14] powerpc/vdso: Improve linker flags Nathan Chancellor
2023-01-12 3:05 ` Nathan Chancellor
2023-01-12 18:02 ` Sedat Dilek
2023-01-12 18:02 ` Sedat Dilek
2023-01-12 18:21 ` Nathan Chancellor
2023-01-12 18:21 ` Nathan Chancellor
2023-01-12 18:47 ` Sedat Dilek
2023-01-12 18:47 ` Sedat Dilek
2023-01-22 17:27 ` Masahiro Yamada
2023-01-22 17:27 ` Masahiro Yamada
2023-01-22 18:01 ` Nathan Chancellor
2023-01-22 18:01 ` Nathan Chancellor
2023-01-23 15:07 ` Segher Boessenkool
2023-01-23 15:07 ` Segher Boessenkool
2023-01-24 16:14 ` Nathan Chancellor
2023-01-24 16:14 ` Nathan Chancellor
2023-01-24 16:30 ` Segher Boessenkool [this message]
2023-01-24 16:30 ` Segher Boessenkool
2023-01-12 3:05 ` [PATCH v2 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang Nathan Chancellor
2023-01-12 3:05 ` Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 09/14] s390/vdso: Drop unused '-s' flag from KBUILD_AFLAGS_64 Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 10/14] s390/vdso: Drop '-shared' from KBUILD_CFLAGS_64 Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 11/14] s390/purgatory: Remove unused '-MD' and unnecessary '-c' flags Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang Nathan Chancellor
2023-01-12 3:05 ` Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 13/14] kbuild: Turn a couple more of clang's unused option warnings into errors Nathan Chancellor
2023-01-12 3:05 ` [PATCH v2 14/14] kbuild: Stop using '-Qunused-arguments' with clang Nathan Chancellor
2023-01-22 17:28 ` [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS Masahiro Yamada
2023-01-22 17:28 ` Masahiro Yamada
2023-01-22 17:28 ` Masahiro Yamada
2023-01-23 13:58 ` Naresh Kamboju
2023-01-23 13:58 ` Naresh Kamboju
2023-01-23 13:58 ` Naresh Kamboju
2023-01-23 16:11 ` Nathan Chancellor
2023-01-23 16:11 ` Nathan Chancellor
2023-01-23 16:11 ` Nathan Chancellor
2023-01-24 15:29 ` Naresh Kamboju
2023-01-24 15:29 ` Naresh Kamboju
2023-01-24 15:29 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124163048.GL25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=npiggin@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.