From: Sia Jee Heng <jeeheng.sia@starfivetech.com> To: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu> Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <jeeheng.sia@starfivetech.com>, <leyfoon.tan@starfivetech.com>, <mason.huo@starfivetech.com> Subject: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Date: Fri, 27 Jan 2023 17:10:50 +0800 [thread overview] Message-ID: <20230127091051.1465278-4-jeeheng.sia@starfivetech.com> (raw) In-Reply-To: <20230127091051.1465278-1-jeeheng.sia@starfivetech.com> Currently kernel_page_present() function doesn't support huge page detection causes the function to mistakenly return false to the hibernation core. Add huge page detection to the function to solve the problem. Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> Reviewed-by: Mason Huo <mason.huo@starfivetech.com> --- arch/riscv/mm/pageattr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c index 86c56616e5de..792b8d10cdfc 100644 --- a/arch/riscv/mm/pageattr.c +++ b/arch/riscv/mm/pageattr.c @@ -221,14 +221,20 @@ bool kernel_page_present(struct page *page) p4d = p4d_offset(pgd, addr); if (!p4d_present(*p4d)) return false; + if (p4d_leaf(*p4d)) + return true; pud = pud_offset(p4d, addr); if (!pud_present(*pud)) return false; + if (pud_leaf(*pud)) + return true; pmd = pmd_offset(pud, addr); if (!pmd_present(*pmd)) return false; + if (pmd_leaf(*pmd)) + return true; pte = pte_offset_kernel(pmd, addr); return pte_present(*pte); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Sia Jee Heng <jeeheng.sia@starfivetech.com> To: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu> Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <jeeheng.sia@starfivetech.com>, <leyfoon.tan@starfivetech.com>, <mason.huo@starfivetech.com> Subject: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Date: Fri, 27 Jan 2023 17:10:50 +0800 [thread overview] Message-ID: <20230127091051.1465278-4-jeeheng.sia@starfivetech.com> (raw) In-Reply-To: <20230127091051.1465278-1-jeeheng.sia@starfivetech.com> Currently kernel_page_present() function doesn't support huge page detection causes the function to mistakenly return false to the hibernation core. Add huge page detection to the function to solve the problem. Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> Reviewed-by: Mason Huo <mason.huo@starfivetech.com> --- arch/riscv/mm/pageattr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c index 86c56616e5de..792b8d10cdfc 100644 --- a/arch/riscv/mm/pageattr.c +++ b/arch/riscv/mm/pageattr.c @@ -221,14 +221,20 @@ bool kernel_page_present(struct page *page) p4d = p4d_offset(pgd, addr); if (!p4d_present(*p4d)) return false; + if (p4d_leaf(*p4d)) + return true; pud = pud_offset(p4d, addr); if (!pud_present(*pud)) return false; + if (pud_leaf(*pud)) + return true; pmd = pmd_offset(pud, addr); if (!pmd_present(*pmd)) return false; + if (pmd_leaf(*pmd)) + return true; pte = pte_offset_kernel(pmd, addr); return pte_present(*pte); -- 2.34.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-27 9:11 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-27 9:10 [PATCH v3 0/4] RISC-V Hibernation Support Sia Jee Heng 2023-01-27 9:10 ` Sia Jee Heng 2023-01-27 9:10 ` [PATCH v3 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function Sia Jee Heng 2023-01-27 9:10 ` Sia Jee Heng 2023-01-30 23:31 ` Conor Dooley 2023-01-30 23:31 ` Conor Dooley 2023-01-27 9:10 ` [PATCH v3 2/4] RISC-V: Factor out common code of __cpu_resume_enter() Sia Jee Heng 2023-01-27 9:10 ` Sia Jee Heng 2023-01-30 21:49 ` Conor Dooley 2023-01-30 21:49 ` Conor Dooley 2023-02-01 6:19 ` JeeHeng Sia 2023-02-01 6:19 ` JeeHeng Sia 2023-01-27 9:10 ` Sia Jee Heng [this message] 2023-01-27 9:10 ` [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Sia Jee Heng 2023-01-30 21:57 ` Conor Dooley 2023-01-30 21:57 ` Conor Dooley 2023-01-31 8:19 ` Alexandre Ghiti 2023-01-31 8:19 ` Alexandre Ghiti 2023-02-01 5:48 ` JeeHeng Sia 2023-02-01 5:48 ` JeeHeng Sia 2023-01-27 9:10 ` [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk Sia Jee Heng 2023-01-27 9:10 ` Sia Jee Heng 2023-01-30 23:30 ` Conor Dooley 2023-01-30 23:30 ` Conor Dooley 2023-01-31 9:59 ` Alexandre Ghiti 2023-01-31 9:59 ` Alexandre Ghiti 2023-02-07 4:58 ` JeeHeng Sia 2023-02-07 4:58 ` JeeHeng Sia 2023-02-07 5:27 ` Alexandre Ghiti 2023-02-07 5:27 ` Alexandre Ghiti 2023-02-02 2:43 ` JeeHeng Sia 2023-02-02 2:43 ` JeeHeng Sia 2023-02-03 3:43 ` JeeHeng Sia 2023-02-03 3:43 ` JeeHeng Sia 2023-02-03 6:30 ` Conor Dooley 2023-02-03 6:30 ` Conor Dooley 2023-02-04 20:42 ` kernel test robot 2023-02-04 20:42 ` kernel test robot 2023-02-07 15:46 ` Alexandre Ghiti 2023-02-07 15:46 ` Alexandre Ghiti 2023-02-08 4:43 ` JeeHeng Sia 2023-02-08 4:43 ` JeeHeng Sia 2023-02-08 12:04 ` Alexandre Ghiti 2023-02-08 12:04 ` Alexandre Ghiti 2023-02-09 6:12 ` JeeHeng Sia 2023-02-09 6:12 ` JeeHeng Sia 2023-02-10 13:24 ` Alexandre Ghiti 2023-02-10 13:24 ` Alexandre Ghiti 2023-02-13 1:51 ` JeeHeng Sia 2023-02-13 1:51 ` JeeHeng Sia 2023-02-14 6:57 ` Alexandre Ghiti 2023-02-14 6:57 ` Alexandre Ghiti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230127091051.1465278-4-jeeheng.sia@starfivetech.com \ --to=jeeheng.sia@starfivetech.com \ --cc=aou@eecs.berkeley.edu \ --cc=leyfoon.tan@starfivetech.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mason.huo@starfivetech.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.