From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH i-g-t 4/6] intel_gpu_top: Aggregate engine classes in all output modes Date: Fri, 27 Jan 2023 11:12:39 +0000 [thread overview] Message-ID: <20230127111241.3624629-5-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20230127111241.3624629-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Use the same default for stdout and JSON output modes as it is for interactive. Previously added command line switch can be used to go back to showing all physical engines. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tools/intel_gpu_top.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index e91b47baf72b..7aa233570463 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -2509,11 +2509,12 @@ int main(int argc, char **argv) if (signal(SIGINT, sigint_handler) == SIG_ERR) fprintf(stderr, "Failed to install signal handler!\n"); + class_view = !physical_engines; + switch (output_mode) { case INTERACTIVE: pops = &term_pops; interactive_stdin(); - class_view = !physical_engines; break; case STDOUT: pops = &stdout_pops; -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [igt-dev] [PATCH i-g-t 4/6] intel_gpu_top: Aggregate engine classes in all output modes Date: Fri, 27 Jan 2023 11:12:39 +0000 [thread overview] Message-ID: <20230127111241.3624629-5-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20230127111241.3624629-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Use the same default for stdout and JSON output modes as it is for interactive. Previously added command line switch can be used to go back to showing all physical engines. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tools/intel_gpu_top.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index e91b47baf72b..7aa233570463 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -2509,11 +2509,12 @@ int main(int argc, char **argv) if (signal(SIGINT, sigint_handler) == SIG_ERR) fprintf(stderr, "Failed to install signal handler!\n"); + class_view = !physical_engines; + switch (output_mode) { case INTERACTIVE: pops = &term_pops; interactive_stdin(); - class_view = !physical_engines; break; case STDOUT: pops = &stdout_pops; -- 2.34.1
next prev parent reply other threads:[~2023-01-27 11:13 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-27 11:12 [Intel-gfx] [PATCH i-g-t 0/6] Assorted intel_gpu_top improvements Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 11:12 ` [Intel-gfx] [PATCH i-g-t 1/6] intel_gpu_top: Fix man page formatting Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 17:18 ` [Intel-gfx] " Kamil Konieczny 2023-01-27 17:18 ` [igt-dev] " Kamil Konieczny 2023-01-27 11:12 ` [Intel-gfx] [PATCH i-g-t 2/6] intel_gpu_top: Automatically enclose JSON output into brackets Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 11:12 ` [Intel-gfx] [PATCH i-g-t 3/6] intel_gpu_top: Add command line switch to start in physical engine mode Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 11:12 ` Tvrtko Ursulin [this message] 2023-01-27 11:12 ` [igt-dev] [PATCH i-g-t 4/6] intel_gpu_top: Aggregate engine classes in all output modes Tvrtko Ursulin 2023-01-27 11:12 ` [Intel-gfx] [PATCH i-g-t 5/6] intel_gpu_top: Fix cleanup on old kernels / unsupported GPU Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 16:10 ` [Intel-gfx] " Kamil Konieczny 2023-01-27 16:10 ` [igt-dev] " Kamil Konieczny 2023-01-30 10:55 ` [Intel-gfx] [igt-dev] " Tvrtko Ursulin 2023-01-30 10:55 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin 2023-01-30 10:58 ` [Intel-gfx] [igt-dev] " Das, Nirmoy 2023-01-30 10:58 ` [igt-dev] [Intel-gfx] " Das, Nirmoy 2023-01-30 16:54 ` [Intel-gfx] [igt-dev] " Kamil Konieczny 2023-01-30 16:54 ` [igt-dev] [Intel-gfx] " Kamil Konieczny 2023-01-27 11:12 ` [Intel-gfx] [PATCH i-g-t 6/6] lib/igt_device_scan: Improve Intel discrete GPU selection Tvrtko Ursulin 2023-01-27 11:12 ` [igt-dev] " Tvrtko Ursulin 2023-01-27 11:39 ` [Intel-gfx] " Petri Latvala 2023-01-27 11:39 ` Petri Latvala 2023-01-27 11:53 ` [Intel-gfx] " Tvrtko Ursulin 2023-01-27 11:53 ` Tvrtko Ursulin 2023-01-27 13:41 ` [Intel-gfx] " Petri Latvala 2023-01-27 13:41 ` Petri Latvala 2023-01-27 16:17 ` [Intel-gfx] " Kamil Konieczny 2023-01-27 16:17 ` [igt-dev] " Kamil Konieczny 2023-01-30 11:04 ` [Intel-gfx] " Tvrtko Ursulin 2023-01-30 11:04 ` Tvrtko Ursulin 2023-01-30 16:51 ` [Intel-gfx] " Kamil Konieczny 2023-01-30 16:51 ` Kamil Konieczny 2023-01-30 6:30 ` [Intel-gfx] " Zbigniew Kempczyński 2023-01-30 6:30 ` [igt-dev] " Zbigniew Kempczyński 2023-01-27 12:16 ` [igt-dev] ✓ Fi.CI.BAT: success for Assorted intel_gpu_top improvements Patchwork 2023-01-27 14:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2023-01-30 12:28 ` Kamil Konieczny 2023-01-30 15:02 ` Yedireswarapu, SaiX Nandan 2023-01-30 13:51 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230127111241.3624629-5-tvrtko.ursulin@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=igt-dev@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.