From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org
Subject: switch blk-cgroup to work on gendisk v4
Date: Fri, 3 Feb 2023 16:03:41 +0100 [thread overview]
Message-ID: <20230203150400.3199230-1-hch@lst.de> (raw)
Hi all,
blk-cgroup works on only on live disks and "file system" I/O from bios.
This all the information should be in the gendisk, and not the
request_queue that also exists for pure passthrough request based
devices.
Changes since v3:
- improve a commit log
- drop a change to not acquire a pointless disk reference
Changes since v2:
- drop the patch to revert the async blkg freeing
- simplify error unwinding when failing to allocate a blkg
- add back the dead queue/disk check in blkg_alloc
- split two patches to better document the changes
- add another blk-wbt cleanup patch
- rewrite a commit log
- another typo fix
Changes since v1:
- use the local disk variable in wbt_init instead of q->disk
- various spelling fixes
Diffstat:
block/bfq-cgroup.c | 18 +--
block/bfq-iosched.c | 6 -
block/blk-cgroup-rwstat.c | 2
block/blk-cgroup.c | 226 +++++++++++++++++++++-------------------------
block/blk-cgroup.h | 38 +++----
block/blk-iocost.c | 40 +++-----
block/blk-iolatency.c | 41 +++-----
block/blk-ioprio.c | 6 -
block/blk-mq-debugfs.c | 10 --
block/blk-rq-qos.c | 67 +++++++++++++
block/blk-rq-qos.h | 66 +------------
block/blk-settings.c | 1
block/blk-stat.c | 3
block/blk-sysfs.c | 5 -
block/blk-throttle.c | 31 +++---
block/blk-wbt.c | 116 +++++++++++++++++++----
block/blk-wbt.h | 98 +------------------
block/genhd.c | 17 +--
include/linux/blkdev.h | 12 +-
include/linux/sched.h | 2
kernel/fork.c | 2
mm/swapfile.c | 2
22 files changed, 391 insertions(+), 418 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>
Cc: linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: switch blk-cgroup to work on gendisk v4
Date: Fri, 3 Feb 2023 16:03:41 +0100 [thread overview]
Message-ID: <20230203150400.3199230-1-hch@lst.de> (raw)
Hi all,
blk-cgroup works on only on live disks and "file system" I/O from bios.
This all the information should be in the gendisk, and not the
request_queue that also exists for pure passthrough request based
devices.
Changes since v3:
- improve a commit log
- drop a change to not acquire a pointless disk reference
Changes since v2:
- drop the patch to revert the async blkg freeing
- simplify error unwinding when failing to allocate a blkg
- add back the dead queue/disk check in blkg_alloc
- split two patches to better document the changes
- add another blk-wbt cleanup patch
- rewrite a commit log
- another typo fix
Changes since v1:
- use the local disk variable in wbt_init instead of q->disk
- various spelling fixes
Diffstat:
block/bfq-cgroup.c | 18 +--
block/bfq-iosched.c | 6 -
block/blk-cgroup-rwstat.c | 2
block/blk-cgroup.c | 226 +++++++++++++++++++++-------------------------
block/blk-cgroup.h | 38 +++----
block/blk-iocost.c | 40 +++-----
block/blk-iolatency.c | 41 +++-----
block/blk-ioprio.c | 6 -
block/blk-mq-debugfs.c | 10 --
block/blk-rq-qos.c | 67 +++++++++++++
block/blk-rq-qos.h | 66 +------------
block/blk-settings.c | 1
block/blk-stat.c | 3
block/blk-sysfs.c | 5 -
block/blk-throttle.c | 31 +++---
block/blk-wbt.c | 116 +++++++++++++++++++----
block/blk-wbt.h | 98 +------------------
block/genhd.c | 17 +--
include/linux/blkdev.h | 12 +-
include/linux/sched.h | 2
kernel/fork.c | 2
mm/swapfile.c | 2
22 files changed, 391 insertions(+), 418 deletions(-)
next reply other threads:[~2023-02-03 15:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 15:03 Christoph Hellwig [this message]
2023-02-03 15:03 ` switch blk-cgroup to work on gendisk v4 Christoph Hellwig
2023-02-03 15:03 ` [PATCH 01/19] block: don't call blk_throtl_stat_add for non-READ/WRITE commands Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 02/19] blk-cgroup: delay blk-cgroup initialization until add_disk Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 03/19] blk-cgroup: improve error unwinding in blkg_alloc Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 04/19] blk-cgroup: simplify blkg freeing from initialization failure paths Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 05/19] blk-cgroup: remove the !bdi->dev check in blkg_dev_name Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 06/19] blk-cgroup: pin the gendisk in struct blkcg_gq Christoph Hellwig
2023-02-03 15:03 ` [PATCH 07/19] blk-cgroup: store a gendisk to throttle in struct task_struct Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 08/19] blk-wbt: pass a gendisk to wbt_{enable,disable}_default Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 09/19] blk-wbt: pass a gendisk to wbt_init Christoph Hellwig
2023-02-03 15:03 ` [PATCH 10/19] blk-wbt: move private information from blk-wbt.h to blk-wbt.c Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 11/19] blk-wbt: open code wbt_queue_depth_changed in wbt_init Christoph Hellwig
2023-02-03 15:03 ` [PATCH 12/19] blk-rq-qos: move rq_qos_add and rq_qos_del out of line Christoph Hellwig
2023-02-03 15:03 ` [PATCH 13/19] blk-rq-qos: make rq_qos_add and rq_qos_del more useful Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 14/19] blk-rq-qos: constify rq_qos_ops Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 15/19] blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 16/19] blk-cgroup: pass a gendisk to blkcg_{de,}activate_policy Christoph Hellwig
2023-02-03 15:03 ` [PATCH 17/19] blk-cgroup: pass a gendisk to pd_alloc_fn Christoph Hellwig
2023-02-03 15:03 ` Christoph Hellwig
2023-02-03 15:03 ` [PATCH 18/19] blk-cgroup: pass a gendisk to blkg_lookup Christoph Hellwig
2023-02-03 15:04 ` [PATCH 19/19] blk-cgroup: move the cgroup information to struct gendisk Christoph Hellwig
2023-02-03 15:04 ` Christoph Hellwig
2023-02-03 17:18 ` switch blk-cgroup to work on gendisk v4 Jens Axboe
2023-02-03 17:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203150400.3199230-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.