All of lore.kernel.org
 help / color / mirror / Atom feed
From: Longlong Xia <xialonglong1@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <chenwandun@huawei.com>, <linux-kernel@vger.kernel.org>,
	<rafael@kernel.org>, <sunnanyong@huawei.com>,
	<wangkefeng.wang@huawei.com>, <xialonglong1@huawei.com>
Subject: [PATCH -next v2 0/3] cleanup of devtmpfs_*_node()
Date: Fri, 10 Feb 2023 09:54:41 +0000	[thread overview]
Message-ID: <20230210095444.4067307-1-xialonglong1@huawei.com> (raw)

In one test, when modprobe zram, no zram device was found in the /dev. 
But don't see any errors printed in jouranls/dmesg. Later we found out 
that the reason was that device_add() did not check its return value when
calling devtmpfs_create_node().

The test steps:
1. Set the SElinux label of /dev to user_home_t 
2. modprobe zram num_devices=1000

v1 -> v2:
- New patch 1 to add error handling for devtmpfs_create_node().
- use dev_err() to replace pr_err_ratelimited in [2].
- only remove return value of devtmpfs_delete_node() in [3].

Longlong Xia (3):
  driver core: add error handling for devtmpfs_create_node()
  devtmpfs: add debug info to handle()
  devtmpfs: remove return value of devtmpfs_delete_node()

 drivers/base/base.h     |  4 ++--
 drivers/base/core.c     |  6 +++++-
 drivers/base/devtmpfs.c | 20 ++++++++++++++------
 3 files changed, 21 insertions(+), 9 deletions(-)

-- 
2.25.1


             reply	other threads:[~2023-02-10  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  9:54 Longlong Xia [this message]
2023-02-10  9:54 ` [PATCH -next v2 1/3] driver core: add error handling for devtmpfs_create_node() Longlong Xia
2023-02-14  0:14   ` Nathan Chancellor
2023-02-14  0:33     ` Nathan Chancellor
2023-02-14  7:59       ` Greg KH
2023-02-10  9:54 ` [PATCH -next v2 2/3] devtmpfs: add debug info to handle() Longlong Xia
2023-02-10  9:54 ` [PATCH -next v2 3/3] devtmpfs: remove return value of devtmpfs_delete_node() Longlong Xia
2023-02-10 10:27 ` [PATCH -next v2 0/3] cleanup of devtmpfs_*_node() Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210095444.4067307-1-xialonglong1@huawei.com \
    --to=xialonglong1@huawei.com \
    --cc=chenwandun@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sunnanyong@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.