From: Sascha Hauer <s.hauer@pengutronix.de> To: dri-devel@lists.freedesktop.org Cc: Sandy Huang <hjc@rock-chips.com>, linux-rockchip@lists.infradead.org, Michael Riesch <michael.riesch@wolfvision.net>, kernel@pengutronix.de, Robin Murphy <robin.murphy@arm.com>, Dan Johansen <strit@manjaro.org>, FUKAUMI Naoki <naoki@radxa.com>, Sascha Hauer <s.hauer@pengutronix.de>, Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Subject: [PATCH v6 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks Date: Thu, 16 Feb 2023 11:24:47 +0100 [thread overview] Message-ID: <20230216102447.582905-5-s.hauer@pengutronix.de> (raw) In-Reply-To: <20230216102447.582905-1-s.hauer@pengutronix.de> The Rockchip PLL drivers are currently table based and support only the most common pixelclocks. Discard all modes we cannot achieve at all. Normally the desired pixelclocks have an exact match in the PLL driver, nevertheless allow for a 0.1% error just in case. Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> Tested-by: Dan Johansen <strit@manjaro.org> Link: https://lore.kernel.org/r/20230118132213.2911418-4-s.hauer@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v3: - only check for rate when clk != NULL Changes since v2: - new patch drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index feba6b9becd6c..293dcf0f05931 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -260,6 +260,13 @@ dw_hdmi_rockchip_mode_valid(struct dw_hdmi *dw_hdmi, void *data, bool exact_match = hdmi->plat_data->phy_force_vendor; int i; + if (hdmi->ref_clk) { + int rpclk = clk_round_rate(hdmi->ref_clk, pclk); + + if (abs(rpclk - pclk) > pclk / 1000) + return MODE_NOCLOCK; + } + for (i = 0; mpll_cfg[i].mpixelclock != (~0UL); i++) { /* * For vendor specific phys force an exact match of the pixelclock -- 2.30.2 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de> To: dri-devel@lists.freedesktop.org Cc: Dan Johansen <strit@manjaro.org>, Sascha Hauer <s.hauer@pengutronix.de>, Sandy Huang <hjc@rock-chips.com>, Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, linux-rockchip@lists.infradead.org, FUKAUMI Naoki <naoki@radxa.com>, Michael Riesch <michael.riesch@wolfvision.net>, kernel@pengutronix.de, Robin Murphy <robin.murphy@arm.com> Subject: [PATCH v6 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks Date: Thu, 16 Feb 2023 11:24:47 +0100 [thread overview] Message-ID: <20230216102447.582905-5-s.hauer@pengutronix.de> (raw) In-Reply-To: <20230216102447.582905-1-s.hauer@pengutronix.de> The Rockchip PLL drivers are currently table based and support only the most common pixelclocks. Discard all modes we cannot achieve at all. Normally the desired pixelclocks have an exact match in the PLL driver, nevertheless allow for a 0.1% error just in case. Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> Tested-by: Dan Johansen <strit@manjaro.org> Link: https://lore.kernel.org/r/20230118132213.2911418-4-s.hauer@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v3: - only check for rate when clk != NULL Changes since v2: - new patch drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index feba6b9becd6c..293dcf0f05931 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -260,6 +260,13 @@ dw_hdmi_rockchip_mode_valid(struct dw_hdmi *dw_hdmi, void *data, bool exact_match = hdmi->plat_data->phy_force_vendor; int i; + if (hdmi->ref_clk) { + int rpclk = clk_round_rate(hdmi->ref_clk, pclk); + + if (abs(rpclk - pclk) > pclk / 1000) + return MODE_NOCLOCK; + } + for (i = 0; mpll_cfg[i].mpixelclock != (~0UL); i++) { /* * For vendor specific phys force an exact match of the pixelclock -- 2.30.2
next prev parent reply other threads:[~2023-02-16 10:25 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-16 10:24 [PATCH v6 0/4] drm/rockchip: dw_hdmi: Add 4k@30 support Sascha Hauer 2023-02-16 10:24 ` Sascha Hauer 2023-02-16 10:24 ` [PATCH v6 1/4] drm/rockchip: vop: limit maximium resolution to hardware capabilities Sascha Hauer 2023-02-16 10:24 ` Sascha Hauer 2023-03-07 22:21 ` Heiko Stübner 2023-03-07 22:21 ` Heiko Stübner 2023-03-08 10:06 ` Sascha Hauer 2023-03-08 10:06 ` Sascha Hauer 2023-02-16 10:24 ` [PATCH v6 2/4] drm/rockchip: dw_hdmi: relax mode_valid hook Sascha Hauer 2023-02-16 10:24 ` Sascha Hauer 2023-02-16 10:24 ` [PATCH v6 3/4] drm/rockchip: dw_hdmi: Add support for 4k@30 resolution Sascha Hauer 2023-02-16 10:24 ` Sascha Hauer 2023-02-16 10:24 ` Sascha Hauer [this message] 2023-02-16 10:24 ` [PATCH v6 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks Sascha Hauer 2023-03-06 13:31 ` [PATCH v6 0/4] drm/rockchip: dw_hdmi: Add 4k@30 support Sascha Hauer 2023-03-06 13:31 ` Sascha Hauer 2023-03-09 1:07 ` Heiko Stuebner 2023-03-09 1:07 ` Heiko Stuebner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230216102447.582905-5-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=frattaroli.nicolas@gmail.com \ --cc=hjc@rock-chips.com \ --cc=kernel@pengutronix.de \ --cc=linux-rockchip@lists.infradead.org \ --cc=michael.riesch@wolfvision.net \ --cc=naoki@radxa.com \ --cc=robin.murphy@arm.com \ --cc=strit@manjaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.