From: Jakub Kicinski <kuba@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: davem@davemloft.net, ralf@linux-mips.org, edumazet@google.com,
pabeni@redhat.com, linux-hams@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] net: rose: Remove NULL check before dev_{put, hold}
Date: Mon, 27 Feb 2023 18:33:49 -0800 [thread overview]
Message-ID: <20230227183349.68409721@kernel.org> (raw)
In-Reply-To: <20230228005217.105058-1-yang.lee@linux.alibaba.com>
On Tue, 28 Feb 2023 08:52:17 +0800 Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning：
>
> ./net/rose/rose_route.c:619:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
# Form letter - net-next is closed
The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after Mar 6th.
RFC patches sent for review only are obviously welcome at any time.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: davem@davemloft.net, ralf@linux-mips.org, edumazet@google.com,
pabeni@redhat.com, linux-hams@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] net: rose: Remove NULL check before dev_{put, hold}
Date: Mon, 27 Feb 2023 18:33:49 -0800 [thread overview]
Message-ID: <20230227183349.68409721@kernel.org> (raw)
In-Reply-To: <20230228005217.105058-1-yang.lee@linux.alibaba.com>
On Tue, 28 Feb 2023 08:52:17 +0800 Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning：
>
> ./net/rose/rose_route.c:619:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
# Form letter - net-next is closed
The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after Mar 6th.
RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2023-02-28 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 0:52 [PATCH net-next] net: rose: Remove NULL check before dev_{put, hold} Yang Li
2023-02-28 0:52 ` Yang Li
2023-02-28 2:33 ` Jakub Kicinski [this message]
2023-02-28 2:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227183349.68409721@kernel.org \
--to=kuba@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.