From: Cheng-Jui Wang <cheng-jui.wang@mediatek.com> To: <stable@vger.kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, "Matthias Brugger" <matthias.bgg@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Suren Baghdasaryan <surenb@google.com>, Cheng-Jui Wang <cheng-jui.wang@mediatek.com>, <linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org> Subject: [PATCH 03/10] cpuidle, tegra: Push RCU-idle into driver Date: Fri, 3 Mar 2023 17:23:25 +0800 [thread overview] Message-ID: <20230303092347.4825-4-cheng-jui.wang@mediatek.com> (raw) In-Reply-To: <20230303092347.4825-1-cheng-jui.wang@mediatek.com> From: Peter Zijlstra <peterz@infradead.org> commit 5fca0d9f5d76664786ca6c09076341def165a677 upstream. Doing RCU-idle outside the driver, only to then temporarily enable it again, at least twice, before going idle is suboptimal. Notably once implicitly through the cpu_pm_*() calls and once explicitly doing RCU_NONIDLE(). Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Tested-by: Tony Lindgren <tony@atomide.com> Tested-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://lore.kernel.org/r/20230112195539.699546331@infradead.org Signed-off-by: Suren Baghdasaryan <surenb@google.com> Signed-off-by: Cheng-Jui Wang <cheng-jui.wang@mediatek.com> --- drivers/cpuidle/cpuidle-tegra.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c index 9845629aeb6d..3ca5cfb9d322 100644 --- a/drivers/cpuidle/cpuidle-tegra.c +++ b/drivers/cpuidle/cpuidle-tegra.c @@ -180,9 +180,11 @@ static int tegra_cpuidle_state_enter(struct cpuidle_device *dev, } local_fiq_disable(); - RCU_NONIDLE(tegra_pm_set_cpu_in_lp2()); + tegra_pm_set_cpu_in_lp2(); cpu_pm_enter(); + ct_idle_enter(); + switch (index) { case TEGRA_C7: err = tegra_cpuidle_c7_enter(); @@ -197,8 +199,10 @@ static int tegra_cpuidle_state_enter(struct cpuidle_device *dev, break; } + ct_idle_exit(); + cpu_pm_exit(); - RCU_NONIDLE(tegra_pm_clear_cpu_in_lp2()); + tegra_pm_clear_cpu_in_lp2(); local_fiq_enable(); return err ?: index; @@ -226,6 +230,7 @@ static int tegra_cpuidle_enter(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { + bool do_rcu = drv->states[index].flags & CPUIDLE_FLAG_RCU_IDLE; unsigned int cpu = cpu_logical_map(dev->cpu); int ret; @@ -233,9 +238,13 @@ static int tegra_cpuidle_enter(struct cpuidle_device *dev, if (dev->states_usage[index].disable) return -1; - if (index == TEGRA_C1) + if (index == TEGRA_C1) { + if (do_rcu) + ct_idle_enter(); ret = arm_cpuidle_simple_enter(dev, drv, index); - else + if (do_rcu) + ct_idle_exit(); + } else ret = tegra_cpuidle_state_enter(dev, index, cpu); if (ret < 0) { @@ -285,7 +294,8 @@ static struct cpuidle_driver tegra_idle_driver = { .exit_latency = 2000, .target_residency = 2200, .power_usage = 100, - .flags = CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE, .name = "C7", .desc = "CPU core powered off", }, @@ -295,6 +305,7 @@ static struct cpuidle_driver tegra_idle_driver = { .target_residency = 10000, .power_usage = 0, .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE | CPUIDLE_FLAG_COUPLED, .name = "CC6", .desc = "CPU cluster powered off", -- 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Cheng-Jui Wang <cheng-jui.wang@mediatek.com> To: <stable@vger.kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, "Matthias Brugger" <matthias.bgg@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Suren Baghdasaryan <surenb@google.com>, Cheng-Jui Wang <cheng-jui.wang@mediatek.com>, <linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org> Subject: [PATCH 03/10] cpuidle, tegra: Push RCU-idle into driver Date: Fri, 3 Mar 2023 17:23:25 +0800 [thread overview] Message-ID: <20230303092347.4825-4-cheng-jui.wang@mediatek.com> (raw) In-Reply-To: <20230303092347.4825-1-cheng-jui.wang@mediatek.com> From: Peter Zijlstra <peterz@infradead.org> commit 5fca0d9f5d76664786ca6c09076341def165a677 upstream. Doing RCU-idle outside the driver, only to then temporarily enable it again, at least twice, before going idle is suboptimal. Notably once implicitly through the cpu_pm_*() calls and once explicitly doing RCU_NONIDLE(). Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Tested-by: Tony Lindgren <tony@atomide.com> Tested-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://lore.kernel.org/r/20230112195539.699546331@infradead.org Signed-off-by: Suren Baghdasaryan <surenb@google.com> Signed-off-by: Cheng-Jui Wang <cheng-jui.wang@mediatek.com> --- drivers/cpuidle/cpuidle-tegra.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c index 9845629aeb6d..3ca5cfb9d322 100644 --- a/drivers/cpuidle/cpuidle-tegra.c +++ b/drivers/cpuidle/cpuidle-tegra.c @@ -180,9 +180,11 @@ static int tegra_cpuidle_state_enter(struct cpuidle_device *dev, } local_fiq_disable(); - RCU_NONIDLE(tegra_pm_set_cpu_in_lp2()); + tegra_pm_set_cpu_in_lp2(); cpu_pm_enter(); + ct_idle_enter(); + switch (index) { case TEGRA_C7: err = tegra_cpuidle_c7_enter(); @@ -197,8 +199,10 @@ static int tegra_cpuidle_state_enter(struct cpuidle_device *dev, break; } + ct_idle_exit(); + cpu_pm_exit(); - RCU_NONIDLE(tegra_pm_clear_cpu_in_lp2()); + tegra_pm_clear_cpu_in_lp2(); local_fiq_enable(); return err ?: index; @@ -226,6 +230,7 @@ static int tegra_cpuidle_enter(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { + bool do_rcu = drv->states[index].flags & CPUIDLE_FLAG_RCU_IDLE; unsigned int cpu = cpu_logical_map(dev->cpu); int ret; @@ -233,9 +238,13 @@ static int tegra_cpuidle_enter(struct cpuidle_device *dev, if (dev->states_usage[index].disable) return -1; - if (index == TEGRA_C1) + if (index == TEGRA_C1) { + if (do_rcu) + ct_idle_enter(); ret = arm_cpuidle_simple_enter(dev, drv, index); - else + if (do_rcu) + ct_idle_exit(); + } else ret = tegra_cpuidle_state_enter(dev, index, cpu); if (ret < 0) { @@ -285,7 +294,8 @@ static struct cpuidle_driver tegra_idle_driver = { .exit_latency = 2000, .target_residency = 2200, .power_usage = 100, - .flags = CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE, .name = "C7", .desc = "CPU core powered off", }, @@ -295,6 +305,7 @@ static struct cpuidle_driver tegra_idle_driver = { .target_residency = 10000, .power_usage = 0, .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE | CPUIDLE_FLAG_COUPLED, .name = "CC6", .desc = "CPU cluster powered off", -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-03 9:26 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 9:23 [PATCH 00/10] Backport patches to fix lockdep splat in 6.1 Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 01/10] cpuidle/poll: Ensure IRQs stay disabled after cpuidle_state::enter() calls Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 02/10] cpuidle, riscv: Push RCU-idle into driver Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-07 0:48 ` patchwork-bot+linux-riscv 2023-03-07 0:48 ` patchwork-bot+linux-riscv 2023-03-07 0:48 ` patchwork-bot+linux-riscv 2023-03-03 9:23 ` Cheng-Jui Wang [this message] 2023-03-03 9:23 ` [PATCH 03/10] cpuidle, tegra: " Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 04/10] cpuidle, psci: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-10 8:47 ` Geert Uytterhoeven 2023-03-10 8:47 ` Geert Uytterhoeven 2023-03-03 9:23 ` [PATCH 05/10] cpuidle, ARM/imx6: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 06/10] cpuidle, OMAP3: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 07/10] cpuidle, armada: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 08/10] cpuidle, OMAP4: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 09/10] cpuidle, dt: " Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` [PATCH 10/10] cpuidle: Fix ct_idle_*() usage Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-03 9:23 ` Cheng-Jui Wang 2023-03-10 10:12 ` [PATCH 00/10] Backport patches to fix lockdep splat in 6.1 Greg KH 2023-03-10 10:13 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230303092347.4825-4-cheng-jui.wang@mediatek.com \ --to=cheng-jui.wang@mediatek.com \ --cc=daniel.lezcano@linaro.org \ --cc=jonathanh@nvidia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=rafael@kernel.org \ --cc=stable@vger.kernel.org \ --cc=surenb@google.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.