From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
linux-arm-msm@vger.kernel.org,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Jani Nikula" <jani.nikula@intel.com>,
"Michel Dänzer" <michel@daenzer.net>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
mikita.lipski@amd.com, "Sean Paul" <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
"Manasi Navare" <manasi.d.navare@intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org, "Kazlauskas,
Nicholas" <nicholas.kazlauskas@amd.com>
Subject: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks
Date: Tue, 7 Mar 2023 15:56:13 +0100 [thread overview]
Message-ID: <20230307145613.xvhru3fpcudlpazt@houat> (raw)
In-Reply-To: <20230216111214.3489223-1-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Hi,
On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote:
> The stuff never really worked, and leads to lots of fun because it
> out-of-order frees atomic states. Which upsets KASAN, among other
> things.
>
> For async updates we now have a more solid solution with the
> ->atomic_async_check and ->atomic_async_commit hooks. Support for that
> for msm and vc4 landed. nouveau and i915 have their own commit
> routines, doing something similar.
>
> For everyone else it's probably better to remove the use-after-free
> bug, and encourage folks to use the async support instead. The
> affected drivers which register a legacy cursor plane and don't either
> use the new async stuff or their own commit routine are: amdgpu,
> atmel, mediatek, qxl, rockchip, sti, sun4i, tegra, virtio, and vmwgfx.
>
> Inspired by an amdgpu bug report.
Thanks for submitting that patch. It's been in the downstream RPi tree
for a while, so I'd really like it to be merged eventually :)
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
linux-arm-msm@vger.kernel.org, harry.wentland@amd.com,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Jani Nikula" <jani.nikula@intel.com>,
"Michel Dänzer" <michel@daenzer.net>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
mikita.lipski@amd.com, linux-arm-kernel@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org, "Kazlauskas,
Nicholas" <nicholas.kazlauskas@amd.com>
Subject: Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks
Date: Tue, 7 Mar 2023 15:56:13 +0100 [thread overview]
Message-ID: <20230307145613.xvhru3fpcudlpazt@houat> (raw)
In-Reply-To: <20230216111214.3489223-1-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Hi,
On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote:
> The stuff never really worked, and leads to lots of fun because it
> out-of-order frees atomic states. Which upsets KASAN, among other
> things.
>
> For async updates we now have a more solid solution with the
> ->atomic_async_check and ->atomic_async_commit hooks. Support for that
> for msm and vc4 landed. nouveau and i915 have their own commit
> routines, doing something similar.
>
> For everyone else it's probably better to remove the use-after-free
> bug, and encourage folks to use the async support instead. The
> affected drivers which register a legacy cursor plane and don't either
> use the new async stuff or their own commit routine are: amdgpu,
> atmel, mediatek, qxl, rockchip, sti, sun4i, tegra, virtio, and vmwgfx.
>
> Inspired by an amdgpu bug report.
Thanks for submitting that patch. It's been in the downstream RPi tree
for a while, so I'd really like it to be merged eventually :)
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
mikita.lipski@amd.com, "Michel Dänzer" <michel@daenzer.net>,
harry.wentland@amd.com, "Rob Clark" <robdclark@gmail.com>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Sean Paul" <sean@poorly.run>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Imre Deak" <imre.deak@intel.com>,
"Manasi Navare" <manasi.d.navare@intel.com>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Daniel Vetter" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks
Date: Tue, 7 Mar 2023 15:56:13 +0100 [thread overview]
Message-ID: <20230307145613.xvhru3fpcudlpazt@houat> (raw)
In-Reply-To: <20230216111214.3489223-1-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Hi,
On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote:
> The stuff never really worked, and leads to lots of fun because it
> out-of-order frees atomic states. Which upsets KASAN, among other
> things.
>
> For async updates we now have a more solid solution with the
> ->atomic_async_check and ->atomic_async_commit hooks. Support for that
> for msm and vc4 landed. nouveau and i915 have their own commit
> routines, doing something similar.
>
> For everyone else it's probably better to remove the use-after-free
> bug, and encourage folks to use the async support instead. The
> affected drivers which register a legacy cursor plane and don't either
> use the new async stuff or their own commit routine are: amdgpu,
> atmel, mediatek, qxl, rockchip, sti, sun4i, tegra, virtio, and vmwgfx.
>
> Inspired by an amdgpu bug report.
Thanks for submitting that patch. It's been in the downstream RPi tree
for a while, so I'd really like it to be merged eventually :)
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "DRI Development" <dri-devel@lists.freedesktop.org>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
mikita.lipski@amd.com, "Michel Dänzer" <michel@daenzer.net>,
harry.wentland@amd.com, "Rob Clark" <robdclark@gmail.com>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Sean Paul" <sean@poorly.run>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Imre Deak" <imre.deak@intel.com>,
"Manasi Navare" <manasi.d.navare@intel.com>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Daniel Vetter" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks
Date: Tue, 7 Mar 2023 15:56:13 +0100 [thread overview]
Message-ID: <20230307145613.xvhru3fpcudlpazt@houat> (raw)
In-Reply-To: <20230216111214.3489223-1-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1059 bytes --]
Hi,
On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote:
> The stuff never really worked, and leads to lots of fun because it
> out-of-order frees atomic states. Which upsets KASAN, among other
> things.
>
> For async updates we now have a more solid solution with the
> ->atomic_async_check and ->atomic_async_commit hooks. Support for that
> for msm and vc4 landed. nouveau and i915 have their own commit
> routines, doing something similar.
>
> For everyone else it's probably better to remove the use-after-free
> bug, and encourage folks to use the async support instead. The
> affected drivers which register a legacy cursor plane and don't either
> use the new async stuff or their own commit routine are: amdgpu,
> atmel, mediatek, qxl, rockchip, sti, sun4i, tegra, virtio, and vmwgfx.
>
> Inspired by an amdgpu bug report.
Thanks for submitting that patch. It's been in the downstream RPi tree
for a while, so I'd really like it to be merged eventually :)
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-07 14:56 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 11:12 [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks Daniel Vetter
2023-02-16 11:12 ` Daniel Vetter
2023-02-16 11:12 ` [Intel-gfx] " Daniel Vetter
2023-02-16 11:12 ` Daniel Vetter
2023-02-16 15:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helpers: remove legacy_cursor_update hacks (rev3) Patchwork
2023-02-17 1:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-22 23:14 ` [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks Rob Clark
2023-02-22 23:14 ` Rob Clark
2023-02-22 23:14 ` [Intel-gfx] " Rob Clark
2023-02-22 23:14 ` Rob Clark
2023-02-22 23:21 ` Rob Clark
2023-02-22 23:21 ` Rob Clark
2023-02-22 23:21 ` [Intel-gfx] " Rob Clark
2023-02-22 23:21 ` Rob Clark
2023-03-07 14:56 ` Maxime Ripard [this message]
2023-03-07 14:56 ` Maxime Ripard
2023-03-07 14:56 ` Maxime Ripard
2023-03-07 14:56 ` [Intel-gfx] " Maxime Ripard
2024-01-23 6:09 ` Jason-JH Lin (林睿祥)
2024-01-23 6:09 ` Jason-JH Lin (林睿祥)
2024-01-23 6:09 ` Jason-JH Lin (林睿祥)
2024-01-23 6:09 ` Jason-JH Lin (林睿祥)
2024-01-23 6:09 ` Jason-JH Lin (林睿祥)
2024-01-25 18:17 ` Daniel Vetter
2024-01-25 18:17 ` Daniel Vetter
2024-01-25 18:17 ` Daniel Vetter
2024-01-25 18:17 ` Daniel Vetter
2024-01-25 18:17 ` Daniel Vetter
2024-01-28 9:24 ` Maxime Ripard
2024-01-28 9:24 ` Maxime Ripard
2024-01-31 5:27 ` Jason-JH Lin (林睿祥)
2024-01-31 5:27 ` Jason-JH Lin (林睿祥)
2024-01-31 5:27 ` Jason-JH Lin (林睿祥)
2024-01-31 10:57 ` mripard
2024-01-31 10:57 ` mripard
2024-01-31 10:57 ` mripard
2024-01-31 10:57 ` mripard
2024-01-31 10:57 ` mripard
2024-01-31 5:17 ` Jason-JH Lin (林睿祥)
2024-01-31 5:17 ` Jason-JH Lin (林睿祥)
2024-01-31 5:17 ` Jason-JH Lin (林睿祥)
2024-01-31 5:17 ` Jason-JH Lin (林睿祥)
2024-01-31 5:17 ` Jason-JH Lin (林睿祥)
2024-01-31 9:11 ` Daniel Vetter
2024-01-31 9:11 ` Daniel Vetter
2024-01-31 9:11 ` Daniel Vetter
2024-01-31 9:11 ` Daniel Vetter
2024-01-31 9:11 ` Daniel Vetter
2024-01-31 10:26 ` Dmitry Baryshkov
2024-01-31 10:26 ` Dmitry Baryshkov
2024-01-31 10:26 ` Dmitry Baryshkov
2024-01-31 11:28 ` Daniel Vetter
2024-01-31 11:28 ` Daniel Vetter
2024-01-31 11:28 ` Daniel Vetter
2024-01-31 11:28 ` Daniel Vetter
2024-01-31 11:28 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 15:20 Daniel Vetter
2022-04-01 8:39 ` Maxime Ripard
2022-04-06 21:57 ` Rob Clark
2022-04-07 1:27 ` Jessica Zhang
2022-04-07 9:33 ` Daniel Vetter
2022-04-07 22:51 ` Rob Clark
2022-04-07 22:59 ` Abhinav Kumar
2022-04-07 23:12 ` Rob Clark
2022-04-09 4:04 ` Abhinav Kumar
2022-04-12 23:36 ` Abhinav Kumar
2022-04-13 11:20 ` Daniel Vetter
2022-04-28 8:08 ` Maxime Ripard
2022-04-28 12:09 ` Daniel Vetter
2022-05-12 8:08 ` Maxime Ripard
2022-09-26 15:06 ` Melissa Wen
2022-04-07 7:49 ` Thomas Zimmermann
2022-04-07 9:30 ` Daniel Vetter
2020-10-21 16:32 [PATCH 1/3] " Daniel Vetter
2020-10-23 12:26 ` [PATCH] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307145613.xvhru3fpcudlpazt@houat \
--to=maxime@cerno.tech \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=manasi.d.navare@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=michel@daenzer.net \
--cc=mikita.lipski@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=quic_abhinavk@quicinc.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.