Re: [PATCH 7/7] accel/ivpu: Fix VPU clock calculation

From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
	Oded Gabbay <ogabbay@kernel.org>,
	Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 7/7] accel/ivpu: Fix VPU clock calculation
Date: Thu, 23 Mar 2023 12:00:47 +0100	[thread overview]
Message-ID: <20230323110047.GE2130371@linux.intel.com> (raw)
In-Reply-To: <20230322162848.GC2130371@linux.intel.com>

On Wed, Mar 22, 2023 at 05:28:48PM +0100, Stanislaw Gruszka wrote:
> On Wed, Mar 22, 2023 at 08:52:56AM -0600, Jeffrey Hugo wrote:
> > On 3/22/2023 3:19 AM, Stanislaw Gruszka wrote:
> > > VPU cpu clock frequency depends on the workpoint configuration
> > > that was granted by the punit. Previously driver was passing
> > > incorrect frequency to the VPU firmware.
> > 
> > This looks like past tense.  I believe the preference is to use the present
> > tense for commit text.  Something like "the driver calculates the wrong
> > frequency because it ignores the workpoint config and this causes X.  Fix
> > this by using the workpoint config in the freq calculations".
> 
> Will do.
> 
> > Should this have a fixes tag?  Sounds like this addresses a bug.
> 
> Not sure how this is done, but seems all my previous patches for ivpu
> have Fixes tag in commit message, even if I did not post the tag in
> the patches. Seems to be a feature of drm git tooling and can be
> easily done by committer ?

Tags were added by Jacek,  I'll add them to the patchset then.

Regards
Stanislaw