From: kernel test robot <lkp@intel.com> To: Anuj Gupta <anuj20.g@samsung.com>, Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, James Smart <james.smart@broadcom.com>, Chaitanya Kulkarni <kch@nvidia.com>, Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org> Cc: oe-kbuild-all@lists.linux.dev, bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com, damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, Nitesh Shetty <nj.shetty@samsung.com>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Date: Wed, 29 Mar 2023 21:56:55 +0800 [thread overview] Message-ID: <202303292148.Pbx4mDpS-lkp@intel.com> (raw) In-Reply-To: <20230327084103.21601-7-anuj20.g@samsung.com> Hi Anuj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.3-rc4 next-20230329] [cannot apply to device-mapper-dm/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230327084103.21601-7-anuj20.g%40samsung.com patch subject: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns config: arm64-randconfig-s041-20230329 (https://download.01.org/0day-ci/archive/20230329/202303292148.Pbx4mDpS-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/f846a8ac40882d9d42532e9e2b43560650ef8510 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 git checkout f846a8ac40882d9d42532e9e2b43560650ef8510 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/target/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303292148.Pbx4mDpS-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: got restricted __le16 [usertype] mssrl >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:57:29: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: got restricted __le16 [usertype] mssrl drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 vim +55 drivers/nvme/target/io-cmd-bdev.c 12 13 void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) 14 { 15 /* Logical blocks per physical block, 0's based. */ 16 const __le16 lpp0b = to0based(bdev_physical_block_size(bdev) / 17 bdev_logical_block_size(bdev)); 18 19 /* 20 * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN, 21 * NAWUPF, and NACWU are defined for this namespace and should be 22 * used by the host for this namespace instead of the AWUN, AWUPF, 23 * and ACWU fields in the Identify Controller data structure. If 24 * any of these fields are zero that means that the corresponding 25 * field from the identify controller data structure should be used. 26 */ 27 id->nsfeat |= 1 << 1; 28 id->nawun = lpp0b; 29 id->nawupf = lpp0b; 30 id->nacwu = lpp0b; 31 32 /* 33 * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and 34 * NOWS are defined for this namespace and should be used by 35 * the host for I/O optimization. 36 */ 37 id->nsfeat |= 1 << 4; 38 /* NPWG = Namespace Preferred Write Granularity. 0's based */ 39 id->npwg = lpp0b; 40 /* NPWA = Namespace Preferred Write Alignment. 0's based */ 41 id->npwa = id->npwg; 42 /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */ 43 id->npdg = to0based(bdev_discard_granularity(bdev) / 44 bdev_logical_block_size(bdev)); 45 /* NPDG = Namespace Preferred Deallocate Alignment */ 46 id->npda = id->npdg; 47 /* NOWS = Namespace Optimal Write Size */ 48 id->nows = to0based(bdev_io_opt(bdev) / bdev_logical_block_size(bdev)); 49 50 /*Copy limits*/ 51 if (bdev_max_copy_sectors(bdev)) { 52 id->msrc = id->msrc; 53 id->mssrl = cpu_to_le16((bdev_max_copy_sectors(bdev) << 54 SECTOR_SHIFT) / bdev_logical_block_size(bdev)); > 55 id->mcl = cpu_to_le32(id->mssrl); 56 } else { 57 id->msrc = (u8)to0based(BIO_MAX_VECS - 1); 58 id->mssrl = cpu_to_le16((BIO_MAX_VECS << PAGE_SHIFT) / 59 bdev_logical_block_size(bdev)); 60 id->mcl = cpu_to_le32(id->mssrl); 61 } 62 } 63 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Anuj Gupta <anuj20.g@samsung.com>, Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, James Smart <james.smart@broadcom.com>, Chaitanya Kulkarni <kch@nvidia.com>, Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org> Cc: bvanassche@acm.org, joshi.k@samsung.com, Nitesh Shetty <nj.shetty@samsung.com>, gost.dev@samsung.com, anuj20.g@samsung.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, ming.lei@redhat.com, linux-block@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, damien.lemoal@opensource.wdc.com, nitheshshetty@gmail.com Subject: Re: [dm-devel] [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Date: Wed, 29 Mar 2023 21:56:55 +0800 [thread overview] Message-ID: <202303292148.Pbx4mDpS-lkp@intel.com> (raw) In-Reply-To: <20230327084103.21601-7-anuj20.g@samsung.com> Hi Anuj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.3-rc4 next-20230329] [cannot apply to device-mapper-dm/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230327084103.21601-7-anuj20.g%40samsung.com patch subject: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns config: arm64-randconfig-s041-20230329 (https://download.01.org/0day-ci/archive/20230329/202303292148.Pbx4mDpS-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/f846a8ac40882d9d42532e9e2b43560650ef8510 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 git checkout f846a8ac40882d9d42532e9e2b43560650ef8510 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/target/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303292148.Pbx4mDpS-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: got restricted __le16 [usertype] mssrl >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:57:29: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: got restricted __le16 [usertype] mssrl drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 vim +55 drivers/nvme/target/io-cmd-bdev.c 12 13 void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) 14 { 15 /* Logical blocks per physical block, 0's based. */ 16 const __le16 lpp0b = to0based(bdev_physical_block_size(bdev) / 17 bdev_logical_block_size(bdev)); 18 19 /* 20 * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN, 21 * NAWUPF, and NACWU are defined for this namespace and should be 22 * used by the host for this namespace instead of the AWUN, AWUPF, 23 * and ACWU fields in the Identify Controller data structure. If 24 * any of these fields are zero that means that the corresponding 25 * field from the identify controller data structure should be used. 26 */ 27 id->nsfeat |= 1 << 1; 28 id->nawun = lpp0b; 29 id->nawupf = lpp0b; 30 id->nacwu = lpp0b; 31 32 /* 33 * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and 34 * NOWS are defined for this namespace and should be used by 35 * the host for I/O optimization. 36 */ 37 id->nsfeat |= 1 << 4; 38 /* NPWG = Namespace Preferred Write Granularity. 0's based */ 39 id->npwg = lpp0b; 40 /* NPWA = Namespace Preferred Write Alignment. 0's based */ 41 id->npwa = id->npwg; 42 /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */ 43 id->npdg = to0based(bdev_discard_granularity(bdev) / 44 bdev_logical_block_size(bdev)); 45 /* NPDG = Namespace Preferred Deallocate Alignment */ 46 id->npda = id->npdg; 47 /* NOWS = Namespace Optimal Write Size */ 48 id->nows = to0based(bdev_io_opt(bdev) / bdev_logical_block_size(bdev)); 49 50 /*Copy limits*/ 51 if (bdev_max_copy_sectors(bdev)) { 52 id->msrc = id->msrc; 53 id->mssrl = cpu_to_le16((bdev_max_copy_sectors(bdev) << 54 SECTOR_SHIFT) / bdev_logical_block_size(bdev)); > 55 id->mcl = cpu_to_le32(id->mssrl); 56 } else { 57 id->msrc = (u8)to0based(BIO_MAX_VECS - 1); 58 id->mssrl = cpu_to_le16((BIO_MAX_VECS << PAGE_SHIFT) / 59 bdev_logical_block_size(bdev)); 60 id->mcl = cpu_to_le32(id->mssrl); 61 } 62 } 63 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-03-29 13:58 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230327084154epcas5p2a1d8ee728610929fbba8c7757ad3193e@epcas5p2.samsung.com> 2023-03-27 8:40 ` [PATCH v8 0/9] Implement copy offload support Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta [not found] ` <CGME20230327084216epcas5p3945507ecd94688c40c29195127ddc54d@epcas5p3.samsung.com> 2023-03-27 8:40 ` [PATCH v8 1/9] block: Introduce queue limits for copy-offload support Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 8:40 ` Damien Le Moal 2023-03-29 8:40 ` [dm-devel] " Damien Le Moal 2023-03-29 10:41 ` Nitesh Shetty 2023-03-29 10:41 ` [dm-devel] " Nitesh Shetty 2023-03-29 12:24 ` Damien Le Moal 2023-03-29 12:24 ` [dm-devel] " Damien Le Moal 2023-03-29 12:34 ` Nitesh Shetty 2023-03-29 12:34 ` [dm-devel] " Nitesh Shetty [not found] ` <CGME20230327084226epcas5p28e667b25cbb5e4b0e884aa2ca89cbfff@epcas5p2.samsung.com> 2023-03-27 8:40 ` [PATCH v8 2/9] block: Add copy offload support infrastructure Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 8:56 ` Damien Le Moal 2023-03-29 8:56 ` Damien Le Moal [not found] ` <CGME20230327084235epcas5p495559f907ce39184da72a412c5691e43@epcas5p4.samsung.com> 2023-03-27 8:40 ` [PATCH v8 3/9] block: add emulation for copy Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta [not found] ` <CGME20230327084244epcas5p1b0ede867e558ff6faf258de3656a8aa4@epcas5p1.samsung.com> 2023-03-27 8:40 ` [PATCH v8 4/9] fs, block: copy_file_range for def_blk_ops for direct block device Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 12:14 ` Christian Brauner 2023-03-29 12:14 ` [dm-devel] " Christian Brauner 2023-03-29 12:42 ` Nitesh Shetty 2023-03-29 12:42 ` [dm-devel] " Nitesh Shetty 2023-03-30 5:48 ` Christian Brauner 2023-03-30 5:48 ` [dm-devel] " Christian Brauner 2023-03-30 15:21 ` Nitesh Shetty 2023-03-30 15:21 ` [dm-devel] " Nitesh Shetty 2023-03-29 14:07 ` kernel test robot 2023-03-29 14:07 ` [dm-devel] " kernel test robot 2023-03-29 15:30 ` kernel test robot 2023-03-29 15:30 ` [dm-devel] " kernel test robot [not found] ` <CGME20230327084254epcas5p4c5f324c1501062f743895273c302c0a4@epcas5p4.samsung.com> 2023-03-27 8:40 ` [PATCH v8 5/9] nvme: add copy offload support Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta [not found] ` <CGME20230327084303epcas5p22fdd3af683d3eb1b3f503bcf045f578a@epcas5p2.samsung.com> 2023-03-27 8:40 ` [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 13:56 ` kernel test robot [this message] 2023-03-29 13:56 ` kernel test robot 2023-03-29 18:36 ` kernel test robot 2023-03-29 18:36 ` [dm-devel] " kernel test robot [not found] ` <CGME20230327084312epcas5p377810b172aa6048519591518f8c308d0@epcas5p3.samsung.com> 2023-03-27 8:40 ` [PATCH v8 7/9] dm: Add support for copy offload Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 8:59 ` Damien Le Moal 2023-03-29 8:59 ` [dm-devel] " Damien Le Moal 2023-03-29 12:12 ` Nitesh Shetty 2023-03-29 12:12 ` [dm-devel] " Nitesh Shetty [not found] ` <CGME20230327084322epcas5p12f01e676e47d3c8ba880f3f5d58999b4@epcas5p1.samsung.com> 2023-03-27 8:40 ` [PATCH v8 8/9] dm: Enable copy offload for dm-linear target Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta [not found] ` <CGME20230327084331epcas5p2510ed79d04fe3432c2ec84ce528745c6@epcas5p2.samsung.com> 2023-03-27 8:40 ` [PATCH v8 9/9] null_blk: add support for copy offload Anuj Gupta 2023-03-27 8:40 ` [dm-devel] " Anuj Gupta 2023-03-29 9:04 ` Damien Le Moal 2023-03-29 9:04 ` [dm-devel] " Damien Le Moal 2023-03-29 12:22 ` Nitesh Shetty 2023-03-29 12:22 ` [dm-devel] " Nitesh Shetty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202303292148.Pbx4mDpS-lkp@intel.com \ --to=lkp@intel.com \ --cc=agk@redhat.com \ --cc=anuj20.g@samsung.com \ --cc=axboe@kernel.dk \ --cc=brauner@kernel.org \ --cc=bvanassche@acm.org \ --cc=damien.lemoal@opensource.wdc.com \ --cc=dm-devel@redhat.com \ --cc=gost.dev@samsung.com \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=james.smart@broadcom.com \ --cc=joshi.k@samsung.com \ --cc=kbusch@kernel.org \ --cc=kch@nvidia.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=ming.lei@redhat.com \ --cc=nitheshshetty@gmail.com \ --cc=nj.shetty@samsung.com \ --cc=oe-kbuild-all@lists.linux.dev \ --cc=sagi@grimberg.me \ --cc=snitzer@kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.