Re: [PATCH v2 1/2] KVM: PPC: Permit SRR1 flags in more injected interrupt types

From: kernel test robot <lkp@intel.com>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@ozlabs.org
Cc: oe-kbuild-all@lists.linux.dev,
	Nicholas Piggin <npiggin@gmail.com>,
	kvm@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
	Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH v2 1/2] KVM: PPC: Permit SRR1 flags in more injected interrupt types
Date: Sun, 2 Apr 2023 08:27:29 +0800	[thread overview]
Message-ID: <202304020827.3LEZ86WB-lkp@intel.com> (raw)
In-Reply-To: <20230330103224.3589928-2-npiggin@gmail.com>

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/topic/ppc-kvm]
[also build test ERROR on linus/master v6.3-rc4 next-20230331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicholas-Piggin/KVM-PPC-Permit-SRR1-flags-in-more-injected-interrupt-types/20230330-183420
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/ppc-kvm
patch link:    https://lore.kernel.org/r/20230330103224.3589928-2-npiggin%40gmail.com
patch subject: [PATCH v2 1/2] KVM: PPC: Permit SRR1 flags in more injected interrupt types
config: powerpc-randconfig-c033-20230402 (https://download.01.org/0day-ci/archive/20230402/202304020827.3LEZ86WB-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/31c610025a69f60bfa70c098471861456b2e4012
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nicholas-Piggin/KVM-PPC-Permit-SRR1-flags-in-more-injected-interrupt-types/20230330-183420
        git checkout 31c610025a69f60bfa70c098471861456b2e4012
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kvm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304020827.3LEZ86WB-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/powerpc/kvm/booke.c:1011:5: error: no previous prototype for 'kvmppc_handle_exit' [-Werror=missing-prototypes]
    1011 | int kvmppc_handle_exit(struct kvm_vcpu *vcpu, unsigned int exit_nr)
         |     ^~~~~~~~~~~~~~~~~~
   arch/powerpc/kvm/booke.c: In function 'kvmppc_handle_exit':
>> arch/powerpc/kvm/booke.c:1244:17: error: too many arguments to function 'kvmppc_core_queue_alignment'
    1244 |                 kvmppc_core_queue_alignment(vcpu, 0, vcpu->arch.fault_dear,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/kvm/booke.c:306:13: note: declared here
     306 | static void kvmppc_core_queue_alignment(struct kvm_vcpu *vcpu, ulong dear_flags,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/kvmppc_core_queue_alignment +1244 arch/powerpc/kvm/booke.c

  1229	
  1230		case BOOKE_INTERRUPT_DATA_STORAGE:
  1231			kvmppc_core_queue_data_storage(vcpu, 0, vcpu->arch.fault_dear,
  1232			                               vcpu->arch.fault_esr);
  1233			kvmppc_account_exit(vcpu, DSI_EXITS);
  1234			r = RESUME_GUEST;
  1235			break;
  1236	
  1237		case BOOKE_INTERRUPT_INST_STORAGE:
  1238			kvmppc_core_queue_inst_storage(vcpu, vcpu->arch.fault_esr);
  1239			kvmppc_account_exit(vcpu, ISI_EXITS);
  1240			r = RESUME_GUEST;
  1241			break;
  1242	
  1243		case BOOKE_INTERRUPT_ALIGNMENT:
> 1244			kvmppc_core_queue_alignment(vcpu, 0, vcpu->arch.fault_dear,
  1245			                            vcpu->arch.fault_esr);
  1246			r = RESUME_GUEST;
  1247			break;
  1248	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests