From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v6 02/13] media: AV1: Make sure that bit depth in correctly initialize
Date: Wed, 12 Apr 2023 13:56:41 +0200 [thread overview]
Message-ID: <20230412115652.403949-3-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20230412115652.403949-1-benjamin.gaignard@collabora.com>
Make sure that bit_depth field of V4L2_CTRL_TYPE_AV1_SEQUENCE
is initialized correctly before using it.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 9fd37e94db17..a662fb60f73f 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -111,6 +111,7 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
struct v4l2_ctrl_vp9_frame *p_vp9_frame;
struct v4l2_ctrl_fwht_params *p_fwht_params;
struct v4l2_ctrl_h264_scaling_matrix *p_h264_scaling_matrix;
+ struct v4l2_ctrl_av1_sequence *p_av1_sequence;
void *p = ptr.p + idx * ctrl->elem_size;
if (ctrl->p_def.p_const)
@@ -157,6 +158,10 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
p_vp9_frame->flags |= V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING;
break;
+ case V4L2_CTRL_TYPE_AV1_SEQUENCE:
+ p_av1_sequence = p;
+ p_av1_sequence->bit_depth = 8;
+ break;
case V4L2_CTRL_TYPE_FWHT_PARAMS:
p_fwht_params = p;
p_fwht_params->version = V4L2_FWHT_VERSION;
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v6 02/13] media: AV1: Make sure that bit depth in correctly initialize
Date: Wed, 12 Apr 2023 13:56:41 +0200 [thread overview]
Message-ID: <20230412115652.403949-3-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20230412115652.403949-1-benjamin.gaignard@collabora.com>
Make sure that bit_depth field of V4L2_CTRL_TYPE_AV1_SEQUENCE
is initialized correctly before using it.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 9fd37e94db17..a662fb60f73f 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -111,6 +111,7 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
struct v4l2_ctrl_vp9_frame *p_vp9_frame;
struct v4l2_ctrl_fwht_params *p_fwht_params;
struct v4l2_ctrl_h264_scaling_matrix *p_h264_scaling_matrix;
+ struct v4l2_ctrl_av1_sequence *p_av1_sequence;
void *p = ptr.p + idx * ctrl->elem_size;
if (ctrl->p_def.p_const)
@@ -157,6 +158,10 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
p_vp9_frame->flags |= V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING;
break;
+ case V4L2_CTRL_TYPE_AV1_SEQUENCE:
+ p_av1_sequence = p;
+ p_av1_sequence->bit_depth = 8;
+ break;
case V4L2_CTRL_TYPE_FWHT_PARAMS:
p_fwht_params = p;
p_fwht_params->version = V4L2_FWHT_VERSION;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v6 02/13] media: AV1: Make sure that bit depth in correctly initialize
Date: Wed, 12 Apr 2023 13:56:41 +0200 [thread overview]
Message-ID: <20230412115652.403949-3-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20230412115652.403949-1-benjamin.gaignard@collabora.com>
Make sure that bit_depth field of V4L2_CTRL_TYPE_AV1_SEQUENCE
is initialized correctly before using it.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 9fd37e94db17..a662fb60f73f 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -111,6 +111,7 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
struct v4l2_ctrl_vp9_frame *p_vp9_frame;
struct v4l2_ctrl_fwht_params *p_fwht_params;
struct v4l2_ctrl_h264_scaling_matrix *p_h264_scaling_matrix;
+ struct v4l2_ctrl_av1_sequence *p_av1_sequence;
void *p = ptr.p + idx * ctrl->elem_size;
if (ctrl->p_def.p_const)
@@ -157,6 +158,10 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
p_vp9_frame->flags |= V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING;
break;
+ case V4L2_CTRL_TYPE_AV1_SEQUENCE:
+ p_av1_sequence = p;
+ p_av1_sequence->bit_depth = 8;
+ break;
case V4L2_CTRL_TYPE_FWHT_PARAMS:
p_fwht_params = p;
p_fwht_params->version = V4L2_FWHT_VERSION;
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-04-12 11:57 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 11:56 [PATCH v6 00/13] AV1 stateless decoder for RK3588 Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 01/13] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard [this message]
2023-04-12 11:56 ` [PATCH v6 02/13] media: AV1: Make sure that bit depth in correctly initialize Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 14:29 ` kernel test robot
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 03/13] v4l2-common: Add support for fractional bpp Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 04/13] media: Add NV15_4L4 pixel format Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 05/13] media: verisilicon: Get bit depth for V4L2_PIX_FMT_NV15_4L4 Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 06/13] media: verisilicon: Add AV1 decoder mode and controls Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 07/13] media: verisilicon: Check AV1 bitstreams bit depth Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 08/13] media: verisilicon: Compute motion vectors size for AV1 frames Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 09/13] media: verisilicon: Add AV1 entropy helpers Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 10/13] media: verisilicon: Add Rockchip AV1 decoder Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 13:58 ` kernel test robot
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 11/13] media: verisilicon: Add film grain feature to AV1 driver Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 12/13] media: verisilicon: Enable AV1 decoder on rk3588 Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 12:43 ` Hans Verkuil
2023-04-12 12:43 ` Hans Verkuil
2023-04-12 12:43 ` Hans Verkuil
2023-04-12 15:50 ` Nicolas Dufresne
2023-04-12 15:50 ` Nicolas Dufresne
2023-04-12 15:50 ` Nicolas Dufresne
2023-04-12 16:12 ` Benjamin Gaignard
2023-04-12 16:12 ` Benjamin Gaignard
2023-04-12 16:12 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 13/13] media: verisilicon: Conditionally ignore native formats Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
2023-04-12 11:56 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412115652.403949-3-benjamin.gaignard@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.