From: Alexandre Ghiti <alexghiti@rivosinc.com>
To: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>, Will Deacon <will@kernel.org>,
Rob Herring <robh@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [PATCH 1/4] perf: Fix wrong comment about default event_idx
Date: Thu, 13 Apr 2023 18:17:22 +0200 [thread overview]
Message-ID: <20230413161725.195417-2-alexghiti@rivosinc.com> (raw)
In-Reply-To: <20230413161725.195417-1-alexghiti@rivosinc.com>
event_idx default implementation returns 0, not idx + 1.
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
---
include/linux/perf_event.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d5628a7b5eaa..56fe43b20966 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -442,7 +442,8 @@ struct pmu {
/*
* Will return the value for perf_event_mmap_page::index for this event,
- * if no implementation is provided it will default to: event->hw.idx + 1.
+ * if no implementation is provided it will default to 0 (see
+ * perf_event_idx_default).
*/
int (*event_idx) (struct perf_event *event); /*optional */
--
2.37.2
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Ghiti <alexghiti@rivosinc.com>
To: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>, Will Deacon <will@kernel.org>,
Rob Herring <robh@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [PATCH 1/4] perf: Fix wrong comment about default event_idx
Date: Thu, 13 Apr 2023 18:17:22 +0200 [thread overview]
Message-ID: <20230413161725.195417-2-alexghiti@rivosinc.com> (raw)
In-Reply-To: <20230413161725.195417-1-alexghiti@rivosinc.com>
event_idx default implementation returns 0, not idx + 1.
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
---
include/linux/perf_event.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d5628a7b5eaa..56fe43b20966 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -442,7 +442,8 @@ struct pmu {
/*
* Will return the value for perf_event_mmap_page::index for this event,
- * if no implementation is provided it will default to: event->hw.idx + 1.
+ * if no implementation is provided it will default to 0 (see
+ * perf_event_idx_default).
*/
int (*event_idx) (struct perf_event *event); /*optional */
--
2.37.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Ghiti <alexghiti@rivosinc.com>
To: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>, Will Deacon <will@kernel.org>,
Rob Herring <robh@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [PATCH 1/4] perf: Fix wrong comment about default event_idx
Date: Thu, 13 Apr 2023 18:17:22 +0200 [thread overview]
Message-ID: <20230413161725.195417-2-alexghiti@rivosinc.com> (raw)
In-Reply-To: <20230413161725.195417-1-alexghiti@rivosinc.com>
event_idx default implementation returns 0, not idx + 1.
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
---
include/linux/perf_event.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d5628a7b5eaa..56fe43b20966 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -442,7 +442,8 @@ struct pmu {
/*
* Will return the value for perf_event_mmap_page::index for this event,
- * if no implementation is provided it will default to: event->hw.idx + 1.
+ * if no implementation is provided it will default to 0 (see
+ * perf_event_idx_default).
*/
int (*event_idx) (struct perf_event *event); /*optional */
--
2.37.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-13 16:18 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 16:17 [PATCH 0/4] riscv: Allow userspace to directly access perf counters Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti [this message]
2023-04-13 16:17 ` [PATCH 1/4] perf: Fix wrong comment about default event_idx Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` [PATCH 2/4] include: riscv: Fix wrong include guard in riscv_pmu.h Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-18 18:26 ` Conor Dooley
2023-04-18 18:26 ` Conor Dooley
2023-04-18 18:26 ` Conor Dooley
2023-04-13 16:17 ` [PATCH 3/4] riscv: Make legacy counter enum match the HW numbering Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` [PATCH 4/4] riscv: Enable perf counters user access only through perf Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 16:17 ` Alexandre Ghiti
2023-04-13 21:20 ` kernel test robot
2023-04-13 21:20 ` kernel test robot
2023-04-13 21:20 ` kernel test robot
2023-04-14 2:09 ` kernel test robot
2023-04-14 2:09 ` kernel test robot
2023-04-14 2:09 ` kernel test robot
2023-04-26 12:57 ` Andrew Jones
2023-04-26 12:57 ` Andrew Jones
2023-04-26 12:57 ` Andrew Jones
2023-04-26 13:17 ` Alexandre Ghiti
2023-04-26 13:17 ` Alexandre Ghiti
2023-04-26 13:17 ` Alexandre Ghiti
2023-04-26 13:25 ` Andrew Jones
2023-04-26 13:25 ` Andrew Jones
2023-04-26 13:25 ` Andrew Jones
2023-04-29 6:19 ` Atish Patra
2023-04-29 6:19 ` Atish Patra
2023-04-29 6:19 ` Atish Patra
2023-04-29 6:50 ` Atish Patra
2023-04-29 6:50 ` Atish Patra
2023-04-29 6:50 ` Atish Patra
2023-05-09 12:24 ` Emil Renner Berthing
2023-05-09 12:24 ` Emil Renner Berthing
2023-05-09 13:40 ` Alexandre Ghiti
2023-05-09 13:40 ` Alexandre Ghiti
2023-05-01 2:09 ` Bagas Sanjaya
2023-05-01 2:09 ` Bagas Sanjaya
2023-05-01 2:09 ` Bagas Sanjaya
2023-04-13 16:36 ` [PATCH 0/4] riscv: Allow userspace to directly access perf counters Ian Rogers
2023-04-13 16:36 ` Ian Rogers
2023-04-13 16:36 ` Ian Rogers
2023-04-13 19:17 ` Atish Patra
2023-04-13 19:17 ` Atish Patra
2023-04-13 19:17 ` Atish Patra
2023-04-13 21:10 ` David Laight
2023-04-13 21:10 ` David Laight
2023-04-13 21:10 ` David Laight
2023-04-18 16:43 ` Atish Patra
2023-04-18 16:43 ` Atish Patra
2023-04-18 16:43 ` Atish Patra
2023-04-18 18:15 ` Ian Rogers
2023-04-18 18:15 ` Ian Rogers
2023-04-18 18:15 ` Ian Rogers
2023-04-18 20:30 ` Atish Patra
2023-04-18 20:30 ` Atish Patra
2023-04-18 20:30 ` Atish Patra
2023-04-19 9:21 ` Alexandre Ghiti
2023-04-19 9:21 ` Alexandre Ghiti
2023-04-19 9:21 ` Alexandre Ghiti
2023-04-19 17:42 ` Ian Rogers
2023-04-19 17:42 ` Ian Rogers
2023-04-19 17:42 ` Ian Rogers
2023-04-19 23:21 ` Atish Patra
2023-04-19 23:21 ` Atish Patra
2023-04-19 23:21 ` Atish Patra
2023-04-20 0:31 ` Ian Rogers
2023-04-20 0:31 ` Ian Rogers
2023-04-20 0:31 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413161725.195417-2-alexghiti@rivosinc.com \
--to=alexghiti@rivosinc.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=corbet@lwn.net \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.