From: Fei Shao <fshao@chromium.org> To: Benjamin Tissoires <benjamin.tissoires@redhat.com>, Douglas Anderson <dianders@chromium.org>, Rob Herring <robh+dt@kernel.org> Cc: linux-mediatek <linux-mediatek@lists.infradead.org>, Fei Shao <fshao@chromium.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend property Date: Tue, 18 Apr 2023 20:49:51 +0800 [thread overview] Message-ID: <20230418124953.3170028-2-fshao@chromium.org> (raw) In-Reply-To: <20230418124953.3170028-1-fshao@chromium.org> We observed that on Chromebook device Steelix, if Goodix GT7375P touchscreen is powered in suspend (because, for example, it connects to an always-on regulator) and with the reset GPIO asserted, it will introduce about 14mW power leakage. This property is used to indicate that the touchscreen is powered in suspend. If it's set, the driver will stop asserting the reset GPIO in power-down, and it will do it in power-up instead to ensure that the state is always reset after resuming. Signed-off-by: Fei Shao <fshao@chromium.org> --- Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml index ce18d7dadae2..942acb286d77 100644 --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml @@ -43,6 +43,12 @@ properties: itself as long as it allows the main board to make signals compatible with what the touchscreen is expecting for its IO rails. + powered-in-suspend: + description: + This indicates that the touchscreen is powered in suspend, so the driver + will not assert the reset GPIO in power-down to prevent power leakage. + type: boolean + required: - compatible - reg -- 2.40.0.634.g4ca3ef3211-goog
WARNING: multiple messages have this Message-ID (diff)
From: Fei Shao <fshao@chromium.org> To: Benjamin Tissoires <benjamin.tissoires@redhat.com>, Douglas Anderson <dianders@chromium.org>, Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-kernel@vger.kernel.org, linux-mediatek <linux-mediatek@lists.infradead.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-input@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend property Date: Tue, 18 Apr 2023 20:49:51 +0800 [thread overview] Message-ID: <20230418124953.3170028-2-fshao@chromium.org> (raw) In-Reply-To: <20230418124953.3170028-1-fshao@chromium.org> We observed that on Chromebook device Steelix, if Goodix GT7375P touchscreen is powered in suspend (because, for example, it connects to an always-on regulator) and with the reset GPIO asserted, it will introduce about 14mW power leakage. This property is used to indicate that the touchscreen is powered in suspend. If it's set, the driver will stop asserting the reset GPIO in power-down, and it will do it in power-up instead to ensure that the state is always reset after resuming. Signed-off-by: Fei Shao <fshao@chromium.org> --- Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml index ce18d7dadae2..942acb286d77 100644 --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml @@ -43,6 +43,12 @@ properties: itself as long as it allows the main board to make signals compatible with what the touchscreen is expecting for its IO rails. + powered-in-suspend: + description: + This indicates that the touchscreen is powered in suspend, so the driver + will not assert the reset GPIO in power-down to prevent power leakage. + type: boolean + required: - compatible - reg -- 2.40.0.634.g4ca3ef3211-goog
next prev parent reply other threads:[~2023-04-18 12:51 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-18 12:49 [PATCH 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Fei Shao 2023-04-18 12:49 ` Fei Shao 2023-04-18 12:49 ` Fei Shao [this message] 2023-04-18 12:49 ` [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend property Fei Shao 2023-04-18 14:18 ` Doug Anderson 2023-04-18 18:02 ` Matthias Brugger 2023-04-19 0:20 ` Jeff LaBundy 2023-04-19 10:44 ` Fei Shao 2023-04-19 14:38 ` Doug Anderson 2023-04-19 15:18 ` Jeff LaBundy 2023-04-19 15:18 ` Jeff LaBundy 2023-04-19 15:41 ` Doug Anderson 2023-04-19 15:41 ` Doug Anderson 2023-04-20 8:13 ` Fei Shao 2023-04-24 3:31 ` Jeff LaBundy 2023-04-24 18:14 ` Doug Anderson 2023-04-24 18:14 ` Doug Anderson 2023-04-25 8:34 ` Fei Shao 2023-04-18 12:49 ` [PATCH 2/2] HID: i2c-hid: goodix: Add support for " Fei Shao 2023-04-18 12:49 ` Fei Shao 2023-04-18 14:22 ` Doug Anderson 2023-04-24 3:38 ` Jeff LaBundy 2023-04-24 18:16 ` Doug Anderson 2023-04-24 18:16 ` Doug Anderson 2023-04-25 8:36 ` Fei Shao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230418124953.3170028-2-fshao@chromium.org \ --to=fshao@chromium.org \ --cc=benjamin.tissoires@redhat.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.