From: Fei Shao <fshao@chromium.org> To: Jeff LaBundy <jeff@labundy.com>, Douglas Anderson <dianders@chromium.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Rob Herring <robh+dt@kernel.org> Cc: linux-mediatek <linux-mediatek@lists.infradead.org>, Fei Shao <fshao@chromium.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jiri Kosina <jikos@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Kaehlcke <mka@chromium.org>, Stephen Kitt <steve@sk2.org>, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Date: Thu, 27 Apr 2023 11:56:54 +0800 [thread overview] Message-ID: <20230427035656.1962698-1-fshao@chromium.org> (raw) These changes are based on the series in [1], which modified the i2c-hid-of-goodix driver and removed the workaround for a power leakage issue, so the issue revisits on Mediatek MT8186 boards (Steelix). The root cause is that the touchscreen can be powered in different ways depending on the hardware designs, and it's not as easy to come up with a solution that is both simple and elegant for all the known designs. To address the issue, I ended up adding a new boolean property for the driver so that we can control the power up/down sequence depending on that. Adding a new property might not be the cleanest approach for this, but at least the intention would be easy enough to understand, and it introduces relatively small change to the code and fully preserves the original control flow. I hope this is something acceptable, and I'm open to any better approaches. [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ Changes in v4: - Minor coding style improvement Changes in v3: - In power-down, only skip the GPIO but not the regulator calls if the flag is set Changes in v2: - Use a more accurate property name and with "goodix," prefix. - Do not change the regulator_enable logic during power-up. Fei Shao (2): dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property HID: i2c-hid: goodix: Add support for "goodix,no-reset-during-suspend" property .../bindings/input/goodix,gt7375p.yaml | 9 +++++++++ drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 16 +++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) -- 2.40.1.495.gc816e09b53d-goog
WARNING: multiple messages have this Message-ID (diff)
From: Fei Shao <fshao@chromium.org> To: Jeff LaBundy <jeff@labundy.com>, Douglas Anderson <dianders@chromium.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Stephen Kitt <steve@sk2.org>, Jiri Kosina <jikos@kernel.org>, linux-kernel@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>, linux-mediatek <linux-mediatek@lists.infradead.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-input@vger.kernel.org Subject: [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Date: Thu, 27 Apr 2023 11:56:54 +0800 [thread overview] Message-ID: <20230427035656.1962698-1-fshao@chromium.org> (raw) These changes are based on the series in [1], which modified the i2c-hid-of-goodix driver and removed the workaround for a power leakage issue, so the issue revisits on Mediatek MT8186 boards (Steelix). The root cause is that the touchscreen can be powered in different ways depending on the hardware designs, and it's not as easy to come up with a solution that is both simple and elegant for all the known designs. To address the issue, I ended up adding a new boolean property for the driver so that we can control the power up/down sequence depending on that. Adding a new property might not be the cleanest approach for this, but at least the intention would be easy enough to understand, and it introduces relatively small change to the code and fully preserves the original control flow. I hope this is something acceptable, and I'm open to any better approaches. [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ Changes in v4: - Minor coding style improvement Changes in v3: - In power-down, only skip the GPIO but not the regulator calls if the flag is set Changes in v2: - Use a more accurate property name and with "goodix," prefix. - Do not change the regulator_enable logic during power-up. Fei Shao (2): dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property HID: i2c-hid: goodix: Add support for "goodix,no-reset-during-suspend" property .../bindings/input/goodix,gt7375p.yaml | 9 +++++++++ drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 16 +++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) -- 2.40.1.495.gc816e09b53d-goog
next reply other threads:[~2023-04-27 3:57 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-27 3:56 Fei Shao [this message] 2023-04-27 3:56 ` [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Fei Shao 2023-04-27 3:56 ` [PATCH v4 1/2] dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property Fei Shao 2023-04-27 3:56 ` Fei Shao 2023-04-27 17:35 ` Rob Herring 2023-04-27 3:56 ` [PATCH v4 2/2] HID: i2c-hid: goodix: Add support for " Fei Shao 2023-04-27 3:56 ` Fei Shao 2023-05-19 14:08 ` [PATCH v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Doug Anderson 2023-05-23 13:11 ` Jiri Kosina 2023-05-23 13:11 ` Jiri Kosina 2023-05-23 13:32 ` Doug Anderson 2023-05-23 13:32 ` Doug Anderson 2023-05-23 15:29 ` Fei Shao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230427035656.1962698-1-fshao@chromium.org \ --to=fshao@chromium.org \ --cc=benjamin.tissoires@redhat.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=jeff@labundy.com \ --cc=jikos@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mka@chromium.org \ --cc=robh+dt@kernel.org \ --cc=steve@sk2.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.