From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Xiubo Li <xiubli@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>, Miklos Szeredi <miklos@szeredi.hu>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write
Date: Wed, 24 May 2023 08:38:10 +0200 [thread overview]
Message-ID: <20230524063810.1595778-12-hch@lst.de> (raw)
In-Reply-To: <20230524063810.1595778-1-hch@lst.de>
pos is always equal to iocb->ki_pos, and mapping is always equal to
iocb->ki_filp->f_mapping.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
fs/fuse/file.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 90d587a7bdf813..bf48aae49daf56 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1280,13 +1280,13 @@ static inline unsigned int fuse_wr_pages(loff_t pos, size_t len,
max_pages);
}
-static ssize_t fuse_perform_write(struct kiocb *iocb,
- struct address_space *mapping,
- struct iov_iter *ii, loff_t pos)
+static ssize_t fuse_perform_write(struct kiocb *iocb, struct iov_iter *ii)
{
+ struct address_space *mapping = iocb->ki_filp->f_mapping;
struct inode *inode = mapping->host;
struct fuse_conn *fc = get_fuse_conn(inode);
struct fuse_inode *fi = get_fuse_inode(inode);
+ loff_t pos = iocb->ki_pos;
int err = 0;
ssize_t res = 0;
@@ -1382,8 +1382,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
if (written < 0 || !iov_iter_count(from))
goto out;
- written_buffered = fuse_perform_write(iocb, mapping, from,
- iocb->ki_pos);
+ written_buffered = fuse_perform_write(iocb, from);
if (written_buffered < 0) {
err = written_buffered;
goto out;
@@ -1403,7 +1402,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
written += written_buffered;
iocb->ki_pos += written_buffered;
} else {
- written = fuse_perform_write(iocb, mapping, from, iocb->ki_pos);
+ written = fuse_perform_write(iocb, from);
}
out:
inode_unlock(inode);
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
linux-mm@kvack.org, Andreas Gruenbacher <agruenba@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
cluster-devel@redhat.com, Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, Xiubo Li <xiubli@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, Anna Schumaker <anna@kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [f2fs-dev] [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write
Date: Wed, 24 May 2023 08:38:10 +0200 [thread overview]
Message-ID: <20230524063810.1595778-12-hch@lst.de> (raw)
In-Reply-To: <20230524063810.1595778-1-hch@lst.de>
pos is always equal to iocb->ki_pos, and mapping is always equal to
iocb->ki_filp->f_mapping.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
fs/fuse/file.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 90d587a7bdf813..bf48aae49daf56 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1280,13 +1280,13 @@ static inline unsigned int fuse_wr_pages(loff_t pos, size_t len,
max_pages);
}
-static ssize_t fuse_perform_write(struct kiocb *iocb,
- struct address_space *mapping,
- struct iov_iter *ii, loff_t pos)
+static ssize_t fuse_perform_write(struct kiocb *iocb, struct iov_iter *ii)
{
+ struct address_space *mapping = iocb->ki_filp->f_mapping;
struct inode *inode = mapping->host;
struct fuse_conn *fc = get_fuse_conn(inode);
struct fuse_inode *fi = get_fuse_inode(inode);
+ loff_t pos = iocb->ki_pos;
int err = 0;
ssize_t res = 0;
@@ -1382,8 +1382,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
if (written < 0 || !iov_iter_count(from))
goto out;
- written_buffered = fuse_perform_write(iocb, mapping, from,
- iocb->ki_pos);
+ written_buffered = fuse_perform_write(iocb, from);
if (written_buffered < 0) {
err = written_buffered;
goto out;
@@ -1403,7 +1402,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
written += written_buffered;
iocb->ki_pos += written_buffered;
} else {
- written = fuse_perform_write(iocb, mapping, from, iocb->ki_pos);
+ written = fuse_perform_write(iocb, from);
}
out:
inode_unlock(inode);
--
2.39.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write
Date: Wed, 24 May 2023 08:38:10 +0200 [thread overview]
Message-ID: <20230524063810.1595778-12-hch@lst.de> (raw)
In-Reply-To: <20230524063810.1595778-1-hch@lst.de>
pos is always equal to iocb->ki_pos, and mapping is always equal to
iocb->ki_filp->f_mapping.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
fs/fuse/file.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 90d587a7bdf813..bf48aae49daf56 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1280,13 +1280,13 @@ static inline unsigned int fuse_wr_pages(loff_t pos, size_t len,
max_pages);
}
-static ssize_t fuse_perform_write(struct kiocb *iocb,
- struct address_space *mapping,
- struct iov_iter *ii, loff_t pos)
+static ssize_t fuse_perform_write(struct kiocb *iocb, struct iov_iter *ii)
{
+ struct address_space *mapping = iocb->ki_filp->f_mapping;
struct inode *inode = mapping->host;
struct fuse_conn *fc = get_fuse_conn(inode);
struct fuse_inode *fi = get_fuse_inode(inode);
+ loff_t pos = iocb->ki_pos;
int err = 0;
ssize_t res = 0;
@@ -1382,8 +1382,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
if (written < 0 || !iov_iter_count(from))
goto out;
- written_buffered = fuse_perform_write(iocb, mapping, from,
- iocb->ki_pos);
+ written_buffered = fuse_perform_write(iocb, from);
if (written_buffered < 0) {
err = written_buffered;
goto out;
@@ -1403,7 +1402,7 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
written += written_buffered;
iocb->ki_pos += written_buffered;
} else {
- written = fuse_perform_write(iocb, mapping, from, iocb->ki_pos);
+ written = fuse_perform_write(iocb, from);
}
out:
inode_unlock(inode);
--
2.39.2
next prev parent reply other threads:[~2023-05-24 6:40 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 6:37 cleanup the filemap / direct I/O interaction v2 Christoph Hellwig
2023-05-24 6:37 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:37 ` [f2fs-dev] " Christoph Hellwig
2023-05-24 6:38 ` [PATCH 01/11] backing_dev: remove current->backing_dev_info Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-24 14:50 ` Darrick J. Wong
2023-05-24 14:50 ` [Cluster-devel] " Darrick J. Wong
2023-05-24 14:50 ` [f2fs-dev] " Darrick J. Wong
2023-05-30 6:56 ` Hannes Reinecke
2023-05-30 6:56 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:56 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 02/11] iomap: update ki_pos a little later in iomap_dio_complete Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 6:57 ` Hannes Reinecke
2023-05-30 6:57 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:57 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 03/11] filemap: update ki_pos in generic_perform_write Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 6:57 ` Hannes Reinecke
2023-05-30 6:57 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:57 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 04/11] filemap: add a kiocb_write_and_wait helper Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 6:58 ` Hannes Reinecke
2023-05-30 6:58 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:58 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 05/11] filemap: add a kiocb_invalidate_pages helper Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 6:59 ` Hannes Reinecke
2023-05-30 6:59 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:59 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 06/11] filemap: add a kiocb_invalidate_post_direct_write helper Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 6:59 ` Hannes Reinecke
2023-05-30 6:59 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 6:59 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 07/11] iomap: update ki_pos in iomap_file_buffered_write Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-25 16:02 ` Andreas Gruenbacher
2023-05-25 16:02 ` [Cluster-devel] " Andreas Gruenbacher
2023-05-25 16:02 ` Andreas Gruenbacher
2023-05-30 7:00 ` Hannes Reinecke
2023-05-30 7:00 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 7:00 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 08/11] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 7:02 ` Hannes Reinecke
2023-05-30 7:02 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 7:02 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 09/11] fs: factor out a direct_write_fallback helper Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-24 7:00 ` Miklos Szeredi
2023-05-24 7:00 ` [Cluster-devel] " Miklos Szeredi
2023-05-24 7:00 ` [f2fs-dev] " Miklos Szeredi via Linux-f2fs-devel
2023-05-25 10:05 ` Christoph Hellwig
2023-05-25 10:05 ` [Cluster-devel] " Christoph Hellwig
2023-05-25 10:05 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 7:03 ` Hannes Reinecke
2023-05-30 7:03 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 7:03 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` [PATCH 10/11] fuse: update ki_pos in fuse_perform_write Christoph Hellwig
2023-05-24 6:38 ` [Cluster-devel] " Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-24 7:07 ` Miklos Szeredi
2023-05-24 7:07 ` [Cluster-devel] " Miklos Szeredi
2023-05-24 7:07 ` [f2fs-dev] " Miklos Szeredi via Linux-f2fs-devel
2023-05-25 10:09 ` Christoph Hellwig
2023-05-25 10:09 ` [Cluster-devel] " Christoph Hellwig
2023-05-25 10:09 ` [f2fs-dev] " Christoph Hellwig
2023-05-30 7:04 ` Hannes Reinecke
2023-05-30 7:04 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 7:04 ` [f2fs-dev] " Hannes Reinecke
2023-05-24 6:38 ` Christoph Hellwig [this message]
2023-05-24 6:38 ` [Cluster-devel] [PATCH 11/11] fuse: drop redundant arguments to fuse_perform_write Christoph Hellwig
2023-05-24 6:38 ` [f2fs-dev] " Christoph Hellwig
2023-05-24 7:09 ` Miklos Szeredi
2023-05-24 7:09 ` [Cluster-devel] " Miklos Szeredi
2023-05-24 7:09 ` [f2fs-dev] " Miklos Szeredi via Linux-f2fs-devel
2023-05-30 7:04 ` Hannes Reinecke
2023-05-30 7:04 ` [Cluster-devel] " Hannes Reinecke
2023-05-30 7:04 ` [f2fs-dev] " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524063810.1595778-12-hch@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=chao@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=idryomov@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@hammerspace.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.