All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	Phillip Potter <phil@philpotter.co.uk>, Coly Li <colyli@suse.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	linux-um@lists.infradead.org, linux-scsi@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-nvme@lists.infradead.org,
	Phillip Potter <phil@philpotter.co.uk>, Chris Mason <clm@fb.com>,
	dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Pavel Machek <pavel@ucw.cz>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	Richard Weinberger <richard@nod.at>,
	linux-pm@vger.kernel.org, linux-um@lists.infradead.org,
	Josef Bacik <josef@toxicpanda.com>, Coly Li <colyli@suse.de>,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	Phillip Potter <phil@philpotter.co.uk>, Coly Li <colyli@suse.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	linux-um@lists.infradead.org, linux-scsi@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
	Josef Bacik <josef@toxicpanda.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	Phillip Potter <phil@philpotter.co.uk>, Coly Li <colyli@suse.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	linux-um@lists.infradead.org, linux-scsi@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-nvme@lists.infradead.org,
	Phillip Potter <phil@philpotter.co.uk>, Chris Mason <clm@fb.com>,
	dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Pavel Machek <pavel@ucw.cz>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	Richard Weinberger <richard@nod.at>,
	linux-pm@vger.kernel.org, linux-um@lists.infradead.org,
	Josef Bacik <josef@toxicpanda.com>, Coly Li <colyli@suse.de>,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-btrfs@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-nvme@lists.infradead.org,
	Phillip Potter <phil@philpotter.co.uk>, Chris Mason <clm@fb.com>,
	dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Pavel Machek <pavel@ucw.cz>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Jack Wang <jinpu.wang@ionos.com>,
	linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	Richard Weinberger <richard@nod.at>,
	linux-pm@vger.kernel.org, linux-um@lists.infradead.org,
	Josef Bacik <josef@toxicpanda.com>, Coly Li <colyli@suse.de>,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux
Subject: Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags
Date: Wed, 7 Jun 2023 14:47:06 +0200	[thread overview]
Message-ID: <20230607-bekannt-sonnig-c881b3228862@brauner> (raw)
In-Reply-To: <20230607121658.GA13632@lst.de>

On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > > The only overlap between the block open flags mapped into the fmode_t and
> > > other uses of fmode_t are FMODE_READ and FMODE_WRITE.  Define a new
> > 
> > and FMODE_EXCL afaict
> 
> FMODE_EXCL isn't used outside the block layer and removed in the last
> patch.
> 
> > > +blk_mode_t file_to_blk_mode(struct file *file)
> > > +{
> > > +	blk_mode_t mode = 0;
> > > +
> > > +	if (file->f_mode & FMODE_READ)
> > > +		mode |= BLK_OPEN_READ;
> > > +	if (file->f_mode & FMODE_WRITE)
> > > +		mode |= BLK_OPEN_WRITE;
> > > +	if (file->f_mode & FMODE_EXCL)
> > > +		mode |= BLK_OPEN_EXCL;
> > > +	if ((file->f_flags & O_ACCMODE) == 3)
> > 
> > I really don't like magic numbers like this.
> 
> I don't like them either, but this is just moved around and not new.
> 
> > Groan, O_RDONLY being defined as 0 strikes again...
> > Becuase of this quirk we internally map
> > 
> > O_RDONLY(0) -> FMODE_READ(1)
> > O_WRONLY(1) -> FMODE_WRITE(2)
> > O_RDWR(3)   -> (FMODE_READ | FMODE_WRITE)
> 
> O_RDWR is 2.

Yeah, that was a typo. See the other mail I sent right after:
https://lore.kernel.org/all/20230607-kribbeln-dilettanten-b901b57dd962@brauner

> 
> > so checking for the raw 3 here is confusing in addition to being a magic
> > number as it could give the impression that what's checked here is
> > (O_WRONLY | O_RDWR) which doesn't make sense...
> 
> Well, that is exactly what we check for.  This is a 30-ish year old
> quirk only used in the floppy driver.

Ugh, it's f_flags. I misread that as f_mode...

This is rather ugly. Then please, make it explicit and check for
== (O_WRONLY | O_RDWR) and leave a brief comment.

Anything's better than that raw 3 in there. We just had fun with
figuring out why there was a raw coredump in fs/coredump.c 30 years
later.

  reply	other threads:[~2023-06-07 12:48 UTC|newest]

Thread overview: 750+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06  7:39 decouple block open flags from fmode_t Christoph Hellwig
2023-06-06  7:39 ` Christoph Hellwig
2023-06-06  7:39 ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39 ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39 ` Christoph Hellwig
2023-06-06  7:39 ` Christoph Hellwig
2023-06-06  7:39 ` [PATCH 01/31] block: also call ->open for incremental partition opens Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  8:14   ` Christian Brauner
2023-06-07  8:14     ` Christian Brauner
2023-06-07  8:14     ` [dm-devel] " Christian Brauner
2023-06-07  8:14     ` Christian Brauner
2023-06-07  8:14     ` Christian Brauner
2023-06-07  8:14     ` [f2fs-dev] " Christian Brauner
2023-06-07  8:32     ` Christoph Hellwig
2023-06-07  8:32       ` Christoph Hellwig
2023-06-07  8:32       ` [dm-devel] " Christoph Hellwig
2023-06-07  8:32       ` Christoph Hellwig
2023-06-07  8:32       ` Christoph Hellwig
2023-06-07  8:32       ` [f2fs-dev] " Christoph Hellwig
2023-06-07 12:10   ` Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06 22:50   ` Phillip Potter
2023-06-06 22:50     ` Phillip Potter
2023-06-06 22:50     ` [dm-devel] " Phillip Potter
2023-06-06 22:50     ` [f2fs-dev] " Phillip Potter
2023-06-06 22:50     ` Phillip Potter
2023-06-06 22:50     ` Phillip Potter
2023-06-07  8:16   ` Christian Brauner
2023-06-07  8:16     ` Christian Brauner
2023-06-07  8:16     ` [dm-devel] " Christian Brauner
2023-06-07  8:16     ` Christian Brauner
2023-06-07  8:16     ` Christian Brauner
2023-06-07  8:16     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:10   ` Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` Hannes Reinecke
2023-06-07 12:10     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06 22:54   ` Phillip Potter
2023-06-06 22:54     ` Phillip Potter
2023-06-06 22:54     ` [dm-devel] " Phillip Potter
2023-06-06 22:54     ` [f2fs-dev] " Phillip Potter
2023-06-06 22:54     ` Phillip Potter
2023-06-06 22:54     ` Phillip Potter
2023-06-07  8:17   ` Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` [dm-devel] " Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:11   ` Hannes Reinecke
2023-06-07 12:11     ` Hannes Reinecke
2023-06-07 12:11     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:11     ` Hannes Reinecke
2023-06-07 12:11     ` Hannes Reinecke
2023-06-07 12:11     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06 22:56   ` Phillip Potter
2023-06-06 22:56     ` Phillip Potter
2023-06-06 22:56     ` [dm-devel] " Phillip Potter
2023-06-06 22:56     ` [f2fs-dev] " Phillip Potter
2023-06-06 22:56     ` Phillip Potter
2023-06-06 22:56     ` Phillip Potter
2023-06-07  8:17   ` Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` [dm-devel] " Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` Christian Brauner
2023-06-07  8:17     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:12   ` Hannes Reinecke
2023-06-07 12:12     ` Hannes Reinecke
2023-06-07 12:12     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:12     ` Hannes Reinecke
2023-06-07 12:12     ` Hannes Reinecke
2023-06-07 12:12     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06 22:59   ` Phillip Potter
2023-06-06 22:59     ` Phillip Potter
2023-06-06 22:59     ` [dm-devel] " Phillip Potter
2023-06-06 22:59     ` [f2fs-dev] " Phillip Potter
2023-06-06 22:59     ` Phillip Potter
2023-06-06 22:59     ` Phillip Potter
2023-06-07  8:19   ` Christian Brauner
2023-06-07  8:19     ` Christian Brauner
2023-06-07  8:19     ` [dm-devel] " Christian Brauner
2023-06-07  8:19     ` Christian Brauner
2023-06-07  8:19     ` Christian Brauner
2023-06-07  8:19     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:13   ` Hannes Reinecke
2023-06-07 12:13     ` Hannes Reinecke
2023-06-07 12:13     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:13     ` Hannes Reinecke
2023-06-07 12:13     ` Hannes Reinecke
2023-06-07 12:13     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:20     ` Christoph Hellwig
2023-06-07 12:20       ` Christoph Hellwig
2023-06-07 12:20       ` [dm-devel] " Christoph Hellwig
2023-06-07 12:20       ` Christoph Hellwig
2023-06-07 12:20       ` Christoph Hellwig
2023-06-07 12:20       ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39 ` [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06 23:00   ` Phillip Potter
2023-06-06 23:00     ` Phillip Potter
2023-06-06 23:00     ` [dm-devel] " Phillip Potter
2023-06-06 23:00     ` [f2fs-dev] " Phillip Potter
2023-06-06 23:00     ` Phillip Potter
2023-06-06 23:00     ` Phillip Potter
2023-06-08  8:41     ` Christoph Hellwig
2023-06-08  8:41       ` Christoph Hellwig
2023-06-08  8:41       ` Christoph Hellwig
2023-06-08  8:41       ` [dm-devel] " Christoph Hellwig
2023-06-08  8:41       ` Christoph Hellwig
2023-06-08  8:41       ` [f2fs-dev] " Christoph Hellwig
2023-06-08  8:47       ` Phillip Potter
2023-06-08  8:47         ` Phillip Potter
2023-06-08  8:47         ` [dm-devel] " Phillip Potter
2023-06-08  8:47         ` [f2fs-dev] " Phillip Potter
2023-06-08  8:47         ` Phillip Potter
2023-06-08  8:47         ` Phillip Potter
2023-06-08  9:04         ` Christoph Hellwig
2023-06-08  9:04           ` Christoph Hellwig
2023-06-08  9:04           ` Christoph Hellwig
2023-06-08  9:04           ` [dm-devel] " Christoph Hellwig
2023-06-08  9:04           ` Christoph Hellwig
2023-06-08  9:04           ` [f2fs-dev] " Christoph Hellwig
2023-06-08  9:44           ` Phillip Potter
2023-06-08  9:44             ` Phillip Potter
2023-06-08  9:44             ` [dm-devel] " Phillip Potter
2023-06-08  9:44             ` [f2fs-dev] " Phillip Potter
2023-06-08  9:44             ` Phillip Potter
2023-06-08  9:44             ` Phillip Potter
2023-06-07  8:20   ` Christian Brauner
2023-06-07  8:20     ` Christian Brauner
2023-06-07  8:20     ` [dm-devel] " Christian Brauner
2023-06-07  8:20     ` Christian Brauner
2023-06-07  8:20     ` Christian Brauner
2023-06-07  8:20     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:14   ` Hannes Reinecke
2023-06-07 12:14     ` Hannes Reinecke
2023-06-07 12:14     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:14     ` Hannes Reinecke
2023-06-07 12:14     ` Hannes Reinecke
2023-06-07 12:14     ` [f2fs-dev] " Hannes Reinecke
2023-06-27  5:41   ` Guenter Roeck
2023-06-27  5:41     ` Guenter Roeck
2023-06-27  5:41     ` Guenter Roeck
2023-06-27  5:41     ` [dm-devel] " Guenter Roeck
2023-06-27  5:41     ` Guenter Roeck
2023-06-27  5:41     ` [f2fs-dev] " Guenter Roeck
2023-06-06  7:39 ` [PATCH 07/31] block: pass a gendisk on bdev_check_media_change Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-07  8:25   ` Christian Brauner
2023-06-07  8:25     ` Christian Brauner
2023-06-07  8:25     ` [dm-devel] " Christian Brauner
2023-06-07  8:25     ` Christian Brauner
2023-06-07  8:25     ` Christian Brauner
2023-06-07  8:25     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:15   ` Hannes Reinecke
2023-06-07 12:15     ` Hannes Reinecke
2023-06-07 12:15     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:15     ` Hannes Reinecke
2023-06-07 12:15     ` Hannes Reinecke
2023-06-07 12:15     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-07  8:26   ` Christian Brauner
2023-06-07  8:26     ` Christian Brauner
2023-06-07  8:26     ` [dm-devel] " Christian Brauner
2023-06-07  8:26     ` Christian Brauner
2023-06-07  8:26     ` Christian Brauner
2023-06-07  8:26     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:19   ` Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:21     ` Christoph Hellwig
2023-06-07 12:21       ` Christoph Hellwig
2023-06-07 12:21       ` [dm-devel] " Christoph Hellwig
2023-06-07 12:21       ` Christoph Hellwig
2023-06-07 12:21       ` Christoph Hellwig
2023-06-07 12:21       ` [f2fs-dev] " Christoph Hellwig
2023-06-07 13:18       ` Hannes Reinecke
2023-06-07 13:18         ` Hannes Reinecke
2023-06-07 13:18         ` [dm-devel] " Hannes Reinecke
2023-06-07 13:18         ` Hannes Reinecke
2023-06-07 13:18         ` Hannes Reinecke
2023-06-07 13:18         ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 09/31] block: pass a gendisk to ->open Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  8:34   ` Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` [dm-devel] " Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:42   ` Jinpu Wang
2023-06-07  9:42     ` Jinpu Wang
2023-06-07  9:42     ` [dm-devel] " Jinpu Wang
2023-06-07  9:42     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:42     ` Jinpu Wang
2023-06-07  9:42     ` Jinpu Wang
2023-06-07 12:19   ` Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` Hannes Reinecke
2023-06-07 12:19     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [PATCH 10/31] block: remove the unused mode argument to ->release Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-07  8:34   ` Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` [dm-devel] " Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` Christian Brauner
2023-06-07  8:34     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:41   ` Jinpu Wang
2023-06-07  9:41     ` Jinpu Wang
2023-06-07  9:41     ` [dm-devel] " Jinpu Wang
2023-06-07  9:41     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:41     ` Jinpu Wang
2023-06-07  9:41     ` Jinpu Wang
2023-06-07 12:20   ` Hannes Reinecke
2023-06-07 12:20     ` Hannes Reinecke
2023-06-07 12:20     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:20     ` Hannes Reinecke
2023-06-07 12:20     ` Hannes Reinecke
2023-06-07 12:20     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 11/31] block: rename blkdev_close to blkdev_release Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  8:35   ` Christian Brauner
2023-06-07  8:35     ` Christian Brauner
2023-06-07  8:35     ` [dm-devel] " Christian Brauner
2023-06-07  8:35     ` Christian Brauner
2023-06-07  8:35     ` [f2fs-dev] " Christian Brauner
2023-06-07  8:35     ` Christian Brauner
2023-06-07 12:21   ` Hannes Reinecke
2023-06-07 12:21     ` Hannes Reinecke
2023-06-07 12:21     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:21     ` Hannes Reinecke
2023-06-07 12:21     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:21     ` Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 12/31] swsusp: don't pass a stack address to blkdev_get_by_path Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07 12:22   ` Hannes Reinecke
2023-06-07 12:22     ` Hannes Reinecke
2023-06-07 12:22     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:22     ` Hannes Reinecke
2023-06-07 12:22     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:22     ` Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 13/31] bcache: " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07 12:23   ` Hannes Reinecke
2023-06-07 12:23     ` Hannes Reinecke
2023-06-07 12:23     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:23     ` Hannes Reinecke
2023-06-07 12:23     ` Hannes Reinecke
2023-06-07 12:23     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  8:39   ` Christian Brauner
2023-06-07  8:39     ` Christian Brauner
2023-06-07  8:39     ` [dm-devel] " Christian Brauner
2023-06-07  8:39     ` Christian Brauner
2023-06-07  8:39     ` Christian Brauner
2023-06-07  8:39     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:38   ` Jinpu Wang
2023-06-07  9:38     ` Jinpu Wang
2023-06-07  9:38     ` [dm-devel] " Jinpu Wang
2023-06-07  9:38     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:38     ` Jinpu Wang
2023-06-07  9:38     ` Jinpu Wang
2023-06-07 12:24   ` Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-07 12:24     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-07 12:24     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 15/31] btrfs: " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  8:40   ` Christian Brauner
2023-06-07  8:40     ` Christian Brauner
2023-06-07  8:40     ` [dm-devel] " Christian Brauner
2023-06-07  8:40     ` Christian Brauner
2023-06-07  8:40     ` Christian Brauner
2023-06-07  8:40     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:24   ` Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-07 12:24     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-07 12:24     ` Hannes Reinecke
2023-06-07 12:24     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 13:32   ` David Sterba
2023-06-07 13:32     ` David Sterba
2023-06-07 13:32     ` [dm-devel] " David Sterba
2023-06-07 13:32     ` David Sterba
2023-06-07 13:32     ` [f2fs-dev] " David Sterba
2023-06-07 13:32     ` David Sterba
2023-06-06  7:39 ` [f2fs-dev] [PATCH 16/31] block: use the holder as indication for exclusive opens Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:49   ` [f2fs-dev] " Christian Brauner
2023-06-07  8:49     ` Christian Brauner
2023-06-07  8:49     ` [dm-devel] " Christian Brauner
2023-06-07  8:49     ` Christian Brauner
2023-06-07  8:49     ` Christian Brauner
2023-06-07  8:49     ` Christian Brauner
2023-06-07  9:40   ` Jinpu Wang
2023-06-07  9:40     ` Jinpu Wang
2023-06-07  9:40     ` [dm-devel] " Jinpu Wang
2023-06-07  9:40     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:40     ` Jinpu Wang
2023-06-07  9:40     ` Jinpu Wang
2023-06-07 12:29   ` Hannes Reinecke
2023-06-07 12:29     ` Hannes Reinecke
2023-06-07 12:29     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:29     ` Hannes Reinecke
2023-06-07 12:29     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 12:29     ` Hannes Reinecke
2023-06-07 13:53   ` David Sterba
2023-06-07 13:53     ` David Sterba
2023-06-07 13:53     ` [dm-devel] " David Sterba
2023-06-07 13:53     ` David Sterba
2023-06-07 13:53     ` [f2fs-dev] " David Sterba
2023-06-07 13:53     ` David Sterba
2023-06-06  7:39 ` [PATCH 17/31] block: add a sb_open_mode helper Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` [f2fs-dev] " Christoph Hellwig
2023-06-07  8:55   ` Christian Brauner
2023-06-07  8:55     ` Christian Brauner
2023-06-07  8:55     ` [dm-devel] " Christian Brauner
2023-06-07  8:55     ` Christian Brauner
2023-06-07  8:55     ` Christian Brauner
2023-06-07  8:55     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:30   ` Hannes Reinecke
2023-06-07 12:30     ` Hannes Reinecke
2023-06-07 12:30     ` [dm-devel] " Hannes Reinecke
2023-06-07 12:30     ` Hannes Reinecke
2023-06-07 12:30     ` Hannes Reinecke
2023-06-07 12:30     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 18/31] fs: remove sb->s_mode Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:56   ` Christian Brauner
2023-06-07  8:56     ` Christian Brauner
2023-06-07  8:56     ` [dm-devel] " Christian Brauner
2023-06-07  8:56     ` Christian Brauner
2023-06-07  8:56     ` Christian Brauner
2023-06-07  8:56     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:01   ` Hannes Reinecke
2023-06-07 13:01     ` Hannes Reinecke
2023-06-07 13:01     ` Hannes Reinecke
2023-06-07 13:01     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:01     ` Hannes Reinecke
2023-06-07 13:01     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:57   ` Christian Brauner
2023-06-07  8:57     ` Christian Brauner
2023-06-07  8:57     ` [dm-devel] " Christian Brauner
2023-06-07  8:57     ` [f2fs-dev] " Christian Brauner
2023-06-07  8:57     ` Christian Brauner
2023-06-07  8:57     ` Christian Brauner
2023-06-07 13:02   ` Hannes Reinecke
2023-06-07 13:02     ` Hannes Reinecke
2023-06-07 13:02     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:02     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 13:02     ` Hannes Reinecke
2023-06-07 13:02     ` Hannes Reinecke
2023-06-08  1:18   ` Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` [dm-devel] " Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` [f2fs-dev] " Martin K. Petersen
2023-06-06  7:39 ` [f2fs-dev] [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:58   ` Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` [dm-devel] " Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:04   ` Hannes Reinecke
2023-06-07 13:04     ` Hannes Reinecke
2023-06-07 13:04     ` Hannes Reinecke
2023-06-07 13:04     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:04     ` Hannes Reinecke
2023-06-07 13:04     ` [f2fs-dev] " Hannes Reinecke
2023-06-08  1:17   ` Martin K. Petersen
2023-06-08  1:17     ` Martin K. Petersen
2023-06-08  1:17     ` [dm-devel] " Martin K. Petersen
2023-06-08  1:17     ` Martin K. Petersen
2023-06-08  1:17     ` Martin K. Petersen
2023-06-08  1:17     ` [f2fs-dev] " Martin K. Petersen
2023-06-06  7:39 ` [f2fs-dev] [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:58   ` Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` [dm-devel] " Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` Christian Brauner
2023-06-07  8:58     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:05   ` Hannes Reinecke
2023-06-07 13:05     ` Hannes Reinecke
2023-06-07 13:05     ` Hannes Reinecke
2023-06-07 13:05     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:05     ` Hannes Reinecke
2023-06-07 13:05     ` [f2fs-dev] " Hannes Reinecke
2023-06-08  1:18   ` Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` [dm-devel] " Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` Martin K. Petersen
2023-06-08  1:18     ` [f2fs-dev] " Martin K. Petersen
2023-06-06  7:39 ` [f2fs-dev] [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  8:59   ` Christian Brauner
2023-06-07  8:59     ` Christian Brauner
2023-06-07  8:59     ` [dm-devel] " Christian Brauner
2023-06-07  8:59     ` Christian Brauner
2023-06-07  8:59     ` Christian Brauner
2023-06-07  8:59     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:06   ` Hannes Reinecke
2023-06-07 13:06     ` Hannes Reinecke
2023-06-07 13:06     ` Hannes Reinecke
2023-06-07 13:06     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:06     ` Hannes Reinecke
2023-06-07 13:06     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 23/31] mtd: block: use a simple bool to track open for write Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  8:24   ` Richard Weinberger
2023-06-06  8:24     ` Richard Weinberger
2023-06-06  8:24     ` [dm-devel] " Richard Weinberger
2023-06-06  8:24     ` [f2fs-dev] " Richard Weinberger
2023-06-06  8:24     ` Richard Weinberger
2023-06-06  8:24     ` Richard Weinberger
2023-06-07  9:00   ` Christian Brauner
2023-06-07  9:00     ` Christian Brauner
2023-06-07  9:00     ` [dm-devel] " Christian Brauner
2023-06-07  9:00     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:00     ` Christian Brauner
2023-06-07  9:00     ` Christian Brauner
2023-06-07 13:07   ` Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-07 13:07     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-07 13:07     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 24/31] rnbd-srv: replace sess->open_flags with a "bool readonly" Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:01   ` Christian Brauner
2023-06-07  9:01     ` Christian Brauner
2023-06-07  9:01     ` [dm-devel] " Christian Brauner
2023-06-07  9:01     ` Christian Brauner
2023-06-07  9:01     ` Christian Brauner
2023-06-07  9:01     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:43   ` Jinpu Wang
2023-06-07  9:43     ` Jinpu Wang
2023-06-07  9:43     ` [dm-devel] " Jinpu Wang
2023-06-07  9:43     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:43     ` Jinpu Wang
2023-06-07  9:43     ` Jinpu Wang
2023-06-07 13:07   ` Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-07 13:07     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:07     ` Hannes Reinecke
2023-06-07 13:07     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 25/31] ubd: remove commented out code in ubd_open Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  8:20   ` Richard Weinberger
2023-06-06  8:20     ` Richard Weinberger
2023-06-06  8:20     ` [dm-devel] " Richard Weinberger
2023-06-06  8:20     ` [f2fs-dev] " Richard Weinberger
2023-06-06  8:20     ` Richard Weinberger
2023-06-06  8:20     ` Richard Weinberger
2023-06-07  9:02   ` Christian Brauner
2023-06-07  9:02     ` Christian Brauner
2023-06-07  9:02     ` [dm-devel] " Christian Brauner
2023-06-07  9:02     ` Christian Brauner
2023-06-07  9:02     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:02     ` Christian Brauner
2023-06-07 13:08   ` Hannes Reinecke
2023-06-07 13:08     ` Hannes Reinecke
2023-06-07 13:08     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:08     ` Hannes Reinecke
2023-06-07 13:08     ` [f2fs-dev] " Hannes Reinecke
2023-06-07 13:08     ` Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 26/31] block: move a few internal definitions out of blkdev.h Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:03   ` Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` [dm-devel] " Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:09   ` Hannes Reinecke
2023-06-07 13:09     ` Hannes Reinecke
2023-06-07 13:09     ` Hannes Reinecke
2023-06-07 13:09     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:09     ` Hannes Reinecke
2023-06-07 13:09     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 27/31] block: remove unused fmode_t arguments from ioctl handlers Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:03   ` Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` [dm-devel] " Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` Christian Brauner
2023-06-07  9:03     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:10   ` Hannes Reinecke
2023-06-07 13:10     ` Hannes Reinecke
2023-06-07 13:10     ` Hannes Reinecke
2023-06-07 13:10     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:10     ` Hannes Reinecke
2023-06-07 13:10     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:21   ` Christian Brauner
2023-06-07  9:21     ` Christian Brauner
2023-06-07  9:21     ` [dm-devel] " Christian Brauner
2023-06-07  9:21     ` Christian Brauner
2023-06-07  9:21     ` Christian Brauner
2023-06-07  9:21     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:32     ` Christian Brauner
2023-06-07  9:32       ` Christian Brauner
2023-06-07  9:32       ` [dm-devel] " Christian Brauner
2023-06-07  9:32       ` Christian Brauner
2023-06-07  9:32       ` Christian Brauner
2023-06-07  9:32       ` [f2fs-dev] " Christian Brauner
2023-06-07 12:16     ` Christoph Hellwig
2023-06-07 12:16       ` Christoph Hellwig
2023-06-07 12:16       ` [dm-devel] " Christoph Hellwig
2023-06-07 12:16       ` Christoph Hellwig
2023-06-07 12:16       ` Christoph Hellwig
2023-06-07 12:16       ` [f2fs-dev] " Christoph Hellwig
2023-06-07 12:47       ` Christian Brauner [this message]
2023-06-07 12:47         ` Christian Brauner
2023-06-07 12:47         ` [dm-devel] " Christian Brauner
2023-06-07 12:47         ` Christian Brauner
2023-06-07 12:47         ` Christian Brauner
2023-06-07 12:47         ` [f2fs-dev] " Christian Brauner
2023-06-07  9:45   ` Jinpu Wang
2023-06-07  9:45     ` Jinpu Wang
2023-06-07  9:45     ` [dm-devel] " Jinpu Wang
2023-06-07  9:45     ` [f2fs-dev] " Jinpu Wang via Linux-f2fs-devel
2023-06-07  9:45     ` Jinpu Wang
2023-06-07  9:45     ` Jinpu Wang
2023-06-06  7:39 ` [f2fs-dev] [PATCH 29/31] block: always use I_BDEV on file->f_mapping->host to find the bdev Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:23   ` Christian Brauner
2023-06-07  9:23     ` Christian Brauner
2023-06-07  9:23     ` [dm-devel] " Christian Brauner
2023-06-07  9:23     ` Christian Brauner
2023-06-07  9:23     ` Christian Brauner
2023-06-07  9:23     ` [f2fs-dev] " Christian Brauner
2023-06-07 13:11   ` Hannes Reinecke
2023-06-07 13:11     ` Hannes Reinecke
2023-06-07 13:11     ` Hannes Reinecke
2023-06-07 13:11     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:11     ` Hannes Reinecke
2023-06-07 13:11     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 30/31] block: store the holder in file->private_data Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-07  9:24   ` Christian Brauner
2023-06-07  9:24     ` Christian Brauner
2023-06-07  9:24     ` [dm-devel] " Christian Brauner
2023-06-07  9:24     ` Christian Brauner
2023-06-07  9:24     ` Christian Brauner
2023-06-07  9:24     ` [f2fs-dev] " Christian Brauner
2023-06-07 12:18     ` Christoph Hellwig
2023-06-07 12:18       ` Christoph Hellwig
2023-06-07 12:18       ` [dm-devel] " Christoph Hellwig
2023-06-07 12:18       ` Christoph Hellwig
2023-06-07 12:18       ` Christoph Hellwig
2023-06-07 12:18       ` [f2fs-dev] " Christoph Hellwig
2023-06-07 13:14   ` Hannes Reinecke
2023-06-07 13:14     ` Hannes Reinecke
2023-06-07 13:14     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:14     ` Hannes Reinecke
2023-06-07 13:14     ` Hannes Reinecke
2023-06-07 13:14     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  7:39 ` [f2fs-dev] [PATCH 31/31] fs: remove the now unused FMODE_* flags Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` Christoph Hellwig
2023-06-06  7:39   ` [dm-devel] " Christoph Hellwig
2023-06-07  9:25   ` Christian Brauner
2023-06-07  9:25     ` Christian Brauner
2023-06-07  9:25     ` [dm-devel] " Christian Brauner
2023-06-07  9:25     ` [f2fs-dev] " Christian Brauner
2023-06-07  9:25     ` Christian Brauner
2023-06-07  9:25     ` Christian Brauner
2023-06-07 13:15   ` Hannes Reinecke
2023-06-07 13:15     ` Hannes Reinecke
2023-06-07 13:15     ` Hannes Reinecke
2023-06-07 13:15     ` [dm-devel] " Hannes Reinecke
2023-06-07 13:15     ` Hannes Reinecke
2023-06-07 13:15     ` [f2fs-dev] " Hannes Reinecke
2023-06-06  8:27 ` decouple block open flags from fmode_t Christian Brauner
2023-06-06  8:27   ` Christian Brauner
2023-06-06  8:27   ` [dm-devel] " Christian Brauner
2023-06-06  8:27   ` Christian Brauner
2023-06-06  8:27   ` Christian Brauner
2023-06-06  8:27   ` [f2fs-dev] " Christian Brauner
2023-06-06  8:40   ` Christoph Hellwig
2023-06-06  8:40     ` Christoph Hellwig
2023-06-06  8:40     ` Christoph Hellwig
2023-06-06  8:40     ` Christoph Hellwig
2023-06-06  8:40     ` [dm-devel] " Christoph Hellwig
2023-06-06  8:40     ` [f2fs-dev] " Christoph Hellwig
2023-06-07  9:27     ` Christian Brauner
2023-06-07  9:27       ` Christian Brauner
2023-06-07  9:27       ` [dm-devel] " Christian Brauner
2023-06-07  9:27       ` Christian Brauner
2023-06-07  9:27       ` Christian Brauner
2023-06-07  9:27       ` [f2fs-dev] " Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607-bekannt-sonnig-c881b3228862@brauner \
    --to=brauner@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=clm@fb.com \
    --cc=colyli@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=dsterba@suse.com \
    --cc=haris.iqbal@ionos.com \
    --cc=hch@lst.de \
    --cc=jinpu.wang@ionos.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=pavel@ucw.cz \
    --cc=phil@philpotter.co.uk \
    --cc=rafael@kernel.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.