From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Kamel Bouhara <kamel.bouhara@bootlin.com> Subject: Re: [PATCH 2/2] power: reset: at91-reset: add sysfs interface to the power on reason Date: Sat, 10 Jun 2023 01:36:59 +0200 [thread overview] Message-ID: <20230609233659.tduea4ls5raaf76e@mercury.elektranox.org> (raw) In-Reply-To: <20230609143912.849995-3-miquel.raynal@bootlin.com> [-- Attachment #1: Type: text/plain, Size: 3190 bytes --] Hi, On Fri, Jun 09, 2023 at 04:39:12PM +0200, Miquel Raynal wrote: > From: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Introduce a list of generic reset sources and use them to export the > power on reason through sysfs. Update the ABI documentation to describe > this new interface. > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > [Miquel Raynal: Follow-up on Kamel's work, 4 years later] > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../testing/sysfs-platform-power-on-reason | 10 +++++ > drivers/power/reset/at91-reset.c | 42 +++++++++++++------ > include/linux/power/power_on_reason.h | 19 +++++++++ > 3 files changed, 59 insertions(+), 12 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-platform-power-on-reason > create mode 100644 include/linux/power/power_on_reason.h > > diff --git a/Documentation/ABI/testing/sysfs-platform-power-on-reason b/Documentation/ABI/testing/sysfs-platform-power-on-reason > new file mode 100644 > index 000000000000..12020d017543 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-power-on-reason > @@ -0,0 +1,10 @@ > +What: /sys/devices/platform/.../power_on_reason > +Date: October 2019 > +KernelVersion: 5.4 That needs to be updated :) > +Contact: Kamel Bouhara <kamel.bouhara@bootlin.com> > +Description: This file shows system power on reason. Possible sources are: > + General system power-on, RTC wakeup, watchdog timeout, software > + reset, user pressed reset button, CPU clock failure, oscillator > + failure, low power mode exit, unknown. > + > + The file is read only. This should list the exact strings generated by the kernel. They are ABI. Also it should be mentioned, that the list might be extended in the future. > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c [...] > diff --git a/include/linux/power/power_on_reason.h b/include/linux/power/power_on_reason.h > new file mode 100644 > index 000000000000..4b92eb0519c4 > --- /dev/null > +++ b/include/linux/power/power_on_reason.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Author: Kamel Bouhra <kamel.bouhara@bootlin.com> > + */ > + > +#ifndef POWER_ON_REASON_H > +#define POWER_ON_REASON_H > + > +#define POWER_ON_REASON_GENERAL "general" What's the difference between "general" and "unknown"? > +#define POWER_ON_REASON_RTC "RTC wakeup" > +#define POWER_ON_REASON_WATCHDOG "watchdog timeout" > +#define POWER_ON_REASON_SOFTWARE "software" "software reset" > +#define POWER_ON_REASON_USER "user" user is quite confusing. This should be something like #define POWER_ON_REASON_RST_BTN "reset button" > +#define POWER_ON_REASON_CPU_FAIL "CPU clock failure" POWER_ON_REASON_CPU_CLK_FAIL > +#define POWER_ON_REASON_XTAL_FAIL "crystal oscillator failure" > +#define POWER_ON_REASON_LOW_POWER "low power exit" when is this reported? > +#define POWER_ON_REASON_UNKNOWN "unknown" > + > +#endif /* POWER_ON_REASON_H */ Greetings, -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] power: reset: at91-reset: add sysfs interface to the power on reason Date: Sat, 10 Jun 2023 01:36:59 +0200 [thread overview] Message-ID: <20230609233659.tduea4ls5raaf76e@mercury.elektranox.org> (raw) In-Reply-To: <20230609143912.849995-3-miquel.raynal@bootlin.com> [-- Attachment #1.1: Type: text/plain, Size: 3190 bytes --] Hi, On Fri, Jun 09, 2023 at 04:39:12PM +0200, Miquel Raynal wrote: > From: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Introduce a list of generic reset sources and use them to export the > power on reason through sysfs. Update the ABI documentation to describe > this new interface. > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > [Miquel Raynal: Follow-up on Kamel's work, 4 years later] > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../testing/sysfs-platform-power-on-reason | 10 +++++ > drivers/power/reset/at91-reset.c | 42 +++++++++++++------ > include/linux/power/power_on_reason.h | 19 +++++++++ > 3 files changed, 59 insertions(+), 12 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-platform-power-on-reason > create mode 100644 include/linux/power/power_on_reason.h > > diff --git a/Documentation/ABI/testing/sysfs-platform-power-on-reason b/Documentation/ABI/testing/sysfs-platform-power-on-reason > new file mode 100644 > index 000000000000..12020d017543 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-power-on-reason > @@ -0,0 +1,10 @@ > +What: /sys/devices/platform/.../power_on_reason > +Date: October 2019 > +KernelVersion: 5.4 That needs to be updated :) > +Contact: Kamel Bouhara <kamel.bouhara@bootlin.com> > +Description: This file shows system power on reason. Possible sources are: > + General system power-on, RTC wakeup, watchdog timeout, software > + reset, user pressed reset button, CPU clock failure, oscillator > + failure, low power mode exit, unknown. > + > + The file is read only. This should list the exact strings generated by the kernel. They are ABI. Also it should be mentioned, that the list might be extended in the future. > diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c [...] > diff --git a/include/linux/power/power_on_reason.h b/include/linux/power/power_on_reason.h > new file mode 100644 > index 000000000000..4b92eb0519c4 > --- /dev/null > +++ b/include/linux/power/power_on_reason.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Author: Kamel Bouhra <kamel.bouhara@bootlin.com> > + */ > + > +#ifndef POWER_ON_REASON_H > +#define POWER_ON_REASON_H > + > +#define POWER_ON_REASON_GENERAL "general" What's the difference between "general" and "unknown"? > +#define POWER_ON_REASON_RTC "RTC wakeup" > +#define POWER_ON_REASON_WATCHDOG "watchdog timeout" > +#define POWER_ON_REASON_SOFTWARE "software" "software reset" > +#define POWER_ON_REASON_USER "user" user is quite confusing. This should be something like #define POWER_ON_REASON_RST_BTN "reset button" > +#define POWER_ON_REASON_CPU_FAIL "CPU clock failure" POWER_ON_REASON_CPU_CLK_FAIL > +#define POWER_ON_REASON_XTAL_FAIL "crystal oscillator failure" > +#define POWER_ON_REASON_LOW_POWER "low power exit" when is this reported? > +#define POWER_ON_REASON_UNKNOWN "unknown" > + > +#endif /* POWER_ON_REASON_H */ Greetings, -- Sebastian [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-09 23:37 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-09 14:39 [PATCH 0/2] Expose reset reason through sysfs Miquel Raynal 2023-06-09 14:39 ` Miquel Raynal 2023-06-09 14:39 ` [PATCH 1/2] power: reset: at91-reset: use driver structure as status parameter Miquel Raynal 2023-06-09 14:39 ` Miquel Raynal 2023-06-09 23:14 ` Sebastian Reichel 2023-06-09 23:14 ` Sebastian Reichel 2023-06-15 14:04 ` Miquel Raynal 2023-06-15 14:04 ` Miquel Raynal 2023-06-09 14:39 ` [PATCH 2/2] power: reset: at91-reset: add sysfs interface to the power on reason Miquel Raynal 2023-06-09 14:39 ` Miquel Raynal 2023-06-09 23:36 ` Sebastian Reichel [this message] 2023-06-09 23:36 ` Sebastian Reichel 2023-06-15 14:29 ` Miquel Raynal 2023-06-15 14:29 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230609233659.tduea4ls5raaf76e@mercury.elektranox.org \ --to=sebastian.reichel@collabora.com \ --cc=alexandre.belloni@bootlin.com \ --cc=claudiu.beznea@microchip.com \ --cc=kamel.bouhara@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=nicolas.ferre@microchip.com \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.