From: Conor Dooley <conor@kernel.org> To: Maksim Kiselev <bigunclemax@gmail.com> Cc: linux-kernel@vger.kernel.org, Vasily Khoruzhick <anarsoul@gmail.com>, Yangtao Li <tiny.windzz@gmail.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: Re: [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller Date: Sat, 10 Jun 2023 15:52:49 +0100 [thread overview] Message-ID: <20230610-rehire-amid-2517f43504c0@spud> (raw) In-Reply-To: <20230610141739.999268-4-bigunclemax@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2693 bytes --] On Sat, Jun 10, 2023 at 05:17:34PM +0300, Maksim Kiselev wrote: > From: Maxim Kiselev <bigunclemax@gmail.com> > > Add a binding for D1/T113s thermal sensor controller. > > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> Why do you have 2 sign-offs that are both you w/ different spellings? Content looks fine to me, other than one commit below. > --- > .../thermal/allwinner,sun8i-a83t-ths.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index fbd4212285e2..001faa37fc27 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -16,6 +16,7 @@ properties: > - allwinner,sun8i-a83t-ths > - allwinner,sun8i-h3-ths > - allwinner,sun8i-r40-ths > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a64-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > @@ -61,6 +62,7 @@ allOf: > compatible: > contains: > enum: > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h6-ths > > @@ -84,7 +86,9 @@ allOf: > properties: > compatible: > contains: > - const: allwinner,sun8i-h3-ths > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun20i-d1-ths > > then: > properties: > @@ -103,6 +107,7 @@ allOf: > enum: > - allwinner,sun8i-h3-ths > - allwinner,sun8i-r40-ths > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a64-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > @@ -159,4 +164,17 @@ examples: > #thermal-sensor-cells = <1>; > }; > > + - | > + thermal-sensor@2009400 { > + compatible = "allwinner,sun20i-d1-ths"; > + reg = <0x02009400 0x400>; > + interrupts = <0 90 0>; > + clocks = <&ccu 0>; > + clock-names = "bus"; > + resets = <&ccu 2>; > + nvmem-cells = <&ths_calibration>; > + nvmem-cell-names = "calibration"; > + #thermal-sensor-cells = <0>; Is this calibration required, or optional, for the d1? Cheers, Conor. > + }; > + > ... > -- > 2.39.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org> To: Maksim Kiselev <bigunclemax@gmail.com> Cc: linux-kernel@vger.kernel.org, Vasily Khoruzhick <anarsoul@gmail.com>, Yangtao Li <tiny.windzz@gmail.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Subject: Re: [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller Date: Sat, 10 Jun 2023 15:52:49 +0100 [thread overview] Message-ID: <20230610-rehire-amid-2517f43504c0@spud> (raw) In-Reply-To: <20230610141739.999268-4-bigunclemax@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2693 bytes --] On Sat, Jun 10, 2023 at 05:17:34PM +0300, Maksim Kiselev wrote: > From: Maxim Kiselev <bigunclemax@gmail.com> > > Add a binding for D1/T113s thermal sensor controller. > > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> Why do you have 2 sign-offs that are both you w/ different spellings? Content looks fine to me, other than one commit below. > --- > .../thermal/allwinner,sun8i-a83t-ths.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index fbd4212285e2..001faa37fc27 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -16,6 +16,7 @@ properties: > - allwinner,sun8i-a83t-ths > - allwinner,sun8i-h3-ths > - allwinner,sun8i-r40-ths > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a64-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > @@ -61,6 +62,7 @@ allOf: > compatible: > contains: > enum: > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h6-ths > > @@ -84,7 +86,9 @@ allOf: > properties: > compatible: > contains: > - const: allwinner,sun8i-h3-ths > + enum: > + - allwinner,sun8i-h3-ths > + - allwinner,sun20i-d1-ths > > then: > properties: > @@ -103,6 +107,7 @@ allOf: > enum: > - allwinner,sun8i-h3-ths > - allwinner,sun8i-r40-ths > + - allwinner,sun20i-d1-ths > - allwinner,sun50i-a64-ths > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > @@ -159,4 +164,17 @@ examples: > #thermal-sensor-cells = <1>; > }; > > + - | > + thermal-sensor@2009400 { > + compatible = "allwinner,sun20i-d1-ths"; > + reg = <0x02009400 0x400>; > + interrupts = <0 90 0>; > + clocks = <&ccu 0>; > + clock-names = "bus"; > + resets = <&ccu 2>; > + nvmem-cells = <&ths_calibration>; > + nvmem-cell-names = "calibration"; > + #thermal-sensor-cells = <0>; Is this calibration required, or optional, for the d1? Cheers, Conor. > + }; > + > ... > -- > 2.39.2 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-10 14:52 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-10 14:17 [PATCH v1 0/3] Add D1/T113s thermal sensor controller support Maksim Kiselev 2023-06-10 14:17 ` Maksim Kiselev 2023-06-10 14:17 ` [PATCH v1 1/3] thermal: sun8i: Add D1/T113s THS " Maksim Kiselev 2023-06-10 14:17 ` Maksim Kiselev 2023-06-10 14:17 ` [PATCH v1 2/3] riscv: dts: allwinner: d1: Add thermal sensor and thermal zone Maksim Kiselev 2023-06-10 14:17 ` Maksim Kiselev 2023-06-10 14:17 ` [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller Maksim Kiselev 2023-06-10 14:17 ` Maksim Kiselev 2023-06-10 14:52 ` Conor Dooley [this message] 2023-06-10 14:52 ` Conor Dooley 2023-06-10 15:30 ` Maxim Kiselev 2023-06-10 15:30 ` Maxim Kiselev 2023-06-10 17:59 ` Conor Dooley 2023-06-10 17:59 ` Conor Dooley 2023-06-10 18:01 ` Conor Dooley 2023-06-10 18:01 ` Conor Dooley 2023-06-10 20:31 ` Maxim Kiselev 2023-06-10 20:31 ` Maxim Kiselev 2023-06-10 22:13 ` Conor Dooley 2023-06-10 22:13 ` Conor Dooley 2023-06-11 7:53 ` Maxim Kiselev 2023-06-11 7:53 ` Maxim Kiselev 2023-06-11 10:18 ` Conor Dooley 2023-06-11 10:18 ` Conor Dooley 2023-06-10 19:04 ` [PATCH v1 0/3] Add D1/T113s thermal sensor controller support Jernej Škrabec 2023-06-10 19:04 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230610-rehire-amid-2517f43504c0@spud \ --to=conor@kernel.org \ --cc=amitk@kernel.org \ --cc=anarsoul@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=bigunclemax@gmail.com \ --cc=conor+dt@kernel.org \ --cc=cristian.ciocaltea@collabora.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=samuel@sholland.org \ --cc=tiny.windzz@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.