From: Greg KH <gregkh@linuxfoundation.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
arei.gonglei@huawei.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, herbert@gondor.apana.org.au,
davem@davemloft.net, amit@kernel.org, arnd@arndb.de,
marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Xianting Tian <tianxianting.txt@alibaba-inc.com>
Subject: Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs
Date: Sat, 10 Jun 2023 08:51:02 +0200 [thread overview]
Message-ID: <2023061036-lived-earflap-26ee@gregkh> (raw)
In-Reply-To: <a0a07bfd-6e44-5478-395d-be6c1f3bd92a@linux.alibaba.com>
On Sat, Jun 10, 2023 at 11:20:49AM +0800, Xianting Tian wrote:
>
> 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道:
> > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote:
> > > From: Xianting Tian <tianxianting.txt@alibaba-inc.com>
> > >
> > > Cpu stall issue may happen if device is configured with multi queues
> > > and large queue depth, so fix it.
> > What does "may happen" imply exactly?
> > was this observed?
> I didn't met such issue, this patch set just a theoretical fix.
Then I would not recommend adding it at this time, as you just slowed
down the kernel for something that no one has reported :(
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: xuanzhuo@linux.alibaba.com, herbert@gondor.apana.org.au,
arnd@arndb.de, "Michael S. Tsirkin" <mst@redhat.com>,
amit@kernel.org, marcel@holtmann.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-bluetooth@vger.kernel.org,
Xianting Tian <tianxianting.txt@alibaba-inc.com>,
linux-crypto@vger.kernel.org, luiz.dentz@gmail.com,
davem@davemloft.net, johan.hedberg@gmail.com
Subject: Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs
Date: Sat, 10 Jun 2023 08:51:02 +0200 [thread overview]
Message-ID: <2023061036-lived-earflap-26ee@gregkh> (raw)
In-Reply-To: <a0a07bfd-6e44-5478-395d-be6c1f3bd92a@linux.alibaba.com>
On Sat, Jun 10, 2023 at 11:20:49AM +0800, Xianting Tian wrote:
>
> 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道:
> > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote:
> > > From: Xianting Tian <tianxianting.txt@alibaba-inc.com>
> > >
> > > Cpu stall issue may happen if device is configured with multi queues
> > > and large queue depth, so fix it.
> > What does "may happen" imply exactly?
> > was this observed?
> I didn't met such issue, this patch set just a theoretical fix.
Then I would not recommend adding it at this time, as you just slowed
down the kernel for something that no one has reported :(
thanks,
greg k-h
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-06-10 6:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:18 [PATCH 0/3] fixup potential cpu stall Xianting Tian
2023-06-09 13:18 ` [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs Xianting Tian
2023-06-09 13:39 ` Greg KH
2023-06-09 13:39 ` Greg KH
2023-06-09 13:41 ` Greg KH
2023-06-09 13:41 ` Greg KH
2023-06-09 13:49 ` Xianting Tian
2023-06-09 14:05 ` Greg KH
2023-06-09 14:05 ` Greg KH
2023-06-09 14:25 ` Xianting Tian
2023-06-09 16:02 ` Michael S. Tsirkin
2023-06-09 16:02 ` Michael S. Tsirkin
2023-06-09 13:57 ` fixup potential cpu stall bluez.test.bot
2023-06-09 15:57 ` [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs Michael S. Tsirkin
2023-06-09 15:57 ` Michael S. Tsirkin
2023-06-10 3:20 ` Xianting Tian
2023-06-10 6:51 ` Greg KH [this message]
2023-06-10 6:51 ` Greg KH
2023-06-09 15:58 ` Michael S. Tsirkin
2023-06-09 15:58 ` Michael S. Tsirkin
2023-06-09 13:18 ` [PATCH 2/3] virtio_console: " Xianting Tian
2023-06-09 16:05 ` Michael S. Tsirkin
2023-06-09 16:05 ` Michael S. Tsirkin
2023-06-10 3:19 ` Xianting Tian
2023-06-09 13:18 ` [PATCH 3/3] virtio_bt: " Xianting Tian
2023-06-22 11:59 ` [PATCH 0/3] fixup potential cpu stall Michael S. Tsirkin
2023-06-22 11:59 ` Michael S. Tsirkin
2023-06-23 0:58 ` Xianting Tian
2023-07-06 20:10 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061036-lived-earflap-26ee@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amit@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mst@redhat.com \
--cc=tianxianting.txt@alibaba-inc.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.