Re: [PATCH v3 02/11] phy: qcom-qmp-ufs: populate offsets configuration

From: Bjorn Andersson <andersson@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 02/11] phy: qcom-qmp-ufs: populate offsets configuration
Date: Tue, 13 Jun 2023 15:15:36 -0700	[thread overview]
Message-ID: <20230613221536.6tikam262jjvzcfx@ripper> (raw)
In-Reply-To: <20230523140622.265692-3-dmitry.baryshkov@linaro.org>

On Tue, May 23, 2023 at 05:06:13PM +0300, Dmitry Baryshkov wrote:
> Populate offsets configuration for the rest of UFS PHYs to make it
> possible to switch them to the new (single-node) bindings style.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> index 8c877b668bb9..d99dc1043f74 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> @@ -833,6 +833,8 @@ static const struct qmp_ufs_offsets qmp_ufs_offsets_v6 = {
>  static const struct qmp_phy_cfg msm8996_ufsphy_cfg = {
>  	.lanes			= 1,
>  
> +	.offsets		= &qmp_ufs_offsets,
> +
>  	.tbls = {
>  		.serdes		= msm8996_ufsphy_serdes,
>  		.serdes_num	= ARRAY_SIZE(msm8996_ufsphy_serdes),
> @@ -924,6 +926,8 @@ static const struct qmp_phy_cfg sc8280xp_ufsphy_cfg = {
>  static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
>  	.lanes			= 2,
>  
> +	.offsets		= &qmp_ufs_offsets,
> +
>  	.tbls = {
>  		.serdes		= sdm845_ufsphy_serdes,
>  		.serdes_num	= ARRAY_SIZE(sdm845_ufsphy_serdes),
> @@ -1038,6 +1042,8 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = {
>  static const struct qmp_phy_cfg sm8250_ufsphy_cfg = {
>  	.lanes			= 2,
>  
> +	.offsets		= &qmp_ufs_offsets,
> +
>  	.tbls = {
>  		.serdes		= sm8150_ufsphy_serdes,
>  		.serdes_num	= ARRAY_SIZE(sm8150_ufsphy_serdes),
> @@ -1070,6 +1076,8 @@ static const struct qmp_phy_cfg sm8250_ufsphy_cfg = {
>  static const struct qmp_phy_cfg sm8350_ufsphy_cfg = {
>  	.lanes			= 2,
>  
> +	.offsets		= &qmp_ufs_offsets,
> +
>  	.tbls = {
>  		.serdes		= sm8350_ufsphy_serdes,
>  		.serdes_num	= ARRAY_SIZE(sm8350_ufsphy_serdes),
> @@ -1102,6 +1110,8 @@ static const struct qmp_phy_cfg sm8350_ufsphy_cfg = {
>  static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
>  	.lanes			= 2,
>  
> +	.offsets		= &qmp_ufs_offsets,
> +
>  	.tbls = {
>  		.serdes		= sm8350_ufsphy_serdes,
>  		.serdes_num	= ARRAY_SIZE(sm8350_ufsphy_serdes),
> -- 
> 2.39.2
>