From: Alexander Dahl <ada@thorsis.com>
To: Durai Manickam KR <durai.manickamkr@microchip.com>
Cc: Hari.PrasathGE@microchip.com,
balamanikandan.gunasundar@microchip.com,
manikandan.m@microchip.com, varshini.rajendran@microchip.com,
dharma.b@microchip.com, nayabbasha.sayed@microchip.com,
balakrishnan.s@microchip.com, cristian.birsan@microchip.com,
nicolas.ferre@microchip.com, krzysztof.kozlowski@linaro.org,
alexandre.belloni@bootlin.com, davem@davemloft.net,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kavyasree.Kotagiri@microchip.com,
Horatiu.Vultur@microchip.com, robh+dt@kernel.org, andrew@lunn.ch,
michael@walle.cc, jerry.ray@microchip.com, conor+dt@kernel.org,
jesper.nilsson@axis.com, andre.przywara@arm.com, ada@thorsis.com,
radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com,
gregkh@linuxfoundation.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection
Date: Mon, 31 Jul 2023 15:35:54 +0200 [thread overview]
Message-ID: <20230731-confess-prison-0ce898c937ba@ifak-system.com> (raw)
In-Reply-To: <20230718065735.10187-3-durai.manickamkr@microchip.com>
Hello Durai,
Am Tue, Jul 18, 2023 at 12:27:35PM +0530 schrieb Durai Manickam KR:
> Defining the dbgu compatible strings in the UART submodule of the
> flexcom gives the below error log,
> AT91: Could not find matching SoC description
> This error arises due to defining the dbgu compatible strings to
> the flexcom usart which is not valid because there is only one debug unit
> in the sam9x60 SOC and it has the chipid register. The dbgu compatible
> strings are valid only for debug usart and not valid for flexcom usart.
> Thus removing the dbgu compatible strings in the UART submodule of the
> flexcom for the proper SOC detection.
>
> Fixes: 99c808335877 (ARM: dts: at91: sam9x60: Add missing flexcom definitions)
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
Acked-by: Alexander Dahl <ada@thorsis.com>
(The diff of the patch is identical to the diff of a quick hacked
patch I made weeks ago for my BSP which fixed the issue. SoC variant
was reported correctly on serial console on boot again. However I did
not actually test *your* patch on my hardware (sam9x60 curiosity),
thus Acked-by and not Tested-by.)
Greets
Alex
> ---
> arch/arm/boot/dts/microchip/sam9x60.dtsi | 26 ++++++++++++------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> index 8b53997675e7..73d570a17269 100644
> --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> @@ -172,7 +172,7 @@ flx4: flexcom@f0000000 {
> status = "disabled";
>
> uart4: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -240,7 +240,7 @@ flx5: flexcom@f0004000 {
> status = "disabled";
>
> uart5: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
> interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> @@ -370,7 +370,7 @@ flx11: flexcom@f0020000 {
> status = "disabled";
>
> uart11: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -419,7 +419,7 @@ flx12: flexcom@f0024000 {
> status = "disabled";
>
> uart12: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -576,7 +576,7 @@ flx6: flexcom@f8010000 {
> status = "disabled";
>
> uart6: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -625,7 +625,7 @@ flx7: flexcom@f8014000 {
> status = "disabled";
>
> uart7: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -674,7 +674,7 @@ flx8: flexcom@f8018000 {
> status = "disabled";
>
> uart8: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -723,7 +723,7 @@ flx0: flexcom@f801c000 {
> status = "disabled";
>
> uart0: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -791,7 +791,7 @@ flx1: flexcom@f8020000 {
> status = "disabled";
>
> uart1: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -859,7 +859,7 @@ flx2: flexcom@f8024000 {
> status = "disabled";
>
> uart2: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -927,7 +927,7 @@ flx3: flexcom@f8028000 {
> status = "disabled";
>
> uart3: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -1050,7 +1050,7 @@ flx9: flexcom@f8040000 {
> status = "disabled";
>
> uart9: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -1099,7 +1099,7 @@ flx10: flexcom@f8044000 {
> status = "disabled";
>
> uart10: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Dahl <ada@thorsis.com>
To: Durai Manickam KR <durai.manickamkr@microchip.com>
Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, jerry.ray@microchip.com,
Hari.PrasathGE@microchip.com, varshini.rajendran@microchip.com,
Horatiu.Vultur@microchip.com, manikandan.m@microchip.com,
jesper.nilsson@axis.com, balamanikandan.gunasundar@microchip.com,
michael@walle.cc, dharma.b@microchip.com,
linux-serial@vger.kernel.org, cristian.birsan@microchip.com,
nayabbasha.sayed@microchip.com, conor+dt@kernel.org,
arnd@arndb.de, andre.przywara@arm.com, radu_nicolae.pirea@upb.ro,
soc@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
balakrishnan.s@microchip.com, ada@thorsis.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, richard.genoud@gmail.com,
krzysztof.kozlowski@linaro.org, Kavyasree.Kotagiri@microchip.com,
olof@lixom.net, davem@davemloft.net
Subject: Re: [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection
Date: Mon, 31 Jul 2023 15:35:54 +0200 [thread overview]
Message-ID: <20230731-confess-prison-0ce898c937ba@ifak-system.com> (raw)
In-Reply-To: <20230718065735.10187-3-durai.manickamkr@microchip.com>
Hello Durai,
Am Tue, Jul 18, 2023 at 12:27:35PM +0530 schrieb Durai Manickam KR:
> Defining the dbgu compatible strings in the UART submodule of the
> flexcom gives the below error log,
> AT91: Could not find matching SoC description
> This error arises due to defining the dbgu compatible strings to
> the flexcom usart which is not valid because there is only one debug unit
> in the sam9x60 SOC and it has the chipid register. The dbgu compatible
> strings are valid only for debug usart and not valid for flexcom usart.
> Thus removing the dbgu compatible strings in the UART submodule of the
> flexcom for the proper SOC detection.
>
> Fixes: 99c808335877 (ARM: dts: at91: sam9x60: Add missing flexcom definitions)
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
Acked-by: Alexander Dahl <ada@thorsis.com>
(The diff of the patch is identical to the diff of a quick hacked
patch I made weeks ago for my BSP which fixed the issue. SoC variant
was reported correctly on serial console on boot again. However I did
not actually test *your* patch on my hardware (sam9x60 curiosity),
thus Acked-by and not Tested-by.)
Greets
Alex
> ---
> arch/arm/boot/dts/microchip/sam9x60.dtsi | 26 ++++++++++++------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> index 8b53997675e7..73d570a17269 100644
> --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> @@ -172,7 +172,7 @@ flx4: flexcom@f0000000 {
> status = "disabled";
>
> uart4: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -240,7 +240,7 @@ flx5: flexcom@f0004000 {
> status = "disabled";
>
> uart5: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
> interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> @@ -370,7 +370,7 @@ flx11: flexcom@f0020000 {
> status = "disabled";
>
> uart11: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -419,7 +419,7 @@ flx12: flexcom@f0024000 {
> status = "disabled";
>
> uart12: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -576,7 +576,7 @@ flx6: flexcom@f8010000 {
> status = "disabled";
>
> uart6: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -625,7 +625,7 @@ flx7: flexcom@f8014000 {
> status = "disabled";
>
> uart7: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -674,7 +674,7 @@ flx8: flexcom@f8018000 {
> status = "disabled";
>
> uart8: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -723,7 +723,7 @@ flx0: flexcom@f801c000 {
> status = "disabled";
>
> uart0: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -791,7 +791,7 @@ flx1: flexcom@f8020000 {
> status = "disabled";
>
> uart1: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -859,7 +859,7 @@ flx2: flexcom@f8024000 {
> status = "disabled";
>
> uart2: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -927,7 +927,7 @@ flx3: flexcom@f8028000 {
> status = "disabled";
>
> uart3: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -1050,7 +1050,7 @@ flx9: flexcom@f8040000 {
> status = "disabled";
>
> uart9: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> @@ -1099,7 +1099,7 @@ flx10: flexcom@f8044000 {
> status = "disabled";
>
> uart10: serial@200 {
> - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart";
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> reg = <0x200 0x200>;
> interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
> dmas = <&dma0
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-31 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 6:57 [PATCHv3 0/2] update at91 usart compatible for sam9x60 Durai Manickam KR
2023-07-18 6:57 ` Durai Manickam KR
2023-07-18 6:57 ` [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update " Durai Manickam KR
2023-07-18 6:57 ` Durai Manickam KR
2023-07-18 11:12 ` Conor Dooley
2023-07-18 11:12 ` Conor Dooley
2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR
2023-07-18 6:57 ` Durai Manickam KR
2023-07-31 13:35 ` Alexander Dahl [this message]
2023-07-31 13:35 ` Alexander Dahl
2023-07-24 14:05 ` [PATCHv3 0/2] update at91 usart compatible for sam9x60 patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731-confess-prison-0ce898c937ba@ifak-system.com \
--to=ada@thorsis.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=balakrishnan.s@microchip.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=durai.manickamkr@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerry.ray@microchip.com \
--cc=jesper.nilsson@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=manikandan.m@microchip.com \
--cc=michael@walle.cc \
--cc=nayabbasha.sayed@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.