From: Conor Dooley <conor@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
paul.walmsley@sifive.com, palmer@rivosinc.com,
aou@eecs.berkeley.edu, anup@brainfault.org,
konstantin@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org,
alexghiti@rivosinc.com
Subject: Re: [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space
Date: Thu, 10 Aug 2023 00:07:13 +0100 [thread overview]
Message-ID: <20230810-endanger-motive-83096266ab26@spud> (raw)
In-Reply-To: <ZNQXC+UQ+a0s69Bs@ghost>
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
On Wed, Aug 09, 2023 at 03:45:31PM -0700, Charlie Jenkins wrote:
> On Wed, Aug 09, 2023 at 08:42:58AM +0100, Conor Dooley wrote:
> > On Tue, Aug 08, 2023 at 06:51:06PM -0700, Charlie Jenkins wrote:
> > > Make sv48 the default address space for mmap as some applications
> > > currently depend on this assumption. Users can now select a
> > > desired address space using a non-zero hint address to mmap. Previously,
> > > requesting the default address space from mmap by passing zero as the hint
> > > address would result in using the largest address space possible. Some
> > > applications depend on empty bits in the virtual address space, like Go and
> > > Java, so this patch provides more flexibility for application developers.
> >
> > This still does not build:
> > ../fs/binfmt_flat.c:900:30: error: call to undeclared function 'is_compat_task'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >
> > Reproduceable with allmodconfig.
> >
> There is some weird interaction with compat.h. Moving the definitions
> in pgtable.h into the #ifndef __ASSEMBLY__ guarded section resolves
> the compile error. I will send out another version with this change.
Just be sure to run an allmodconfig build this time before doing so ;)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
paul.walmsley@sifive.com, palmer@rivosinc.com,
aou@eecs.berkeley.edu, anup@brainfault.org,
konstantin@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org,
alexghiti@rivosinc.com
Subject: Re: [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space
Date: Thu, 10 Aug 2023 00:07:13 +0100 [thread overview]
Message-ID: <20230810-endanger-motive-83096266ab26@spud> (raw)
In-Reply-To: <ZNQXC+UQ+a0s69Bs@ghost>
[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]
On Wed, Aug 09, 2023 at 03:45:31PM -0700, Charlie Jenkins wrote:
> On Wed, Aug 09, 2023 at 08:42:58AM +0100, Conor Dooley wrote:
> > On Tue, Aug 08, 2023 at 06:51:06PM -0700, Charlie Jenkins wrote:
> > > Make sv48 the default address space for mmap as some applications
> > > currently depend on this assumption. Users can now select a
> > > desired address space using a non-zero hint address to mmap. Previously,
> > > requesting the default address space from mmap by passing zero as the hint
> > > address would result in using the largest address space possible. Some
> > > applications depend on empty bits in the virtual address space, like Go and
> > > Java, so this patch provides more flexibility for application developers.
> >
> > This still does not build:
> > ../fs/binfmt_flat.c:900:30: error: call to undeclared function 'is_compat_task'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >
> > Reproduceable with allmodconfig.
> >
> There is some weird interaction with compat.h. Moving the definitions
> in pgtable.h into the #ifndef __ASSEMBLY__ guarded section resolves
> the compile error. I will send out another version with this change.
Just be sure to run an allmodconfig build this time before doing so ;)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-08-09 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 1:51 [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space Charlie Jenkins
2023-08-09 1:51 ` Charlie Jenkins
2023-08-09 1:51 ` [PATCH v9 1/4] RISC-V: mm: Restrict address space for sv39,sv48,sv57 Charlie Jenkins
2023-08-09 1:51 ` Charlie Jenkins
2023-08-09 1:51 ` [PATCH v9 2/4] RISC-V: mm: Add tests for RISC-V mm Charlie Jenkins
2023-08-09 1:51 ` Charlie Jenkins
2023-08-09 1:51 ` [PATCH v9 3/4] RISC-V: mm: Update pgtable comment documentation Charlie Jenkins
2023-08-09 1:51 ` Charlie Jenkins
2023-08-09 1:51 ` [PATCH v9 4/4] RISC-V: mm: Document mmap changes Charlie Jenkins
2023-08-09 1:51 ` Charlie Jenkins
2023-08-09 7:42 ` [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space Conor Dooley
2023-08-09 7:42 ` Conor Dooley
2023-08-09 22:45 ` Charlie Jenkins
2023-08-09 22:45 ` Charlie Jenkins
2023-08-09 23:07 ` Conor Dooley [this message]
2023-08-09 23:07 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810-endanger-motive-83096266ab26@spud \
--to=conor@kernel.org \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=jrtc27@jrtc27.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.