From: Jeff King <peff@peff.net>
To: Wesley Schwengle <wesleys@opperschaap.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix bug when more than one readline instance is used
Date: Wed, 9 Aug 2023 20:49:56 -0400 [thread overview]
Message-ID: <20230810004956.GA816605@coredump.intra.peff.net> (raw)
In-Reply-To: <20230810003939.1420306-1-wesleys@opperschaap.net>
On Wed, Aug 09, 2023 at 08:39:33PM -0400, Wesley Schwengle wrote:
> The following error was emitted if one issued the command
>
> git send-email --compose 0001-my.patch
>
> Can't locate object method "IN" via package "FakeTerm" at
> /home/wesleys/libexec/git-core/git-send-email line 997.
>
> After added a warn in the relevant function that created the term it was
> obvious what happened:
>
> Only one Term::ReadLine::Gnu instance is allowed. at
> /home/wesleys/libexec/git-core/git-send-email line 981.
I posted a similar fix yesterday, which is currently in 'next' via
d42e4ca9f8:
https://lore.kernel.org/git/20230808180935.GA2096901@coredump.intra.peff.net/
However...
> More or less the same logic happens in git-svn.perl so I fixed it there
> as well.
...I didn't touch git-svn.perl, and I agree it probably has the same
problem (I didn't try it in practice, but any time ask() is called twice
it will run into the same issue).
Do you want to prepare a patch on top removing the git-svn bits
(probably all of FakeTerm, too)?
-Peff
next prev parent reply other threads:[~2023-08-10 0:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 0:39 [PATCH] Fix bug when more than one readline instance is used Wesley Schwengle
2023-08-10 0:49 ` Jeff King [this message]
2023-08-10 1:18 ` [[PATCH v2]] " Wesley Schwengle
2023-08-10 14:31 ` Junio C Hamano
2023-08-10 15:14 ` Wesley
2023-08-11 1:01 ` Junio C Hamano
2023-08-11 1:09 ` Wesley
2023-08-11 5:30 ` Junio C Hamano
2023-08-11 14:51 ` Jeff King
2023-08-11 16:05 ` Junio C Hamano
2023-08-30 22:32 ` [PATCH] git-svn: drop FakeTerm hack Junio C Hamano
2023-08-31 0:13 ` Jeff King
2023-08-31 0:28 ` Junio C Hamano
2023-08-10 1:05 ` [PATCH] Fix bug when more than one readline instance is used Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810004956.GA816605@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=wesleys@opperschaap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.