Re: [[PATCH v2]] Fix bug when more than one readline instance is used

From: Junio C Hamano <gitster@pobox.com>
To: Wesley Schwengle <wesleys@opperschaap.net>
Cc: git@vger.kernel.org
Subject: Re: [[PATCH v2]] Fix bug when more than one readline instance is used
Date: Thu, 10 Aug 2023 18:01:12 -0700	[thread overview]
Message-ID: <xmqqcyzupf3b.fsf@gitster.g> (raw)
In-Reply-To: <20230810011831.1423208-1-wesleys@opperschaap.net> (Wesley Schwengle's message of "Wed, 9 Aug 2023 21:18:31 -0400")

Wesley Schwengle <wesleys@opperschaap.net> writes:

> diff --git a/git-svn.perl b/git-svn.perl
> index be987e316f..93f6538d61 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> ...
> -	if ($@) {
> -		$term = new FakeTerm "$@: going non-interactive";
> +		$term = $ENV{"GIT_SVN_NOTTY"}
> +				? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
> +				: new Term::ReadLine 'git-svn';
> +		};

This line with "};" on it should not be added, I think.

cf. https://github.com/git/git/actions/runs/5827208598/job/15802787783#step:5:74

> +		return $term;
>  	}
>  }

 git-svn.perl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/git-svn.perl b/git-svn.perl
index 93f6538d61..e919c3f172 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -307,7 +307,6 @@ package main;
 		$term = $ENV{"GIT_SVN_NOTTY"}
 				? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
 				: new Term::ReadLine 'git-svn';
-		};
 		return $term;
 	}
 }
-- 
2.42.0-rc1

