All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Xueshi Hu <xueshi.hu@smartx.com>
Cc: Christian Brauner <brauner@kernel.org>,
	nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-aio@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-mm@kvack.org, linux-xfs@vger.kernel.org,
	Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
	hch@infradead.org, dan.j.williams@intel.com,
	vishal.l.verma@intel.com, dave.jiang@intel.com,
	jayalk@intworks.biz, daniel@ffwll.ch, deller@gmx.de,
	bcrl@kvack.org, viro@zeniv.linux.org.uk, jack@suse.com,
	tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu,
	mike.kravetz@oracle.com, muchun.song@linux.dev,
	djwong@kernel.org, willy@infradead.org,
	akpm@linux-foundation.org, hughd@google.com
Subject: Re: [PATCH v3] fs: clean up usage of noop_dirty_folio
Date: Tue, 29 Aug 2023 10:11:50 +0200	[thread overview]
Message-ID: <20230829-kappen-meinen-0c51bfa4472a@brauner> (raw)
In-Reply-To: <20230829040029.473810-1-xueshi.hu@smartx.com>

On Tue, 29 Aug 2023 12:00:29 +0800, Xueshi Hu wrote:
> In folio_mark_dirty(), it can automatically fallback to
> noop_dirty_folio() if a_ops->dirty_folio is not registered.
> 
> In anon_aops, dev_dax_aops and fb_deferred_io_aops, replacing .dirty_folio
> with NULL makes them identical to default (empty_aops) and since we never
> compare ->a_ops pointer with either of those, we can remove them
> completely.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs: clean up usage of noop_dirty_folio
      https://git.kernel.org/vfs/vfs/c/ffb2bc01caae

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <brauner@kernel.org>
To: Xueshi Hu <xueshi.hu@smartx.com>
Cc: nvdimm@lists.linux.dev, linux-fbdev@vger.kernel.org,
	Jan Kara <jack@suse.cz>,
	linux-aio@kvack.org, djwong@kernel.org,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	adilger.kernel@dilger.ca, Christoph Hellwig <hch@lst.de>,
	dave.jiang@intel.com, miklos@szeredi.hu,
	vishal.l.verma@intel.com, deller@gmx.de, hughd@google.com,
	willy@infradead.org, hch@infradead.org,
	linux-ext4@vger.kernel.org, jayalk@intworks.biz,
	linux-cxl@vger.kernel.org, viro@zeniv.linux.org.uk,
	dan.j.williams@intel.com, Christian Brauner <brauner@kernel.org>,
	tytso@mit.edu, muchun.song@linux.dev,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	bcrl@kvack.org, jack@suse.com, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org, mike.kravetz@oracle.com
Subject: Re: [PATCH v3] fs: clean up usage of noop_dirty_folio
Date: Tue, 29 Aug 2023 10:11:50 +0200	[thread overview]
Message-ID: <20230829-kappen-meinen-0c51bfa4472a@brauner> (raw)
In-Reply-To: <20230829040029.473810-1-xueshi.hu@smartx.com>

On Tue, 29 Aug 2023 12:00:29 +0800, Xueshi Hu wrote:
> In folio_mark_dirty(), it can automatically fallback to
> noop_dirty_folio() if a_ops->dirty_folio is not registered.
> 
> In anon_aops, dev_dax_aops and fb_deferred_io_aops, replacing .dirty_folio
> with NULL makes them identical to default (empty_aops) and since we never
> compare ->a_ops pointer with either of those, we can remove them
> completely.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs: clean up usage of noop_dirty_folio
      https://git.kernel.org/vfs/vfs/c/ffb2bc01caae

  reply	other threads:[~2023-08-29  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  4:00 [PATCH v3] fs: clean up usage of noop_dirty_folio Xueshi Hu
2023-08-29  4:00 ` Xueshi Hu
2023-08-29  8:11 ` Christian Brauner [this message]
2023-08-29  8:11   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829-kappen-meinen-0c51bfa4472a@brauner \
    --to=brauner@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=bcrl@kvack.org \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dave.jiang@intel.com \
    --cc=deller@gmx.de \
    --cc=djwong@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=hughd@google.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=jayalk@intworks.biz \
    --cc=linux-aio@kvack.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mike.kravetz@oracle.com \
    --cc=miklos@szeredi.hu \
    --cc=muchun.song@linux.dev \
    --cc=nvdimm@lists.linux.dev \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vishal.l.verma@intel.com \
    --cc=willy@infradead.org \
    --cc=xueshi.hu@smartx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.