From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Cc: "Fenghua Yu" <fenghua.yu@intel.com>,
"Babu Moger" <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 0/8] selftests/resctrl: Rework benchmark command handling
Date: Thu, 31 Aug 2023 14:08:35 +0300 [thread overview]
Message-ID: <20230831110843.26719-1-ilpo.jarvinen@linux.intel.com> (raw)
The benchmark command handling (-b) in resctrl selftests is overly
complicated code. This series turns the benchmark command immutable to
preserve it for all selftests and improves benchmark command related
error handling.
This series also ends up removing the strcpy() calls which were pointed
out earlier.
v4:
- Correct off-by-one error in -b processing
- Reordered code in main() to make freeing span_str simpler (in new patch)
- Use consistent style for const char * const *
v3:
- Removed DEFAULT_SPAN_STR for real and the duplicated copy of defines
that made to v2 likely due to my incorrect conflict resolutions
v2:
- Added argument length check into patch 1/7
- Updated also -b line in help message.
- Document -b argument related "algorithm"
- Use asprintf() to convert defined constant int to string
- Improved changelog texts
- Added \n to ksft_exit_fail_msg() call messages.
- Print DEFAULT_SPAN with %u instead of %zu to avoid need to cast it
Ilpo Järvinen (8):
selftests/resctrl: Ensure the benchmark commands fits to its array
selftests/resctrl: Correct benchmark command help
selftests/resctrl: Remove bw_report and bm_type from main()
selftests/resctrl: Simplify span lifetime
selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init
selftests/resctrl: Make benchmark command const and build it with
pointers
selftests/resctrl: Remove ben_count variable
selftests/resctrl: Cleanup benchmark argument parsing
tools/testing/selftests/resctrl/cache.c | 5 +-
tools/testing/selftests/resctrl/cat_test.c | 13 +--
tools/testing/selftests/resctrl/cmt_test.c | 34 ++++--
tools/testing/selftests/resctrl/mba_test.c | 4 +-
tools/testing/selftests/resctrl/mbm_test.c | 7 +-
tools/testing/selftests/resctrl/resctrl.h | 16 +--
.../testing/selftests/resctrl/resctrl_tests.c | 100 ++++++++----------
tools/testing/selftests/resctrl/resctrl_val.c | 10 +-
8 files changed, 104 insertions(+), 85 deletions(-)
--
2.30.2
next reply other threads:[~2023-08-31 11:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:08 Ilpo Järvinen [this message]
2023-08-31 11:08 ` [PATCH v4 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre
2023-09-01 9:18 ` Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 2/8] selftests/resctrl: Correct benchmark command help Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 3/8] selftests/resctrl: Remove bw_report and bm_type from main() Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 4/8] selftests/resctrl: Simplify span lifetime Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre
2023-08-31 11:08 ` [PATCH v4 6/8] selftests/resctrl: Make benchmark command const and build it with pointers Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre
2023-08-31 11:08 ` [PATCH v4 7/8] selftests/resctrl: Remove ben_count variable Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 8/8] selftests/resctrl: Cleanup benchmark argument parsing Ilpo Järvinen
2023-08-31 21:26 ` Reinette Chatre
2023-09-01 5:28 ` [PATCH v4 0/8] selftests/resctrl: Rework benchmark command handling Maciej Wieczór-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831110843.26719-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.