Re: [PATCH v4 8/8] selftests/resctrl: Cleanup benchmark argument parsing

From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
	"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
	"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Babu Moger <babu.moger@amd.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 8/8] selftests/resctrl: Cleanup benchmark argument parsing
Date: Thu, 31 Aug 2023 14:26:21 -0700	[thread overview]
Message-ID: <73b4d9d0-76a8-3b60-6d7a-2c115b220868@intel.com> (raw)
In-Reply-To: <20230831110843.26719-9-ilpo.jarvinen@linux.intel.com>

Hi Ilpo,

On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark argument is handled by custom argument parsing code which is
> more complicated than it needs to be.
> 
> Process benchmark argument within the normal getopt() handling and drop
> unnecessary ben_ind and has_ben variables. When -b is given, terminate
> the argument processing as -b consumes all remaining arguments.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  .../testing/selftests/resctrl/resctrl_tests.c | 46 +++++++++----------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 48e5afb1530c..831d50a37d78 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -169,27 +169,34 @@ static void run_cat_test(int cpu_no, int no_of_bits)
>  
>  int main(int argc, char **argv)
>  {
> -	bool has_ben = false, mbm_test = true, mba_test = true, cmt_test = true;
> -	int c, cpu_no = 1, argc_new = argc, i, no_of_bits = 0;
> -	const char *benchmark_cmd[BENCHMARK_ARGS];
> -	int ben_ind, tests = 0;
> +	bool mbm_test = true, mba_test = true, cmt_test = true;
> +	int c, cpu_no = 1, i, no_of_bits = 0;
> +	const char *benchmark_cmd[BENCHMARK_ARGS] = {};
>  	char *span_str = NULL;

Could you please keep reverse fir ordering?

Reinette