From: SeongJae Park <sj@kernel.org> Cc: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC 8/8] mm/damon/core: mark damon_moving_sum() as a static function Date: Sat, 9 Sep 2023 03:37:11 +0000 [thread overview] Message-ID: <20230909033711.55794-9-sj@kernel.org> (raw) In-Reply-To: <20230909033711.55794-1-sj@kernel.org> The function is used by only mm/damon/core.c. Mark it as a static function. Signed-off-by: SeongJae Park <sj@kernel.org> --- include/linux/damon.h | 2 -- mm/damon/core.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 0fe13482df63..491fdd3e4c76 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -632,8 +632,6 @@ void damon_add_region(struct damon_region *r, struct damon_target *t); void damon_destroy_region(struct damon_region *r, struct damon_target *t); int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges, unsigned int nr_ranges); -unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, - unsigned int len_window, unsigned int new_value); void damon_update_region_access_rate(struct damon_region *r, bool accessed, struct damon_attrs *attrs); diff --git a/mm/damon/core.c b/mm/damon/core.c index 1ba7c4669263..83b0cd329e84 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1627,7 +1627,7 @@ int damon_set_region_biggest_system_ram_default(struct damon_target *t, * * Return: Pseudo-moving average after getting the @new_value. */ -unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, +static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, unsigned int len_window, unsigned int new_value) { return mvsum - nomvsum / len_window + new_value; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: SeongJae Park <sj@kernel.org> To: unlisted-recipients:; (no To-header on input) Cc: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC 8/8] mm/damon/core: mark damon_moving_sum() as a static function Date: Sat, 9 Sep 2023 03:37:11 +0000 [thread overview] Message-ID: <20230909033711.55794-9-sj@kernel.org> (raw) In-Reply-To: <20230909033711.55794-1-sj@kernel.org> The function is used by only mm/damon/core.c. Mark it as a static function. Signed-off-by: SeongJae Park <sj@kernel.org> --- include/linux/damon.h | 2 -- mm/damon/core.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 0fe13482df63..491fdd3e4c76 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -632,8 +632,6 @@ void damon_add_region(struct damon_region *r, struct damon_target *t); void damon_destroy_region(struct damon_region *r, struct damon_target *t); int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges, unsigned int nr_ranges); -unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, - unsigned int len_window, unsigned int new_value); void damon_update_region_access_rate(struct damon_region *r, bool accessed, struct damon_attrs *attrs); diff --git a/mm/damon/core.c b/mm/damon/core.c index 1ba7c4669263..83b0cd329e84 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1627,7 +1627,7 @@ int damon_set_region_biggest_system_ram_default(struct damon_target *t, * * Return: Pseudo-moving average after getting the @new_value. */ -unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, +static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, unsigned int len_window, unsigned int new_value) { return mvsum - nomvsum / len_window + new_value; -- 2.25.1
next prev parent reply other threads:[~2023-09-09 3:37 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-09 3:37 [RFC 0/8] mm/damon: provide pseudo-moving sum based access rate SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 1/8] mm/damon/core: define and use a dedicated function for region access rate update SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 2/8] mm/damon/vaddr: call damon_update_region_access_rate() always SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 3/8] mm/damon/core: implement a pseudo-moving sum function SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 4/8] mm/damon/core-test: add a unit test for damon_moving_sum() SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 5/8] mm/damon/core: introduce nr_accesses_bp SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 6/8] mm/damon/core: use pseudo-moving sum for nr_accesses_bp SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` [RFC 7/8] mm/damon/core: skip updating nr_accesses_bp for each aggregation interval SeongJae Park 2023-09-09 3:37 ` SeongJae Park 2023-09-09 3:37 ` SeongJae Park [this message] 2023-09-09 3:37 ` [RFC 8/8] mm/damon/core: mark damon_moving_sum() as a static function SeongJae Park
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230909033711.55794-9-sj@kernel.org \ --to=sj@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=damon@lists.linux.dev \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.