From: Anders Roxell <anders.roxell@linaro.org>
To: andrey.konovalov@linux.dev
Cc: Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>,
arnd@arndb.de, sfr@canb.auug.org.au
Subject: Re: [PATCH v2 12/19] lib/stackdepot: use list_head for stack record links
Date: Sat, 16 Sep 2023 19:43:35 +0200 [thread overview]
Message-ID: <20230916174334.GA1030024@mutt> (raw)
In-Reply-To: <d94caa60d28349ca5a3c709fdb67545d9374e0dc.1694625260.git.andreyknvl@google.com>
On 2023-09-13 19:14, andrey.konovalov@linux.dev wrote:
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Switch stack_record to use list_head for links in the hash table
> and in the freelist.
>
> This will allow removing entries from the hash table buckets.
>
> This is preparatory patch for implementing the eviction of stack records
> from the stack depot.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
Building on an arm64 kernel from linux-next tag next-20230915, and boot
that in QEMU. I see the following kernel panic.
[ 67.398850][ T1] Unable to handle kernel read from unreadable memory at virtual address 0000000000000010
[ 67.407996][ T1] Mem abort info:
[ 67.411023][ T1] ESR = 0x0000000096000004
[ 67.414757][ T1] EC = 0x25: DABT (current EL), IL = 32 bits
[ 67.419945][ T1] SET = 0, FnV = 0
[ 67.423172][ T1] EA = 0, S1PTW = 0
[ 67.426669][ T1] FSC = 0x04: level 0 translation fault
[ 67.431357][ T1] Data abort info:
[ 67.434593][ T1] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000
[ 67.439801][ T1] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 67.444948][ T1] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 67.449910][ T1] [0000000000000010] user address but active_mm is swapper
[ 67.456236][ T1] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP
[ 67.462181][ T1] Modules linked in:
[ 67.465435][ T1] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G T 6.6.0-rc1-next-20230915 #2 e95cf19845fbc1e6a5f0694214d59e527e463469
[ 67.477126][ T1] Hardware name: linux,dummy-virt (DT)
[ 67.481994][ T1] pstate: 804000c5 (Nzcv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 67.488454][ T1] pc : stack_depot_save_flags+0x2a8/0x780
[ 67.493348][ T1] lr : stack_depot_save_flags+0x2a8/0x780
[ 67.498339][ T1] sp : ffff80008000b870
[ 67.501670][ T1] x29: ffff80008000b870 x28: 00000000650dddc5 x27: 0000000000000000
[ 67.508658][ T1] x26: ffff80008470a000 x25: ffff80008000b9e8 x24: 0000000000000001
[ 67.515564][ T1] x23: 000000000000000e x22: ffff80008000b988 x21: 0000000000000001
[ 67.522430][ T1] x20: ffff00007b40d070 x19: 000000006ee80007 x18: ffff80008000d080
[ 67.529365][ T1] x17: 0000000000000000 x16: 0000000000000000 x15: 2030303178302f30
[ 67.536101][ T1] x14: 0000000000000000 x13: 205d315420202020 x12: 0000000000000000
[ 67.542985][ T1] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000
[ 67.549863][ T1] x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000
[ 67.556764][ T1] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000
[ 67.563687][ T1] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000
[ 67.570500][ T1] Call trace:
[ 67.573275][ T1] stack_depot_save_flags+0x2a8/0x780
[ 67.577794][ T1] stack_depot_save+0x4c/0xc0
[ 67.582062][ T1] ref_tracker_alloc+0x354/0x480
[ 67.586273][ T1] sk_alloc+0x280/0x5f8
[ 67.590064][ T1] __netlink_create+0x84/0x200
[ 67.594009][ T1] __netlink_kernel_create+0x11c/0x500
[ 67.598816][ T1] rtnetlink_net_init+0xc4/0x180
[ 67.603052][ T1] ops_init+0x100/0x2c0
[ 67.606827][ T1] register_pernet_operations+0x228/0x480
[ 67.611568][ T1] register_pernet_subsys+0x5c/0xc0
[ 67.616282][ T1] rtnetlink_init+0x60/0xb00
[ 67.620086][ T1] netlink_proto_init+0x374/0x400
[ 67.624465][ T1] do_one_initcall+0x2c8/0x840
[ 67.628518][ T1] do_initcalls+0x21c/0x340
[ 67.632527][ T1] kernel_init_freeable+0x3b0/0x480
[ 67.636905][ T1] kernel_init+0x58/0x380
[ 67.640768][ T1] ret_from_fork+0x10/0x40
[ 67.644606][ T1] Code: eb1b029f 540008c0 91004360 97caa437 (b9401360)
[ 67.650293][ T1] ---[ end trace 0000000000000000 ]---
[ 67.654948][ T1] Kernel panic - not syncing: Oops: Fatal exception
[ 67.660229][ T1] ---[ end Kernel panic - not syncing: Oops: Fatal exception ]---
The full log can be found [1] and the .config file [2]. I bisected down
to this commit, see the bisect log [3].
When reverted these two commits I managed to build and the kernel
booted.
47590ecf1166 ("lib/stackdepot: use list_head for stack record links")
8729f3c26fc2 ("lib/stackdepot: allow users to evict stack traces")
Cheers,
Anders
[1] http://ix.io/4GyE
[2] https://people.linaro.org/~anders.roxell/next-20230915.config
[3] http://ix.io/4GyG
next prev parent reply other threads:[~2023-09-16 17:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 17:14 [PATCH v2 00/19] stackdepot: allow evicting stack traces andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 01/19] lib/stackdepot: check disabled flag when fetching andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 02/19] lib/stackdepot: simplify __stack_depot_save andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 03/19] lib/stackdepot: drop valid bit from handles andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 04/19] lib/stackdepot: add depot_fetch_stack helper andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 05/19] lib/stackdepot: use fixed-sized slots for stack records andrey.konovalov
2023-09-15 8:55 ` Marco Elver
2023-09-15 16:46 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations andrey.konovalov
2023-10-06 16:14 ` Alexander Potapenko
2023-10-06 17:21 ` Alexander Potapenko
2023-10-23 16:15 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 07/19] lib/stackdepot: rework helpers for depot_alloc_stack andrey.konovalov
2023-10-09 8:59 ` Alexander Potapenko
2023-10-09 9:35 ` Alexander Potapenko
2023-10-23 16:16 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 08/19] lib/stackdepot: rename next_pool_required to new_pool_required andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 09/19] lib/stackdepot: store next pool pointer in new_pool andrey.konovalov
2023-09-19 16:13 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 10/19] lib/stackdepot: store free stack records in a freelist andrey.konovalov
2023-10-09 9:32 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 11/19] lib/stackdepot: use read/write lock andrey.konovalov
2023-10-09 9:45 ` Alexander Potapenko
2023-10-23 16:16 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 12/19] lib/stackdepot: use list_head for stack record links andrey.konovalov
2023-09-16 17:43 ` Anders Roxell [this message]
2023-09-16 20:04 ` Andrew Morton
2023-10-09 12:15 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 13/19] kmsan: use stack_depot_save instead of __stack_depot_save andrey.konovalov
2023-10-09 10:00 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename andrey.konovalov
2023-09-15 20:31 ` Marco Elver
2023-09-15 23:42 ` Andrey Konovalov
2023-10-09 10:09 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 15/19] lib/stackdepot: add refcount for records andrey.konovalov
2023-10-09 11:40 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 16/19] lib/stackdepot: allow users to evict stack traces andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 17/19] kasan: remove atomic accesses to stack ring entries andrey.konovalov
2023-10-09 12:05 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 18/19] kasan: check object_size in kasan_complete_mode_report_info andrey.konovalov
2023-10-09 12:17 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 19/19] kasan: use stack_depot_put for tag-based modes andrey.konovalov
2023-10-09 12:24 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-10-05 20:35 ` [PATCH v2 00/19] stackdepot: allow evicting stack traces Andrey Konovalov
2023-10-09 12:35 ` Marco Elver
2023-10-09 19:39 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916174334.GA1030024@mutt \
--to=anders.roxell@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.