From: Alexander Potapenko <glider@google.com>
To: andrey.konovalov@linux.dev
Cc: Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations
Date: Fri, 6 Oct 2023 19:21:25 +0200 [thread overview]
Message-ID: <CAG_fn=XyqgfZO=bduYPTGpM9NovQPZOzZf8cidt7=m6H092sSg@mail.gmail.com> (raw)
In-Reply-To: <CAG_fn=UAF2aYD1mFbakNhcYk5yZR6tFeP8R-Yyq0p_7hy9owXA@mail.gmail.com>
On Fri, Oct 6, 2023 at 6:14 PM Alexander Potapenko <glider@google.com> wrote:
>
> On Wed, Sep 13, 2023 at 7:15 PM <andrey.konovalov@linux.dev> wrote:
> >
> > From: Andrey Konovalov <andreyknvl@google.com>
> >
> > Simplify comments accompanying the use of atomic accesses in the
> > stack depot code.
> >
> > Also drop smp_load_acquire from next_pool_required in depot_init_pool,
> > as both depot_init_pool and the all smp_store_release's to this variable
> > are executed under the stack depot lock.
Maybe add this to the comment before "if (!next_pool_required)" ?
next prev parent reply other threads:[~2023-10-06 17:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 17:14 [PATCH v2 00/19] stackdepot: allow evicting stack traces andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 01/19] lib/stackdepot: check disabled flag when fetching andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 02/19] lib/stackdepot: simplify __stack_depot_save andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 03/19] lib/stackdepot: drop valid bit from handles andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 04/19] lib/stackdepot: add depot_fetch_stack helper andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 05/19] lib/stackdepot: use fixed-sized slots for stack records andrey.konovalov
2023-09-15 8:55 ` Marco Elver
2023-09-15 16:46 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations andrey.konovalov
2023-10-06 16:14 ` Alexander Potapenko
2023-10-06 17:21 ` Alexander Potapenko [this message]
2023-10-23 16:15 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 07/19] lib/stackdepot: rework helpers for depot_alloc_stack andrey.konovalov
2023-10-09 8:59 ` Alexander Potapenko
2023-10-09 9:35 ` Alexander Potapenko
2023-10-23 16:16 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 08/19] lib/stackdepot: rename next_pool_required to new_pool_required andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 09/19] lib/stackdepot: store next pool pointer in new_pool andrey.konovalov
2023-09-19 16:13 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 10/19] lib/stackdepot: store free stack records in a freelist andrey.konovalov
2023-10-09 9:32 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 11/19] lib/stackdepot: use read/write lock andrey.konovalov
2023-10-09 9:45 ` Alexander Potapenko
2023-10-23 16:16 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 12/19] lib/stackdepot: use list_head for stack record links andrey.konovalov
2023-09-16 17:43 ` Anders Roxell
2023-09-16 20:04 ` Andrew Morton
2023-10-09 12:15 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 13/19] kmsan: use stack_depot_save instead of __stack_depot_save andrey.konovalov
2023-10-09 10:00 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename andrey.konovalov
2023-09-15 20:31 ` Marco Elver
2023-09-15 23:42 ` Andrey Konovalov
2023-10-09 10:09 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 15/19] lib/stackdepot: add refcount for records andrey.konovalov
2023-10-09 11:40 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 16/19] lib/stackdepot: allow users to evict stack traces andrey.konovalov
2023-09-13 17:14 ` [PATCH v2 17/19] kasan: remove atomic accesses to stack ring entries andrey.konovalov
2023-10-09 12:05 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-09-13 17:14 ` [PATCH v2 18/19] kasan: check object_size in kasan_complete_mode_report_info andrey.konovalov
2023-10-09 12:17 ` Alexander Potapenko
2023-09-13 17:14 ` [PATCH v2 19/19] kasan: use stack_depot_put for tag-based modes andrey.konovalov
2023-10-09 12:24 ` Alexander Potapenko
2023-10-23 16:17 ` Andrey Konovalov
2023-10-05 20:35 ` [PATCH v2 00/19] stackdepot: allow evicting stack traces Andrey Konovalov
2023-10-09 12:35 ` Marco Elver
2023-10-09 19:39 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=XyqgfZO=bduYPTGpM9NovQPZOzZf8cidt7=m6H092sSg@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.