From: Miquel Raynal <miquel.raynal@bootlin.com> To: Nikita Shubin via B4 Relay <devnull+nikita.shubin.maquefel.me@kernel.org> Cc: <nikita.shubin@maquefel.me>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <neil.armstrong@linaro.org>, Florian Fainelli <f.fainelli@gmail.com>, Liang Yang <liang.yang@amlogic.com>, Christophe Kerello <christophe.kerello@foss.st.com>, Jean Delvare <jdelvare@suse.de>, Johan Jonker <jbx6244@gmail.com>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Sverdlin <alexander.sverdlin@gmail.com> Subject: Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx Date: Mon, 18 Sep 2023 14:58:52 +0200 [thread overview] Message-ID: <20230918145852.46a15c77@xps-13> (raw) In-Reply-To: <20230915-ep93xx-v4-26-a1d779dcec10@maquefel.me> Hi Nikita, devnull+nikita.shubin.maquefel.me@kernel.org wrote on Fri, 15 Sep 2023 11:11:08 +0300: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > Technologic Systems has it's own nand controller implementation in CPLD. I initially agreed to accept a first version of this controller driver with a legacy API because people were apparently under time pressure to get this in. I see it's been a couple of months, so this is not that urgent after all. As the driver is only 166 lines long, I would strongly prefer a very straight ->exec_op() conversion in order to get rid of these ugly direct I/O accesses. Thanks, Miquèl > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > drivers/mtd/nand/raw/Kconfig | 7 + > drivers/mtd/nand/raw/Makefile | 1 + > drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++++++++++++++++++++ > 3 files changed, 174 insertions(+) > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Nikita Shubin via B4 Relay <devnull+nikita.shubin.maquefel.me@kernel.org> Cc: <nikita.shubin@maquefel.me>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <neil.armstrong@linaro.org>, Florian Fainelli <f.fainelli@gmail.com>, Liang Yang <liang.yang@amlogic.com>, Christophe Kerello <christophe.kerello@foss.st.com>, Jean Delvare <jdelvare@suse.de>, Johan Jonker <jbx6244@gmail.com>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Sverdlin <alexander.sverdlin@gmail.com> Subject: Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx Date: Mon, 18 Sep 2023 14:58:52 +0200 [thread overview] Message-ID: <20230918145852.46a15c77@xps-13> (raw) In-Reply-To: <20230915-ep93xx-v4-26-a1d779dcec10@maquefel.me> Hi Nikita, devnull+nikita.shubin.maquefel.me@kernel.org wrote on Fri, 15 Sep 2023 11:11:08 +0300: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > Technologic Systems has it's own nand controller implementation in CPLD. I initially agreed to accept a first version of this controller driver with a legacy API because people were apparently under time pressure to get this in. I see it's been a couple of months, so this is not that urgent after all. As the driver is only 166 lines long, I would strongly prefer a very straight ->exec_op() conversion in order to get rid of these ugly direct I/O accesses. Thanks, Miquèl > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > drivers/mtd/nand/raw/Kconfig | 7 + > drivers/mtd/nand/raw/Makefile | 1 + > drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++++++++++++++++++++ > 3 files changed, 174 insertions(+) >
next prev parent reply other threads:[~2023-09-18 12:59 UTC|newest] Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-15 8:10 [PATCH v4 00/42] ep93xx device tree conversion Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 01/42] gpio: ep93xx: split device in multiple Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-18 7:37 ` Andy Shevchenko 2023-09-18 7:37 ` Andy Shevchenko 2023-09-15 8:10 ` [PATCH v4 02/42] ARM: ep93xx: add swlocked prototypes Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-16 15:38 ` Alexander Sverdlin 2023-09-18 13:04 ` Alexander Sverdlin 2023-09-15 8:10 ` [PATCH v4 03/42] dt-bindings: clock: Add Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:36 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 04/42] clk: ep93xx: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-10-24 2:50 ` Stephen Boyd 2023-09-15 8:10 ` [PATCH v4 05/42] dt-bindings: pinctrl: Add " Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:37 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 06/42] pinctrl: add a Cirrus ep93xx SoC pin controller Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 07/42] dt-bindings: power: reset: Add ep93xx reset Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:39 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 08/42] power: reset: Add a driver for the " Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 09/42] dt-bindings: soc: Add Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:42 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 10/42] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 11/42] dt-bindings: timers: Add Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-10-15 21:40 ` Daniel Lezcano 2023-10-27 18:23 ` [tip: timers/core] " tip-bot2 for Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 12/42] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-10-11 13:30 ` Daniel Lezcano 2023-10-15 21:40 ` Daniel Lezcano 2023-10-27 18:23 ` [tip: timers/core] " tip-bot2 for Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 13/42] dt-bindings: rtc: Add Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:43 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 14/42] rtc: ep93xx: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 15/42] dt-bindings: watchdog: Add Cirrus EP93x Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:43 ` Krzysztof Kozlowski 2023-09-15 8:10 ` [PATCH v4 16/42] watchdog: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 8:10 ` [PATCH v4 17/42] dt-bindings: pwm: Add " Nikita Shubin via B4 Relay 2023-09-15 8:10 ` Nikita Shubin 2023-09-15 10:45 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 18/42] pwm: ep93xx: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 10:43 ` Uwe Kleine-König 2023-09-15 8:11 ` [PATCH v4 19/42] dt-bindings: spi: Add " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 10:47 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 20/42] spi: ep93xx: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 12:38 ` Mark Brown 2023-09-15 8:11 ` [PATCH v4 21/42] dt-bindings: net: Add " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 10:49 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 22/42] net: cirrus: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:11 ` [PATCH v4 23/42] dt-bindings: dma: Add " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 10:58 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 24/42] dma: cirrus: add DT support for " Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:11 ` [PATCH v4 25/42] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 11:00 ` Krzysztof Kozlowski 2023-09-15 11:00 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 26/42] mtd: nand: add support for ts72xx Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-18 12:58 ` Miquel Raynal [this message] 2023-09-18 12:58 ` Miquel Raynal 2023-09-15 8:11 ` [PATCH v4 27/42] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 11:00 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 28/42] ata: pata_ep93xx: add device tree support Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:17 ` Damien Le Moal 2023-09-15 8:53 ` Sergey Shtylyov 2023-09-15 8:11 ` [PATCH v4 29/42] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 11:05 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 30/42] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-18 7:27 ` Andy Shevchenko 2023-09-18 7:27 ` Andy Shevchenko 2023-09-15 8:11 ` [PATCH v4 31/42] dt-bindings: wdt: Add ts72xx Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 11:18 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 32/42] wdt: ts72xx: add DT support for ts72xx Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` [PATCH v4 33/42] gpio: ep93xx: add DT support for gpio-ep93xx Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` [PATCH v4 34/42] ARM: dts: add Cirrus EP93XX SoC .dtsi Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 11:24 ` Krzysztof Kozlowski 2023-09-15 8:11 ` [PATCH v4 35/42] ARM: dts: ep93xx: add ts7250 board Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:11 ` [PATCH v4 36/42] ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` [PATCH v4 37/42] pwm: ep93xx: drop legacy pinctrl Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:46 ` Linus Walleij 2023-09-15 8:46 ` Linus Walleij 2023-09-15 8:11 ` [PATCH v4 38/42] ata: pata_ep93xx: remove legacy pinctrl use Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:47 ` Linus Walleij 2023-09-15 8:47 ` Linus Walleij 2023-09-15 8:11 ` [PATCH v4 39/42] ARM: ep93xx: delete all boardfiles Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` [PATCH v4 40/42] ARM: ep93xx: soc: drop defines Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 8:11 ` [PATCH v4 41/42] ARM: dts: ep93xx: Add EDB9302 DT Nikita Shubin via B4 Relay 2023-09-15 8:11 ` Nikita Shubin 2023-09-15 8:11 ` [PATCH v4 42/42] ASoC: cirrus: edb93xx: Delete driver Nikita Shubin 2023-09-15 8:11 ` Nikita Shubin via B4 Relay 2023-09-15 12:26 ` Mark Brown 2023-09-18 7:39 ` [PATCH v4 00/42] ep93xx device tree conversion Andy Shevchenko 2023-09-18 7:39 ` Andy Shevchenko 2023-10-15 21:17 ` (subset) " Alexandre Belloni 2023-10-15 21:17 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230918145852.46a15c77@xps-13 \ --to=miquel.raynal@bootlin.com \ --cc=alexander.sverdlin@gmail.com \ --cc=arnd@arndb.de \ --cc=christophe.kerello@foss.st.com \ --cc=devnull+nikita.shubin.maquefel.me@kernel.org \ --cc=f.fainelli@gmail.com \ --cc=jbx6244@gmail.com \ --cc=jdelvare@suse.de \ --cc=liang.yang@amlogic.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=neil.armstrong@linaro.org \ --cc=nikita.shubin@maquefel.me \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.