Re: [PATCH 00/52] input: Convert to platform remove callback returning void - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Lee Jones" <lee@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Liang He" <windhl@126.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	chrome-platform@lists.linux.dev, "Arnd Bergmann" <arnd@arndb.de>,
	"Samuel Holland" <samuel@sholland.org>,
	"Andrey Moiseev" <o2g.org.ru@gmail.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Ruan Jinjie" <ruanjinjie@huawei.com>,
	"Yangtao Li" <frank.li@vivo.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"joewu (吳仲振)" <joewu@msi.com>, "Miloslav Trmac" <mitr@volny.cz>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Chen-Yu Tsai" <wens@csie.org>, "Andy Gross" <agross@kernel.org>,
	linux-input@vger.kernel.org, "Jeff LaBundy" <jeff@labundy.com>,
	linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Rob Herring" <robh@kernel.org>,
	"ye xingchen" <ye.xingchen@zte.com.cn>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Siarhei Volkau" <lis8215@gmail.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Benson Leung" <bleung@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Chen Jun" <chenjun102@huawei.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	kernel@pengutronix.de, patches@opensource.cirrus.com,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Bjorn Andersson" <andersson@kernel.org>
Subject: Re: [PATCH 00/52] input: Convert to platform remove callback returning void
Date: Sun, 24 Sep 2023 17:50:57 +0200	[thread overview]
Message-ID: <20230924155057.e4k4ruv5iggbt6q6@pengutronix.de> (raw)
In-Reply-To: <ZQ+jddG+UbuSD7pP@google.com>

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

Hello Dmitry,

On Sat, Sep 23, 2023 at 07:48:21PM -0700, Dmitry Torokhov wrote:
> On Wed, Sep 20, 2023 at 02:57:37PM +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this series converts all platform drivers below drivers/input to use
> > remove_new. The motivation is to get rid of an integer return code
> > that is (mostly) ignored by the platform driver core and error prone on
> > the driver side.
> > 
> > See commit 5c5a7680e67b ("platform: Provide a remove callback that
> > returns no value") for an extended explanation and the eventual goal.
> > 
> > There are no interdependencies between the patches. As there are still
> > quite a few drivers to convert, I'm happy about every patch that makes
> > it in. So even if there is a merge conflict with one patch until you
> > apply or a subject prefix is suboptimal, please apply the remainder of
> > this series anyhow.
> 
> Applied the lot (fixing the i8042-sparcio patch subject), thank you!

Thanks. In the meantime I found out why my process failed here: I only
fixed *.c, but this driver struct is defined in a header file
i8042-sparcio.h.

This file is only included by drivers/input/serio/i8042.h which in turn
is only included by drivers/input/serio/i8042.c. So there is only one
instance created, but I'd call that unusual anyhow.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]