From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Jonathan Corbet <corbet@lwn.net>, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 49/52] input: sun4i-ts - Convert to platform remove callback returning void Date: Wed, 20 Sep 2023 18:07:18 +0200 [thread overview] Message-ID: <22023189.EfDdHjke4D@jernej-laptop> (raw) In-Reply-To: <20230920125829.1478827-50-u.kleine-koenig@pengutronix.de> Dne sreda, 20. september 2023 ob 14:58:26 CEST je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/input/touchscreen/sun4i-ts.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c > b/drivers/input/touchscreen/sun4i-ts.c index bb3c6072fc82..92b2b840b4b7 > 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -375,7 +375,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) > return 0; > } > > -static int sun4i_ts_remove(struct platform_device *pdev) > +static void sun4i_ts_remove(struct platform_device *pdev) > { > struct sun4i_ts_data *ts = platform_get_drvdata(pdev); > > @@ -385,8 +385,6 @@ static int sun4i_ts_remove(struct platform_device *pdev) > > /* Deactivate all IRQs */ > writel(0, ts->base + TP_INT_FIFOC); > - > - return 0; > } > > static const struct of_device_id sun4i_ts_of_match[] = { > @@ -403,7 +401,7 @@ static struct platform_driver sun4i_ts_driver = { > .of_match_table = sun4i_ts_of_match, > }, > .probe = sun4i_ts_probe, > - .remove = sun4i_ts_remove, > + .remove_new = sun4i_ts_remove, > }; > > module_platform_driver(sun4i_ts_driver);
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Jonathan Corbet <corbet@lwn.net>, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 49/52] input: sun4i-ts - Convert to platform remove callback returning void Date: Wed, 20 Sep 2023 18:07:18 +0200 [thread overview] Message-ID: <22023189.EfDdHjke4D@jernej-laptop> (raw) In-Reply-To: <20230920125829.1478827-50-u.kleine-koenig@pengutronix.de> Dne sreda, 20. september 2023 ob 14:58:26 CEST je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/input/touchscreen/sun4i-ts.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c > b/drivers/input/touchscreen/sun4i-ts.c index bb3c6072fc82..92b2b840b4b7 > 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -375,7 +375,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) > return 0; > } > > -static int sun4i_ts_remove(struct platform_device *pdev) > +static void sun4i_ts_remove(struct platform_device *pdev) > { > struct sun4i_ts_data *ts = platform_get_drvdata(pdev); > > @@ -385,8 +385,6 @@ static int sun4i_ts_remove(struct platform_device *pdev) > > /* Deactivate all IRQs */ > writel(0, ts->base + TP_INT_FIFOC); > - > - return 0; > } > > static const struct of_device_id sun4i_ts_of_match[] = { > @@ -403,7 +401,7 @@ static struct platform_driver sun4i_ts_driver = { > .of_match_table = sun4i_ts_of_match, > }, > .probe = sun4i_ts_probe, > - .remove = sun4i_ts_remove, > + .remove_new = sun4i_ts_remove, > }; > > module_platform_driver(sun4i_ts_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-20 16:07 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-20 12:57 [PATCH 00/52] input: Convert to platform remove callback returning void Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 01/52] input: adp5520-keys - " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 02/52] input: cros_ec_keyb " Uwe Kleine-König 2023-09-21 3:21 ` Tzung-Bi Shih 2023-09-20 12:57 ` [PATCH 03/52] input: ep93xx_keypad " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 04/52] input: iqs62x-keys " Uwe Kleine-König 2023-09-21 11:29 ` Jeff LaBundy 2023-09-20 12:57 ` [PATCH 05/52] input: matrix_keypad " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 06/52] input: omap-keypad " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 07/52] input: omap4-keypad " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 08/52] input: samsung-keypad " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 09/52] input: sh_keysc " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 10/52] input: spear-keyboard " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 11/52] input: stmpe-keypad " Uwe Kleine-König 2023-09-20 12:57 ` Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 12/52] input: 88pm80x_onkey " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 13/52] input: da9052_onkey " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 14/52] input: da9055_onkey " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 15/52] input: ideapad_slidebar " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 16/52] input: m68kspkr " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 17/52] input: max8997_haptic " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 18/52] input: mc13783-pwrbutton " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 19/52] input: palmas-pwrbutton " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 20/52] input: pcap_keys " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 21/52] input: pcf50633-input " Uwe Kleine-König 2023-09-20 12:57 ` [PATCH 22/52] input: pcspkr " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 23/52] input: pm8941-pwrkey " Uwe Kleine-König 2023-09-20 13:03 ` Konrad Dybcio 2023-09-20 12:58 ` [PATCH 24/52] input: soc_button_array " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 25/52] input: sparcspkr " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 26/52] input: wistron_btns " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 27/52] input: wm831x-on " Uwe Kleine-König 2023-09-20 14:24 ` Charles Keepax 2023-09-20 12:58 ` [PATCH 28/52] input: navpoint " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 29/52] input: altera_ps2 " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 30/52] input: ams_delta_serio " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 31/52] input: apbps2 " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 32/52] input: arc_ps2 " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 33/52] input: ct82c710 " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 34/52] drivers/input/serio/i8042-sparcio.h :: " Uwe Kleine-König 2023-09-20 13:06 ` Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 35/52] input: i8042 - " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 36/52] input: ioc3kbd " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 37/52] input: maceps2 " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 38/52] input: olpc_apsp " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 39/52] input: ps2-gpio " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 40/52] input: q40kbd " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 41/52] input: rpckbd " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 42/52] input: sun4i-ps2 " Uwe Kleine-König 2023-09-20 12:58 ` Uwe Kleine-König 2023-09-20 16:07 ` Jernej Škrabec 2023-09-20 16:07 ` Jernej Škrabec 2023-09-20 12:58 ` [PATCH 43/52] input: xilinx_ps2 " Uwe Kleine-König 2023-09-20 12:58 ` Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 44/52] input: da9052_tsi " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 45/52] input: mainstone-wm97xx " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 46/52] input: mc13783_ts " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 47/52] input: pcap_ts " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 48/52] input: stmpe-ts " Uwe Kleine-König 2023-09-20 12:58 ` Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 49/52] input: sun4i-ts " Uwe Kleine-König 2023-09-20 12:58 ` Uwe Kleine-König 2023-09-20 16:07 ` Jernej Škrabec [this message] 2023-09-20 16:07 ` Jernej Škrabec 2023-09-20 12:58 ` [PATCH 50/52] input: ti_am335x_tsc " Uwe Kleine-König 2023-09-20 12:58 ` [PATCH 51/52] input: wm831x-ts " Uwe Kleine-König 2023-09-20 14:24 ` Charles Keepax 2023-09-20 12:58 ` [PATCH 52/52] input: wm97xx-core " Uwe Kleine-König 2023-09-20 14:24 ` Charles Keepax 2023-09-24 2:48 ` [PATCH 00/52] input: " Dmitry Torokhov 2023-09-24 15:50 ` Uwe Kleine-König 2023-09-30 15:37 ` Dmitry Torokhov 2023-11-13 3:23 ` patchwork-bot+chrome-platform 2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=22023189.EfDdHjke4D@jernej-laptop \ --to=jernej.skrabec@gmail.com \ --cc=corbet@lwn.net \ --cc=daniel.lezcano@linaro.org \ --cc=dmitry.torokhov@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=rafael.j.wysocki@intel.com \ --cc=samuel@sholland.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.