From: Peter Zijlstra <peterz@infradead.org>
To: "Kuyo Chang (張建文)" <Kuyo.Chang@mediatek.com>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"vschneid@redhat.com" <vschneid@redhat.com>,
"bristot@redhat.com" <bristot@redhat.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/1] sched/core: Fix stuck on completion for affine_move_task() when stopper disable
Date: Thu, 28 Sep 2023 17:19:17 +0200 [thread overview]
Message-ID: <20230928151917.GB29651@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230928151616.GD27245@noisy.programming.kicks-ass.net>
On Thu, Sep 28, 2023 at 05:16:16PM +0200, Peter Zijlstra wrote:
> AFAICT this is migrate_enable(), which acts on current, so how can the
> CPU that current runs on go away?
> Your patch has at least one very obvious resource leak.
Sorry those are not so, I ended up staring at the wrong
stop_one_cpu_nowait() :-/
Still, the rest is very much the case, if you can't describe the exact
race scenario, you can't be talking about a solution.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "Kuyo Chang (張建文)" <Kuyo.Chang@mediatek.com>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"vschneid@redhat.com" <vschneid@redhat.com>,
"bristot@redhat.com" <bristot@redhat.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/1] sched/core: Fix stuck on completion for affine_move_task() when stopper disable
Date: Thu, 28 Sep 2023 17:19:17 +0200 [thread overview]
Message-ID: <20230928151917.GB29651@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230928151616.GD27245@noisy.programming.kicks-ass.net>
On Thu, Sep 28, 2023 at 05:16:16PM +0200, Peter Zijlstra wrote:
> AFAICT this is migrate_enable(), which acts on current, so how can the
> CPU that current runs on go away?
> Your patch has at least one very obvious resource leak.
Sorry those are not so, I ended up staring at the wrong
stop_one_cpu_nowait() :-/
Still, the rest is very much the case, if you can't describe the exact
race scenario, you can't be talking about a solution.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-28 15:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 3:34 [PATCH 1/1] sched/core: Fix stuck on completion for affine_move_task() when stopper disable Kuyo Chang
2023-09-27 3:34 ` Kuyo Chang
2023-09-27 8:08 ` Peter Zijlstra
2023-09-27 8:08 ` Peter Zijlstra
2023-09-27 15:57 ` Kuyo Chang (張建文)
2023-09-27 15:57 ` Kuyo Chang (張建文)
2023-09-28 15:16 ` Peter Zijlstra
2023-09-28 15:16 ` Peter Zijlstra
2023-09-28 15:19 ` Peter Zijlstra [this message]
2023-09-28 15:19 ` Peter Zijlstra
2023-09-29 10:21 ` Peter Zijlstra
2023-09-29 10:21 ` Peter Zijlstra
2023-10-01 15:15 ` Kuyo Chang (張建文)
2023-10-01 15:15 ` Kuyo Chang (張建文)
2023-10-10 14:40 ` Kuyo Chang (張建文)
2023-10-10 14:40 ` Kuyo Chang (張建文)
2023-10-10 14:57 ` Peter Zijlstra
2023-10-10 14:57 ` Peter Zijlstra
2023-10-10 20:04 ` [PATCH] sched: Fix stop_one_cpu_nowait() vs hotplug Peter Zijlstra
2023-10-10 20:04 ` Peter Zijlstra
2023-10-11 3:24 ` Kuyo Chang (張建文)
2023-10-11 3:24 ` Kuyo Chang (張建文)
2023-10-11 13:26 ` Peter Zijlstra
2023-10-11 13:26 ` Peter Zijlstra
2023-10-13 8:06 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928151917.GB29651@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Kuyo.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.