All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.Li@nxp.com>
To: miquel.raynal@bootlin.com
Cc: Frank.Li@nxp.com, alexander.stein@ew.tq-group.com,
	alexandre.belloni@bootlin.com, conor+dt@kernel.org,
	conor.culhane@silvaco.com, conor@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com,
	haibo.chen@nxp.com, imx@lists.linux.dev, joe@perches.com,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-i3c@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
	robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
	sherry.sun@nxp.com, xiaoning.wang@nxp.com
Subject: [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc
Date: Tue, 17 Oct 2023 15:46:56 -0400	[thread overview]
Message-ID: <20231017194657.3199749-1-Frank.Li@nxp.com> (raw)

In the binding documentation, the compatible string is specified as
'silvaco,i3c-master-v1', but in the driver, it is defined as
'silvaco,i3c-master'.

Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
compatibility with the documentation.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - Miquèl think drop silvaco,i3c-master totally. I grep dts tree. No
    upstream dts use silvaco,i3c-master yet.
      I have not add "Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>",
    it is different solution with previous one even just one line change.
      I think v2/v3 both is good, feel free to pick each one.
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index cf932ee056ef9..e307ba2b965e6 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1650,7 +1650,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops = {
 };
 
 static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
-	{ .compatible = "silvaco,i3c-master" },
+	{ .compatible = "silvaco,i3c-master-v1"},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.Li@nxp.com>
To: miquel.raynal@bootlin.com
Cc: Frank.Li@nxp.com, alexander.stein@ew.tq-group.com,
	alexandre.belloni@bootlin.com, conor+dt@kernel.org,
	conor.culhane@silvaco.com, conor@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com,
	haibo.chen@nxp.com, imx@lists.linux.dev, joe@perches.com,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-i3c@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
	robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
	sherry.sun@nxp.com, xiaoning.wang@nxp.com
Subject: [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc
Date: Tue, 17 Oct 2023 15:46:56 -0400	[thread overview]
Message-ID: <20231017194657.3199749-1-Frank.Li@nxp.com> (raw)

In the binding documentation, the compatible string is specified as
'silvaco,i3c-master-v1', but in the driver, it is defined as
'silvaco,i3c-master'.

Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
compatibility with the documentation.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - Miquèl think drop silvaco,i3c-master totally. I grep dts tree. No
    upstream dts use silvaco,i3c-master yet.
      I have not add "Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>",
    it is different solution with previous one even just one line change.
      I think v2/v3 both is good, feel free to pick each one.
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index cf932ee056ef9..e307ba2b965e6 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1650,7 +1650,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops = {
 };
 
 static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
-	{ .compatible = "silvaco,i3c-master" },
+	{ .compatible = "silvaco,i3c-master-v1"},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.Li@nxp.com>
To: miquel.raynal@bootlin.com
Cc: Frank.Li@nxp.com, alexander.stein@ew.tq-group.com,
	alexandre.belloni@bootlin.com, conor+dt@kernel.org,
	conor.culhane@silvaco.com, conor@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com,
	haibo.chen@nxp.com, imx@lists.linux.dev, joe@perches.com,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-i3c@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
	robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
	sherry.sun@nxp.com, xiaoning.wang@nxp.com
Subject: [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc
Date: Tue, 17 Oct 2023 15:46:56 -0400	[thread overview]
Message-ID: <20231017194657.3199749-1-Frank.Li@nxp.com> (raw)

In the binding documentation, the compatible string is specified as
'silvaco,i3c-master-v1', but in the driver, it is defined as
'silvaco,i3c-master'.

Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
compatibility with the documentation.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - Miquèl think drop silvaco,i3c-master totally. I grep dts tree. No
    upstream dts use silvaco,i3c-master yet.
      I have not add "Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>",
    it is different solution with previous one even just one line change.
      I think v2/v3 both is good, feel free to pick each one.
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index cf932ee056ef9..e307ba2b965e6 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1650,7 +1650,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops = {
 };
 
 static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
-	{ .compatible = "silvaco,i3c-master" },
+	{ .compatible = "silvaco,i3c-master-v1"},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
-- 
2.34.1


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

             reply	other threads:[~2023-10-17 19:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 19:46 Frank Li [this message]
2023-10-17 19:46 ` [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc Frank Li
2023-10-17 19:46 ` Frank Li
2023-10-17 19:46 ` [PATCH v2 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2 Frank Li
2023-10-17 19:46   ` Frank Li
2023-10-17 19:46   ` Frank Li
2023-11-09 15:51   ` Frank Li
2023-11-09 15:51     ` Frank Li
2023-11-09 15:51     ` Frank Li
2023-11-09 16:51     ` Krzysztof Kozlowski
2023-11-09 16:51       ` Krzysztof Kozlowski
2023-11-09 16:51       ` Krzysztof Kozlowski
2023-11-27  2:21     ` Shawn Guo
2023-11-27  2:21       ` Shawn Guo
2023-11-27  2:21       ` Shawn Guo
2023-11-27  9:35       ` Conor Dooley
2023-11-27  9:35         ` Conor Dooley
2023-11-27  9:35         ` Conor Dooley
2023-12-06  5:46         ` Frank Li
2023-12-06  5:46           ` Frank Li
2023-12-06  5:46           ` Frank Li
2023-12-06  9:31           ` Shawn Guo
2023-12-06  9:31             ` Shawn Guo
2023-12-06  9:31             ` Shawn Guo
2023-12-06 16:33             ` Frank Li
2023-12-06 16:33               ` Frank Li
2023-12-06 16:33               ` Frank Li
2023-12-13  8:12   ` Shawn Guo
2023-12-13  8:12     ` Shawn Guo
2023-12-13  8:12     ` Shawn Guo
2023-11-03 19:04 ` [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc Alexandre Belloni
2023-11-03 19:04   ` Alexandre Belloni
2023-11-03 19:04   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017194657.3199749-1-Frank.Li@nxp.com \
    --to=frank.li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.culhane@silvaco.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=joe@perches.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sherry.sun@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.