From: Frank Li <Frank.Li@nxp.com>
To: miquel.raynal@bootlin.com
Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/6] i3c: master: svc return actual transfer data len
Date: Wed, 18 Oct 2023 16:59:28 -0400 [thread overview]
Message-ID: <20231018205929.3435110-6-Frank.Li@nxp.com> (raw)
In-Reply-To: <20231018205929.3435110-1-Frank.Li@nxp.com>
I3C allow devices early terminate data transfer. So set "actual_len" to
indicate how much data get by i3c_priv_xfer.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/i3c/master/svc-i3c-master.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 6cd4cab26141c..17e953a47b1bb 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -138,6 +138,7 @@ struct svc_i3c_cmd {
const void *out;
unsigned int len;
unsigned int actual_len;
+ struct i3c_priv_xfer *xfer;
bool continued;
};
@@ -1052,6 +1053,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master,
if (readl(master->regs + SVC_I3C_MERRWARN) & SVC_I3C_MERRWARN_NACK) {
ret = -ENXIO;
+ *actual_len = 0;
goto emit_stop;
}
@@ -1069,6 +1071,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master,
*/
if (SVC_I3C_MSTATUS_IBIWON(reg)) {
ret = -ENXIO;
+ *actual_len = 0;
goto emit_stop;
}
@@ -1164,6 +1167,10 @@ static void svc_i3c_master_start_xfer_locked(struct svc_i3c_master *master)
cmd->addr, cmd->in, cmd->out,
cmd->len, &cmd->actual_len,
cmd->continued);
+ /* cmd->xfer is NULL if I2C or CCC transfer */
+ if (cmd->xfer)
+ cmd->xfer->actual_len = cmd->actual_len;
+
if (ret)
break;
}
@@ -1351,6 +1358,7 @@ static int svc_i3c_master_priv_xfers(struct i3c_dev_desc *dev,
for (i = 0; i < nxfers; i++) {
struct svc_i3c_cmd *cmd = &xfer->cmds[i];
+ cmd->xfer = &xfers[i];
cmd->addr = master->addrs[data->index];
cmd->rnw = xfers[i].rnw;
cmd->in = xfers[i].rnw ? xfers[i].data.in : NULL;
--
2.34.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Frank Li <Frank.Li@nxp.com>
To: miquel.raynal@bootlin.com
Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/6] i3c: master: svc return actual transfer data len
Date: Wed, 18 Oct 2023 16:59:28 -0400 [thread overview]
Message-ID: <20231018205929.3435110-6-Frank.Li@nxp.com> (raw)
In-Reply-To: <20231018205929.3435110-1-Frank.Li@nxp.com>
I3C allow devices early terminate data transfer. So set "actual_len" to
indicate how much data get by i3c_priv_xfer.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/i3c/master/svc-i3c-master.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 6cd4cab26141c..17e953a47b1bb 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -138,6 +138,7 @@ struct svc_i3c_cmd {
const void *out;
unsigned int len;
unsigned int actual_len;
+ struct i3c_priv_xfer *xfer;
bool continued;
};
@@ -1052,6 +1053,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master,
if (readl(master->regs + SVC_I3C_MERRWARN) & SVC_I3C_MERRWARN_NACK) {
ret = -ENXIO;
+ *actual_len = 0;
goto emit_stop;
}
@@ -1069,6 +1071,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master,
*/
if (SVC_I3C_MSTATUS_IBIWON(reg)) {
ret = -ENXIO;
+ *actual_len = 0;
goto emit_stop;
}
@@ -1164,6 +1167,10 @@ static void svc_i3c_master_start_xfer_locked(struct svc_i3c_master *master)
cmd->addr, cmd->in, cmd->out,
cmd->len, &cmd->actual_len,
cmd->continued);
+ /* cmd->xfer is NULL if I2C or CCC transfer */
+ if (cmd->xfer)
+ cmd->xfer->actual_len = cmd->actual_len;
+
if (ret)
break;
}
@@ -1351,6 +1358,7 @@ static int svc_i3c_master_priv_xfers(struct i3c_dev_desc *dev,
for (i = 0; i < nxfers; i++) {
struct svc_i3c_cmd *cmd = &xfer->cmds[i];
+ cmd->xfer = &xfers[i];
cmd->addr = master->addrs[data->index];
cmd->rnw = xfers[i].rnw;
cmd->in = xfers[i].rnw ? xfers[i].data.in : NULL;
--
2.34.1
next prev parent reply other threads:[~2023-10-18 21:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 20:59 [PATCH v2 0/6] i3c: master: some improvment for i3c master Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-18 20:59 ` [PATCH v2 1/6] i3c: master: add enable(disable) hot join in sys entry Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-20 8:55 ` Zbigniew, Lukwinski
2023-10-20 8:55 ` Zbigniew, Lukwinski
2023-10-20 13:45 ` Miquel Raynal
2023-10-20 13:45 ` Miquel Raynal
2023-10-20 14:20 ` Frank Li
2023-10-20 14:20 ` Frank Li
2023-10-20 14:33 ` Miquel Raynal
2023-10-20 14:33 ` Miquel Raynal
2023-10-20 16:24 ` Frank Li
2023-10-20 16:24 ` Frank Li
[not found] ` <8a7ac52e-f102-6f5e-35ab-217e6ecc6ba5@linux.intel.com>
2023-10-20 20:25 ` Alexandre Belloni
2023-10-20 20:25 ` Alexandre Belloni
2023-10-20 20:36 ` Frank Li
2023-10-20 20:36 ` Frank Li
2023-10-20 20:42 ` Zbigniew, Lukwinski
2023-10-20 20:42 ` Zbigniew, Lukwinski
2023-11-05 15:36 ` Frank Li
2023-11-05 15:36 ` Frank Li
2023-10-18 20:59 ` [PATCH v2 2/6] i3c: master: svc: add hot join support Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-18 20:59 ` [PATCH v2 3/6] i3c: add actual_len in i3c_priv_xfer Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-18 20:59 ` [PATCH v2 4/6] i3c: svc: rename read_len as actual_len Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-18 20:59 ` Frank Li [this message]
2023-10-18 20:59 ` [PATCH v2 5/6] i3c: master: svc return actual transfer data len Frank Li
2023-10-18 20:59 ` [PATCH v2 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2023-10-18 20:59 ` Frank Li
2023-10-18 22:58 [PATCH v2 2/6] i3c: master: svc: add hot join support kernel test robot
2023-10-19 1:23 ` kernel test robot
2023-10-19 1:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018205929.3435110-6-Frank.Li@nxp.com \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.