From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
imx@lists.linux.dev, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] i3c: master: svc: fix ibi may not return mandatory data byte
Date: Fri, 20 Oct 2023 15:49:36 +0200 [thread overview]
Message-ID: <20231020154936.55a499ad@xps-13> (raw)
In-Reply-To: <20231019222725.3598022-4-Frank.Li@nxp.com>
Hi Frank,
Frank.Li@nxp.com wrote on Thu, 19 Oct 2023 18:27:22 -0400:
> MSTATUS[RXPEND] is only updated after the data transfer cycle started. This
> creates an issue when the I3C clock is slow, and the CPU is running fast
> enough that MSTATUS[RXPEND] may not be updated when the code reaches
> checking point. As a result, mandatory data can be missed.
>
> Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data is
> already in FIFO. It also works without mandatory data.
>
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
imx@lists.linux.dev, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] i3c: master: svc: fix ibi may not return mandatory data byte
Date: Fri, 20 Oct 2023 15:49:36 +0200 [thread overview]
Message-ID: <20231020154936.55a499ad@xps-13> (raw)
In-Reply-To: <20231019222725.3598022-4-Frank.Li@nxp.com>
Hi Frank,
Frank.Li@nxp.com wrote on Thu, 19 Oct 2023 18:27:22 -0400:
> MSTATUS[RXPEND] is only updated after the data transfer cycle started. This
> creates an issue when the I3C clock is slow, and the CPU is running fast
> enough that MSTATUS[RXPEND] may not be updated when the code reaches
> checking point. As a result, mandatory data can be missed.
>
> Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data is
> already in FIFO. It also works without mandatory data.
>
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-20 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 22:27 [PATCH v3 0/6] i3c: master: svc: collection of bugs fixes Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-19 22:27 ` [PATCH v3 1/6] i3c: master: svc: fix race condition in ibi work thread Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-19 22:27 ` [PATCH v3 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-20 13:56 ` Miquel Raynal
2023-10-20 13:56 ` Miquel Raynal
2023-10-19 22:27 ` [PATCH v3 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-20 13:49 ` Miquel Raynal [this message]
2023-10-20 13:49 ` Miquel Raynal
2023-10-19 22:27 ` [PATCH v3 4/6] i3c: master: svc: fix check wrong status register in irq handler Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-20 13:50 ` Miquel Raynal
2023-10-20 13:50 ` Miquel Raynal
2023-10-19 22:27 ` [PATCH v3 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Frank Li
2023-10-19 22:27 ` Frank Li
2023-10-20 0:28 ` Frank Li
2023-10-20 0:28 ` Frank Li
2023-10-19 22:27 ` [PATCH v3 6/6] i3c: master: svc: fix random hot join failure since timeout error Frank Li
2023-10-19 22:27 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020154936.55a499ad@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.