From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/3] fanotify support for btrfs sub-volumes
Date: Wed, 25 Oct 2023 19:04:45 +0200 [thread overview]
Message-ID: <20231025170445.qks7etxtwivyqz22@quack3> (raw)
In-Reply-To: <ZTk1ffCMDe9GrJjC@infradead.org>
On Wed 25-10-23 08:34:21, Christoph Hellwig wrote:
> On Wed, Oct 25, 2023 at 04:50:45PM +0300, Amir Goldstein wrote:
> > Jan,
> >
> > This patch set implements your suggestion [1] for handling fanotify
> > events for filesystems with non-uniform f_fsid.
>
> File systems nust never report non-uniform fsids (or st_dev) for that
> matter. btrfs is simply broken here and needs to be fixed.
Well, this is the discussion how btrfs should be presenting its subvolumes
to VFS / userspace, isn't it? I never dived into that too closely but as
far as I remember it was discussed to death without finding an acceptable
(to all parties) solution? I guess having a different fsid per subvolume
makes sense (and we can't change that given it is like that forever even if
we wanted). Having different subvolumes share one superblock is more
disputable but there were reasons for that as well. So I'm not sure how you
imagine to resolve this...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-10-25 17:04 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 13:50 [PATCH 0/3] fanotify support for btrfs sub-volumes Amir Goldstein
2023-10-25 13:50 ` [PATCH 1/3] fs: define a new super operation to get fsid Amir Goldstein
2023-10-25 13:50 ` [PATCH 2/3] btrfs: implement " Amir Goldstein
2023-10-25 13:50 ` [PATCH 3/3] fanotify: support reporting events with fid on btrfs sub-volumes Amir Goldstein
2023-10-25 15:34 ` [PATCH 0/3] fanotify support for " Christoph Hellwig
2023-10-25 17:04 ` Jan Kara [this message]
2023-10-27 5:44 ` Christoph Hellwig
2023-10-27 10:58 ` Jan Kara
2023-10-25 21:06 ` Josef Bacik
2023-10-25 23:02 ` Qu Wenruo
2023-10-26 5:49 ` Amir Goldstein
2023-10-27 5:46 ` Christoph Hellwig
2023-10-27 13:17 ` Josef Bacik
2023-10-27 13:47 ` Miklos Szeredi
2023-10-28 5:57 ` Amir Goldstein
2023-10-30 13:25 ` Christoph Hellwig
2023-10-31 12:14 ` Christian Brauner
2023-10-31 12:22 ` Christoph Hellwig
2023-10-31 12:50 ` Christian Brauner
2023-10-31 17:06 ` Christoph Hellwig
2023-11-01 0:03 ` Qu Wenruo
2023-11-03 14:21 ` Christoph Hellwig
2023-11-01 8:16 ` Christian Brauner
2023-11-01 8:41 ` Qu Wenruo
2023-11-01 9:52 ` Christian Brauner
2023-11-02 5:13 ` Josef Bacik
2023-11-02 8:53 ` Amir Goldstein
2023-11-02 9:48 ` Christian Brauner
2023-11-02 12:34 ` Josef Bacik
2023-11-02 17:07 ` David Sterba
2023-11-02 20:32 ` Josef Bacik
2023-11-03 6:56 ` Christian Brauner
2023-11-03 13:52 ` Josef Bacik
2023-11-02 11:07 ` Christian Brauner
2023-11-03 14:28 ` Christoph Hellwig
2023-11-03 15:47 ` Christian Brauner
2023-11-06 7:53 ` Christoph Hellwig
2023-11-06 8:18 ` Qu Wenruo
2023-11-06 9:56 ` Christian Brauner
2023-11-06 12:25 ` Christoph Hellwig
2023-11-06 10:03 ` Christian Brauner
2023-11-06 10:41 ` Qu Wenruo
2023-11-06 10:59 ` Christian Brauner
2023-11-06 12:30 ` Christoph Hellwig
2023-11-06 13:05 ` Christian Brauner
2023-11-06 17:10 ` Christoph Hellwig
2023-11-07 8:58 ` Christian Brauner
2023-11-08 7:56 ` Christoph Hellwig
2023-11-08 8:09 ` Christian Brauner
2023-11-08 8:12 ` Christoph Hellwig
2023-11-08 8:22 ` Christian Brauner
2023-11-08 14:07 ` Christoph Hellwig
2023-11-08 15:57 ` Christian Brauner
2023-11-06 12:29 ` Christoph Hellwig
2023-11-06 13:47 ` Christian Brauner
2023-11-06 17:13 ` Christoph Hellwig
2023-11-06 22:42 ` Josef Bacik
2023-11-07 9:06 ` Christian Brauner
2023-11-08 7:52 ` Christoph Hellwig
2023-11-08 8:27 ` Christian Brauner
2023-11-08 14:08 ` Christoph Hellwig
2023-11-08 16:16 ` Christian Brauner
2023-11-08 16:20 ` Christian Brauner
2023-11-09 6:55 ` Christoph Hellwig
2023-11-09 9:07 ` Christian Brauner
2023-11-09 14:41 ` Christoph Hellwig
2023-11-10 9:33 ` Christian Brauner
2023-11-10 10:31 ` Amir Goldstein
2023-11-09 6:53 ` Christoph Hellwig
2023-11-08 7:51 ` Christoph Hellwig
2023-11-08 11:08 ` Jan Kara
2023-11-08 14:11 ` Christoph Hellwig
2023-11-06 9:03 ` Jan Kara
2023-11-06 9:52 ` Christian Brauner
2023-11-06 12:22 ` Jan Kara
2023-11-03 14:23 ` Christoph Hellwig
2023-11-03 14:22 ` Christoph Hellwig
2023-10-25 17:17 ` Amir Goldstein
2023-10-25 18:02 ` Amir Goldstein
2023-10-26 12:17 ` Jan Kara
2023-10-26 12:36 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025170445.qks7etxtwivyqz22@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.